Re: [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Mike,


On 23/11/2021 09:21 PM, Michael D Kinney wrote:
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +            "4002", "HobConstructor"
> +        ],

I noticed there are other ECC errors with ID 4002 in StandaloneMmPkg.

e.g.

edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLib.c(24): 
[4002]Function header doesn't exist Function [CreateHob] has NO comment 
immediately preceding it.
edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLibInternal.c(24): 
[4002]Function header doesn't exist Function [HobConstructor] has NO 
comment immediately preceding it.
edk2\StandaloneMmPkg\Library\StandaloneMmHobLib\StandaloneMmHobLib.c(247): 
[4002]Function header doesn't exist Function [CreateHob] has NO comment 
immediately preceding it.
edk2\StandaloneMmPkg\Library\StandaloneMmPeCoffExtraActionLib\AArch64\StandaloneMmPeCoffExtraActionLib.c(26): 
[4002]Function header doesn't exist Function [UpdatePeCoffPermissions] 
has NO comment immediately preceding it.

I am trying to undestand how the ExceptionList works. Would Keyword = 
HobConstructor ignore the other errors too?

We will look into getting these issues fixed. However, to unblock this 
patch can proceed.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar