From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.86]) by mx.groups.io with SMTP id smtpd.web08.4596.1637751319940014123 for ; Wed, 24 Nov 2021 02:55:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=vrXG6ekr; spf=pass (domain: arm.com, ip: 40.107.0.86, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QeS3IzgiIfpvN5EMl6yh9Wm13S6qGqMgHzimabFdms=; b=vrXG6ekr5Vw8dBHYFQHlc2F1gomFd/0f2T8PWIbcl0hkYhznu86G3IAp+UhWWJE2LMLQ6Z+I4bSJs6lLZainCV6l7kc2abivSRKkKf2V/4F5LVYeCAGKQR1P5Yimq632xx9hSa/yWuFli+5eQrZM8V6YbpqW4k3aI/XsgPzmxbo= Received: from AM4PR0902CA0010.eurprd09.prod.outlook.com (2603:10a6:200:9b::20) by AM0PR08MB4482.eurprd08.prod.outlook.com (2603:10a6:208:140::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Wed, 24 Nov 2021 10:55:16 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::9a) by AM4PR0902CA0010.outlook.office365.com (2603:10a6:200:9b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend Transport; Wed, 24 Nov 2021 10:55:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Wed, 24 Nov 2021 10:55:16 +0000 Received: ("Tessian outbound de6049708a0a:v110"); Wed, 24 Nov 2021 10:55:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a32b7b00582a6e06 X-CR-MTA-TID: 64aa7808 Received: from 7d4f89c0727c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D553A39-CD2D-42F7-A537-EEE6014F7797.1; Wed, 24 Nov 2021 10:55:04 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7d4f89c0727c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 24 Nov 2021 10:55:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YjM0ssg50wetHmnigjY03Jpem2bpv3XARJ/BvMKKavQf2cZRl/p/ZZ1HOXM15N1g+6u9yaLg+PNQJZq8vPIzpV1Yr/9ED0IEz+l54oqqBAjG9m1IBQndB3zmF7CfuZDOT88wJO5txIjlMcbvaViVvFVC8xf69FPwftqQMJ+Ji37gK0TCEZd29vtXrNAHLkFIeM1dxaA6+PhVrFp+tDEfeBtpefrJy2cBrZocUTUNwBwQNCejgZjrsVkt6ARR7bdqZyX99XLZgZgQIGoK3RslWtVokk05jwA0fGmh8Z70DN565R5HFy+XclxQh51+YlJPdM9ivfda4uJB4v12X70OoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2QeS3IzgiIfpvN5EMl6yh9Wm13S6qGqMgHzimabFdms=; b=m/l2CKSDvVgJ8O+NnhbRlunsOAtIL8EzWYl38AVfK0xG3+NpZzm9SW3Uw7r5HO2L4Iqu/jfADlD2Ubc2pdz4N1gRvhQ9xvxKiYMwOKsTH6jnEh4O2MjI99QYfMxxZUy+B78UIRsTm8jp8pd72Qt6FBbgjuI66AG89qx8i85Ydkc4iyuWGiGI28LHBcaUi/b4csCY8ezxLEA3AweKB7eqpDQbBqy/fLZ5TbypGWRsem03jE/KhnseyErvIRadOWuBTPePvLE2fU0RA2/gIYza8yGiwE21svqp79/vg5fc8Yr3JW448zV85ZyZ2WBMxHRRB+r6rxHPWmI1SBoesUmnRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QeS3IzgiIfpvN5EMl6yh9Wm13S6qGqMgHzimabFdms=; b=vrXG6ekr5Vw8dBHYFQHlc2F1gomFd/0f2T8PWIbcl0hkYhznu86G3IAp+UhWWJE2LMLQ6Z+I4bSJs6lLZainCV6l7kc2abivSRKkKf2V/4F5LVYeCAGKQR1P5Yimq632xx9hSa/yWuFli+5eQrZM8V6YbpqW4k3aI/XsgPzmxbo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB2098.eurprd08.prod.outlook.com (2603:10a6:203:4a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Wed, 24 Nov 2021 10:55:01 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4713.025; Wed, 24 Nov 2021 10:55:01 +0000 Subject: Re: [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors To: Michael D Kinney , devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Supreeth Venkatesh , Sean Brogan , Bret Barkelew , Liming Gao , Michael Kubacki , nd References: <20211123212122.1348-1-michael.d.kinney@intel.com> <20211123212122.1348-11-michael.d.kinney@intel.com> From: "Sami Mujawar" Message-ID: <22d17fb9-3731-2f28-ee7f-f70c8a2fb5e5@arm.com> Date: Wed, 24 Nov 2021 10:55:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211123212122.1348-11-michael.d.kinney@intel.com> X-ClientProxiedBy: LO2P265CA0294.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0294.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Wed, 24 Nov 2021 10:55:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46f3304f-b6c8-4a63-082c-08d9af38e637 X-MS-TrafficTypeDiagnostic: AM5PR0801MB2098:|AM0PR08MB4482: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jBcJuj6AaDOQ8nY2cNIvmTIyWJ2C0zyHciP199IIpZ8GZ1+Pm6vRL8hDYHyYnO2xfPGjcsGp1XBaHx7WdRuYwGA6jvr3BcY3WXvHAlpGnJKmH4PHBUwB9VKJaQIV7KNPwoLFDHQaXxwOwqkuW/qEKBu7tokvQPD6rYJFVdbLJWzTq9LpkK+bGZgYaI56Z/DuGKG9czElDYNVJVGkb5OhM+Hix1RzM/vQ7JTKXzCHmtb+Gir2P2ErmUQbI2vJaqWT5RJ7ETAwXSSrHHq/EhDCFWw5j+nneEyL2ht9yfbmPQeAg0z43Ny1hNUOY2NH0t7tXkM/Vs33M+chYhPxsk4VL2Le9U6qLWyz0feqks9y3TgBeL5ohd+sX+LgnE1ZZLeTWPvza3Xw6JxHCLid2XToykeQjiSagwji0skBzPQZgcKMoV8pBDb7BrMfn3Dp7k0GpRXP6NJnAkEoSwqhGfXCm3obXY8LzpzrZfWhYt1Q+O9BfZLp4V00kFQwsZKswiOvAz9/EBrZZhpnsM3PNbwhYflipBvTpxODdKSDrHoWKSlUnZQviA9NY4I51MujIXq01Es+vdnDY2vbT1Qe7Ki1pw8yNANKMLyRVS96xwIwPynilfxOuySIKM0RnAjYMeMju0Vr0nBf5iMPWpGfMAXeVskQnAVJUaWsJW/G83vK/0OunRzt45ZQ3xxMzesJ9/pbxw/drZ4BCFIIkmNBV6Ra9ZaS9ke9Sn69rqXf4f3cbw3FeEZCnuANMf/w9dWdUOXbmQu69Ukbfc5yJNsks9SSrA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(26005)(31696002)(66556008)(83380400001)(31686004)(16576012)(2616005)(36756003)(38350700002)(2906002)(38100700002)(52116002)(66476007)(15650500001)(956004)(66946007)(53546011)(4326008)(54906003)(8676002)(508600001)(8936002)(44832011)(86362001)(5660300002)(186003)(6486002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2098 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d346fe84-315c-40eb-a13f-08d9af38dd3d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cbHLF54fVv41KBN0+zNwwtC/7EpIJ+94CV+5VY2YENUo3ZG87OkM3H2ffkB7GZ7g1jt9RAt1WtfWhzlcJab0D334sIaTE907VA+29l+5AD9EOGV4OXi8NagivvGHOCaKKY7liQb+ncPJGJbs6NWsncU4gRNg6WTfKRNA5RnWThEOPRe/Kh0YnoW3FWl1Hu6G/OXpifhK8htlCJxOvLa4qtxyriKNsb2lignrDmvGsFHCe01Aexu24jng+/hbNZpaISs9EO0YXs671Z84qs3sb9r9JLB6H4N057vJmouIvAO27xbMq2TVcIXt6egUp4FhiWpV+QJApkwrz42VgqYXcQ2w3AGWcCI2nms/dfU/yt5qDVag7hh4ZIEThixw3mE3AfgOlOvOZyRcNSfR5igwOqteimLJVjLQue13caNzZsV2Kivw0H/0+HjUJi2v1YIeq4YHpUl0mpHTJ51FA/TBTyuMX/7nlF326nubQC5BEFOpSZ+jvy/y7BERZJUi8ZUpiUKvFELFZmgNnmU6Kw3Jlhe8RB4i1pQKhY+KLVoRICol4goK9v9jmW75plTz18znMUgwvRYvxTLxyhVHD/W+Hl4cHqAhNnrCWyEmPq23dSm/E9hYjZ83q1cfOVJT1VrNLKcb8ft138XyTWUiwX0P0Kt0pLCJwkFCYhp5Aamv1F2JA6tbAwPEAyZ1YOIPcZNuES3DcUiM9LuY1+tzqFlEc9znZR9NBoZPpzuNX9NXboI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(46966006)(36840700001)(86362001)(8676002)(4326008)(36860700001)(26005)(8936002)(6486002)(5660300002)(81166007)(2906002)(508600001)(16576012)(36756003)(15650500001)(31686004)(53546011)(82310400004)(316002)(186003)(44832011)(70206006)(31696002)(2616005)(47076005)(83380400001)(956004)(70586007)(54906003)(356005)(336012)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2021 10:55:16.3922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46f3304f-b6c8-4a63-082c-08d9af38e637 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4482 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Mike, On 23/11/2021 09:21 PM, Michael D Kinney wrote: > + "EccCheck": { > + ## Exception sample looks like below: > + ## "ExceptionList": [ > + ## "", "" > + ## ] > + "ExceptionList": [ > + "4002", "HobConstructor" > + ], I noticed there are other ECC errors with ID 4002 in StandaloneMmPkg. e.g. edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLib.c(24): [4002]Function header doesn't exist Function [CreateHob] has NO comment immediately preceding it. edk2\StandaloneMmPkg\Library\StandaloneMmCoreHobLib\Arm\StandaloneMmCoreHobLibInternal.c(24): [4002]Function header doesn't exist Function [HobConstructor] has NO comment immediately preceding it. edk2\StandaloneMmPkg\Library\StandaloneMmHobLib\StandaloneMmHobLib.c(247): [4002]Function header doesn't exist Function [CreateHob] has NO comment immediately preceding it. edk2\StandaloneMmPkg\Library\StandaloneMmPeCoffExtraActionLib\AArch64\StandaloneMmPeCoffExtraActionLib.c(26): [4002]Function header doesn't exist Function [UpdatePeCoffPermissions] has NO comment immediately preceding it. I am trying to undestand how the ExceptionList works. Would Keyword = HobConstructor ignore the other errors too? We will look into getting these issues fixed. However, to unblock this patch can proceed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar