From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59F982194D392 for ; Wed, 26 Apr 2017 12:46:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A0AA820CCA6; Wed, 26 Apr 2017 19:46:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A0AA820CCA6 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A0AA820CCA6 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-72.phx2.redhat.com [10.3.116.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3BBB77EC0; Wed, 26 Apr 2017 19:46:06 +0000 (UTC) To: Jeff Westfahl References: <1493228430-15322-1-git-send-email-jeff.westfahl@ni.com> <7a8b3c50-10ed-8eb7-7653-f37a63430a01@redhat.com> Cc: "Carsey, Jaben" , "edk2-devel@lists.01.org" , "Ni, Ruiyu" From: Laszlo Ersek Message-ID: <22d1ef65-2e54-944e-d842-bbe17251a43e@redhat.com> Date: Wed, 26 Apr 2017 21:46:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 26 Apr 2017 19:46:07 +0000 (UTC) Subject: Re: [PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~ X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 19:46:08 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/26/17 21:37, Jeff Westfahl wrote: > Hi Laszlo, > > I liked your description so much that I copied it basically word for > word in my PATCH v2 commit description. Is there some way I can > attribute this to you in the commit description? Sure! For example, add: (parts of) the commit message were inspired by Laszlo's example: https://lists.01.org/pipermail/edk2-devel/2017-April/010266.html (Bonus points if you replace inspired by with shamelessly stolen from which is an expression I like a lot ;) ) Much appreciated! :) Laszlo > > Regards, > Jeff > > On Wed, 26 Apr 2017, Laszlo Ersek wrote: > >> On 04/26/17 20:00, Carsey, Jaben wrote: >>> I think that this is a correct change, but I do not understand the >>> problem this solves. >> >> The problem is presumably that, if you have a string like >> >> {xizzy}~{foo|bar}~{quux} >> >> in the dumped data, it will not appear as such in the *-delimited ASCII >> column to the right, but as >> >> .xizzy...foo.bar...quux. >> >> which is less than ideal. >> >> Thanks, >> Laszlo >> >>> >>> -Jaben >>> >>>> -----Original Message----- >>>> From: Jeff Westfahl [mailto:jeff.westfahl@ni.com] >>>> Sent: Wednesday, April 26, 2017 10:41 AM >>>> To: edk2-devel@lists.01.org >>>> Cc: Jeff Westfahl ; Ni, Ruiyu >>>> ; >>>> Carsey, Jaben >>>> Subject: [edk2][PATCH] ShellPkg/ShellCommandLib: Update DumpHex to >>>> print {|}~ >>>> Importance: High >>>> >>>> ASCII characters {|}~ should be printed by DumpHex. >>>> >>>> Cc: Ruiyu Ni >>>> Cc: Jaben Carsey >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Jeff Westfahl >>>> --- >>>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>>> b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>>> index a2ebc8f..bd14878 100644 >>>> --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>>> +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c >>>> @@ -1745,7 +1745,7 @@ DumpHex ( >>>> Val[Index * 3 + 0] = Hex[TempByte >> 4]; >>>> Val[Index * 3 + 1] = Hex[TempByte & 0xF]; >>>> Val[Index * 3 + 2] = (CHAR8) ((Index == 7) ? '-' : ' '); >>>> - Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > >>>> 'z') ? '.' : >>>> TempByte); >>>> + Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > >>>> '~') ? '.' : >>>> TempByte); >>>> } >>>> >>>> Val[Index * 3] = 0; >>>> -- >>>> 2.7.4 >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >>> >> >>