From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web09.2904.1611974278650471349
 for <devel@edk2.groups.io>;
 Fri, 29 Jan 2021 18:37:58 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eZ5xvHCY;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1611974277;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zsJ5UKD5HHHloLZapX5tFc9fvnHO/x/HPunrslRmAyE=;
	b=eZ5xvHCYK6RcT0LETqbqERBkB3WWUMsaesW6sy5pHJx5He9XVQBG8vxGdZD7Ww+WTfSE8S
	N3Mak16ujMEy7kdr31m769J48EljLdW+EwCBJgqn0SM6V9d8rNexjd4vJxEIfFx4ZU80Th
	2TlcZVudRJ9/VphSuWkqc5wQliaU2bo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-31-PcjGsWDNNbq7kZt7FC6ezg-1; Fri, 29 Jan 2021 21:37:55 -0500
X-MC-Unique: PcjGsWDNNbq7kZt7FC6ezg-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85CE78030A2;
	Sat, 30 Jan 2021 02:37:54 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-14.ams2.redhat.com [10.36.112.14])
	by smtp.corp.redhat.com (Postfix) with ESMTP id F2EEE5D71B;
	Sat, 30 Jan 2021 02:37:52 +0000 (UTC)
Subject: Re: [PATCH v6 4/9] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()
To: Ankur Arora <ankur.a.arora@oracle.com>, devel@edk2.groups.io
Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Aaron Young <aaron.young@oracle.com>
References: <20210129005950.467638-1-ankur.a.arora@oracle.com>
 <20210129005950.467638-5-ankur.a.arora@oracle.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <22d2d12e-3b3b-65de-5eec-538e5899d117@redhat.com>
Date: Sat, 30 Jan 2021 03:37:52 +0100
MIME-Version: 1.0
In-Reply-To: <20210129005950.467638-5-ankur.a.arora@oracle.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/29/21 01:59, Ankur Arora wrote:
> Introduce UnplugCpus() which maps each APIC ID being unplugged
> onto the hardware ID of the processor and informs PiSmmCpuDxeSmm
> of removal by calling EFI_SMM_CPU_SERVICE_PROTOCOL.RemoveProcessor().
> 
> With this change we handle the first phase of unplug where we collect
> the CPUs that need to be unplugged and mark them for removal in SMM
> data structures.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Aaron Young <aaron.young@oracle.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132
> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
> ---
>  OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 84 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)

I intend to continue the review at this patch, next week.

Thanks
Laszlo