From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH 03/14] DynamicTablesPkg: Update CmObjParser for IORT Rev E.d
Date: Wed, 26 Oct 2022 13:34:02 +0100 [thread overview]
Message-ID: <22e077ba-0067-f56a-689b-861305056e12@arm.com> (raw)
In-Reply-To: <20221010092058.118714-4-Pierre.Gondois@arm.com>
Hi Pierre,
I have one comment marked inline as [SAMI].
Other than that change this patch should be good.
Regards,
Sami Mujawar
On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> commit de200b7e2c3c ("DynamicTablesPkg: Update ArmNameSpaceObjects for
> IORT Rev E.d")
> adds new CmObj structures and fields to the ArmNameSpaceObjects.
> Update the CmObjectParser accordingly.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> .../ConfigurationManagerObjectParser.c | 59 ++++++++++++++-----
> 1 file changed, 45 insertions(+), 14 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> index b46f19693bb5..80ebb0708661 100644
> --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> @@ -183,21 +183,23 @@ STATIC CONST CM_OBJ_PARSER CmArmFixedFeatureFlagsParser[] = {
> STATIC CONST CM_OBJ_PARSER CmArmItsGroupNodeParser[] = {
> { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> { "ItsIdCount", 4, "0x%x", NULL },
> - { "ItsIdToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }
> + { "ItsIdToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> + { "Identifier", 4, "0x%x", NULL },
> };
>
> /** A parser for EArmObjNamedComponent.
> */
> STATIC CONST CM_OBJ_PARSER CmArmNamedComponentNodeParser[] = {
> - { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> - { "IdMappingCount", 4, "0x%x", NULL },
> - { "IdMappingToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> - { "Flags", 4, "0x%x", NULL },
> - { "CacheCoherent", 4, "0x%x", NULL },
> - { "AllocationHints", 1, "0x%x", NULL },
> - { "MemoryAccessFlags", 1, "0x%x", NULL },
> - { "AddressSizeLimit", 1, "0x%x", NULL },
> - { "ObjectName", sizeof (CHAR8 *), "%a", NULL }
> + { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> + { "IdMappingCount", 4, "0x%x", NULL },
> + { "IdMappingToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> + { "Flags", 4, "0x%x", NULL },
> + { "CacheCoherent", 4, "0x%x", NULL },
> + { "AllocationHints", 1, "0x%x", NULL },
> + { "MemoryAccessFlags", 1, "0x%x", NULL },
> + { "AddressSizeLimit", 1, "0x%x", NULL },
> + { "ObjectName", 1, NULL, PrintString },
[SAMI] I think the Length field for ObjectName should be "sizeof (CHAR8
*)" otherwise PrintCmObjDesc() would not advance to the next field
correctly/
If you agree, I will make this change locally before pushing the patch.
[/SAMI]
> + { "Identifier", 4, "0x%x", NULL },
> };
>
> /** A parser for EArmObjRootComplex.
> @@ -211,7 +213,10 @@ STATIC CONST CM_OBJ_PARSER CmArmRootComplexNodeParser[] = {
> { "MemoryAccessFlags", 1, "0x%x", NULL },
> { "AtsAttribute", 4, "0x%x", NULL },
> { "PciSegmentNumber", 4, "0x%x", NULL },
> - { "MemoryAddressSize", 1, "0x%x", NULL }
> + { "MemoryAddressSize", 1, "0x%x", NULL },
> + { "PasidCapabilities", 2, "0x%x", NULL },
> + { "Flags", 4, "0x%x", NULL },
> + { "Identifier", 4, "0x%x", NULL },
> };
>
> /** A parser for EArmObjSmmuV1SmmuV2.
> @@ -231,7 +236,8 @@ STATIC CONST CM_OBJ_PARSER CmArmSmmuV1SmmuV2NodeParser[] = {
> { "SMMU_NSgIrpt", 4, "0x%x", NULL },
> { "SMMU_NSgIrptFlags", 4, "0x%x", NULL },
> { "SMMU_NSgCfgIrpt", 4, "0x%x", NULL },
> - { "SMMU_NSgCfgIrptFlags", 4, "0x%x", NULL }
> + { "SMMU_NSgCfgIrptFlags", 4, "0x%x", NULL },
> + { "Identifier", 4, "0x%x", NULL },
> };
>
> /** A parser for EArmObjSmmuV3.
> @@ -249,7 +255,8 @@ STATIC CONST CM_OBJ_PARSER CmArmSmmuV3NodeParser[] = {
> { "GerrInterrupt", 4, "0x%x", NULL },
> { "SyncInterrupt", 4, "0x%x", NULL },
> { "ProximityDomain", 4, "0x%x", NULL },
> - { "DeviceIdMappingIndex", 4, "0x%x", NULL }
> + { "DeviceIdMappingIndex", 4, "0x%x", NULL },
> + { "Identifier", 4, "0x%x", NULL },
> };
>
> /** A parser for EArmObjPmcg.
> @@ -261,7 +268,8 @@ STATIC CONST CM_OBJ_PARSER CmArmPmcgNodeParser[] = {
> { "BaseAddress", 8, "0x%llx", NULL },
> { "OverflowInterrupt", 4, "0x%x", NULL },
> { "Page1BaseAddress", 8, "0x%llx", NULL },
> - { "ReferenceToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }
> + { "ReferenceToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> + { "Identifier", 4, "0x%x", NULL },
> };
>
> /** A parser for EArmObjGicItsIdentifierArray.
> @@ -432,6 +440,25 @@ STATIC CONST CM_OBJ_PARSER CmPciInterruptMapInfoParser[] = {
> ARRAY_SIZE (CmArmGenericInterruptParser) },
> };
>
> +/** A parser for EArmObjRmr.
> +*/
> +STATIC CONST CM_OBJ_PARSER CmArmRmrInfoParser[] = {
> + { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> + { "IdMappingCount", 4, "0x%x", NULL },
> + { "IdMappingToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> + { "Identifier", 4, "0x%x", NULL },
> + { "Flags", 4, "0x%x", NULL },
> + { "MemRangeDescCount", 4, "0x%x", NULL },
> + { "MemRangeDescToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL },
> +};
> +
> +/** A parser for EArmObjMemoryRangeDescriptor.
> +*/
> +STATIC CONST CM_OBJ_PARSER CmArmMemoryRangeDescriptorInfoParser[] = {
> + { "BaseAddress", 8, "0x%llx", NULL },
> + { "Length", 8, "0x%llx", NULL },
> +};
> +
> /** A parser for EArmObjCpcInfo.
> */
> STATIC CONST CM_OBJ_PARSER CmArmCpcInfoParser[] = {
> @@ -588,6 +615,10 @@ STATIC CONST CM_OBJ_PARSER_ARRAY ArmNamespaceObjectParser[] = {
> ARRAY_SIZE (CmArmPciAddressMapInfoParser) },
> { "EArmObjPciInterruptMapInfo", CmPciInterruptMapInfoParser,
> ARRAY_SIZE (CmPciInterruptMapInfoParser) },
> + { "EArmObjRmr", CmArmRmrInfoParser,
> + ARRAY_SIZE (CmArmRmrInfoParser) },
> + { "EArmObjMemoryRangeDescriptor", CmArmMemoryRangeDescriptorInfoParser,
> + ARRAY_SIZE (CmArmMemoryRangeDescriptorInfoParser) },
> { "EArmObjCpcInfo", CmArmCpcInfoParser,
> ARRAY_SIZE (CmArmCpcInfoParser) },
> { "EArmObjMax", NULL, 0 },
next prev parent reply other threads:[~2022-10-26 12:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 9:20 [PATCH 00/14] Add PCCT generator and various fixes PierreGondois
2022-10-10 9:20 ` [PATCH 01/14] DynamicTablesPkg: Use correct print formatter PierreGondois
2022-10-26 12:36 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 02/14] DynamicTablesPkg: Add PrintString to CmObjParser PierreGondois
2022-10-26 12:36 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 03/14] DynamicTablesPkg: Update CmObjParser for IORT Rev E.d PierreGondois
2022-10-26 12:34 ` Sami Mujawar [this message]
2022-10-28 10:05 ` PierreGondois
2022-10-10 9:20 ` [PATCH 04/14] DynamicTablesPkg: Update CmObjParser for MinorRevision PierreGondois
2022-10-26 12:36 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 05/14] DynamicTablesPkg: Fix GTBlock and GTBlockTimerFrame CmObjParsers PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 06/14] DynamicTablesPkg: Fix wrong/missing fields in CmObjParser PierreGondois
2022-10-26 12:34 ` Sami Mujawar
2022-10-28 10:05 ` PierreGondois
2022-10-10 9:20 ` [PATCH 07/14] DynamicTablesPkg: Remove deprecated APIs PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 08/14] DynamicTablesPkg: FdtHwInfoParserLib: Remove wrong comment PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 09/14] DynamicTablesPkg: Fix Ssdt PCI generation comments PierreGondois
2022-10-26 12:37 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 10/14] DynamicTablesPkg: Add PCCT related objects PierreGondois
2022-10-26 12:34 ` Sami Mujawar
2022-10-28 10:04 ` PierreGondois
2022-10-10 9:20 ` [PATCH 11/14] DynamicTablesPkg: Add PCCT Generator PierreGondois
2022-10-26 12:35 ` Sami Mujawar
2022-10-28 10:02 ` PierreGondois
2022-10-10 9:20 ` [PATCH 12/14] DynamicTablesPkg/AmlLib: Allow larger AccessSize for Pcc address space PierreGondois
2022-10-26 12:34 ` Sami Mujawar
2022-10-28 10:04 ` PierreGondois
2022-10-10 9:20 ` [PATCH 13/14] DynamicTablesPkg: Readme.md: Update available tables for generation PierreGondois
2022-10-26 12:07 ` Sami Mujawar
2022-10-10 9:20 ` [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5 PierreGondois
2022-10-26 12:06 ` Sami Mujawar
[not found] ` <171CAABD595C9750.32766@groups.io>
2022-10-10 9:48 ` [edk2-devel] " PierreGondois
2022-10-11 1:41 ` Ni, Ray
2022-10-31 13:34 ` [edk2-devel] [PATCH 00/14] Add PCCT generator and various fixes Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22e077ba-0067-f56a-689b-861305056e12@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox