From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.42]) by mx.groups.io with SMTP id smtpd.web09.7033.1666787663636637748 for ; Wed, 26 Oct 2022 05:34:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=AZIFHN/I; spf=pass (domain: arm.com, ip: 40.107.13.42, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CUl/wRAGC+vyBgKq0hUUKugjHk7UAYz/BazAokHbHNrdhTaHU5PxOu9MYiYpOi85vmtHCq1EWcq0kbN5hUyeXWEFTND/tbyjJQI/GRiomFpq2nk8OdOc3aVcQ1IEzyF+ec7G3jXWRZ3HkQKQUmULxsN3QHYDyK2RtOnWMnZYrBzPZos7y76c7Gh0tFpTXd4VtJxrdpKXXr4uULyWP9Dj/a9ywr37KzHTosd4f3pY1Knxz+fznRkuPbXpLfV+3hDUkFF58K01MtaLHbLjM36B0TwBXmPaQH4aNYhLkNvYwhsvC+vns7WzWjwnzTLKBqAwjqKWMsBRkj+KtfOaKE/9wg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2JrniC6ThdN5fevlL7m+SoatsDyXqg5o/sMCDO01rv4=; b=SjlwzvMwhn4Mwi2ZnrcPNn7k+g3V3r2S3X00mAqIo6z+IrHq5yn4T6mSby5yryt8z7+FAvouGpu9ZUsh0NRLmIksycWkeVuhsV89Sde0W1KvGRyd9Yoz0FxewWVyH0YNS6JYCdWNhYBsRrUSn34skREhALjlrZzoRca705d9Afnxo3nllKS+uNxdZWbedE5KlUXyC3NKGwT7ICtKdoGM8uGkPCvTqWK5wylRsOAyS224N7IK+0kttntjUGmhelW6szqX6QUyyTGmz/LEUKMPs4/BqdUk3BwT56WZGNdPjqRHJhipWG8nFui0f3p1lJjvRsTXo2rjQr574W+w++iwhw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2JrniC6ThdN5fevlL7m+SoatsDyXqg5o/sMCDO01rv4=; b=AZIFHN/IZZYF+cFUHDIQE/+4TtMQdbQLUhGo0hJ+YcbQIKVzVlUJq/kn+xSgtMxqemxFwLSwQAQt8BqAmx1DnRKdwRPDyqPWveAfDnTz5yru+cEeZMpUn7JzyxSrl5Kd+G0t0TrAu2sz4nk2i4c635WZLzr3q8XDSoH9w53+UnM= Received: from DB6PR0202CA0025.eurprd02.prod.outlook.com (2603:10a6:4:a5::11) by PAWPR08MB9055.eurprd08.prod.outlook.com (2603:10a6:102:343::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct 2022 12:34:18 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::16) by DB6PR0202CA0025.outlook.office365.com (2603:10a6:4:a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23 via Frontend Transport; Wed, 26 Oct 2022 12:34:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend Transport; Wed, 26 Oct 2022 12:34:17 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 26 Oct 2022 12:34:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e130f04ec954ccb6 X-CR-MTA-TID: 64aa7808 Received: from 96d500b2cc87.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A8EC1541-4CB8-4289-AAB0-DBFC3325C161.1; Wed, 26 Oct 2022 12:34:10 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96d500b2cc87.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:34:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oN/vOWLJKpPJ9A/1M7lmMTDZ6DnbGO3Nfu9ADq9yUDf330r+sKMy6tgmaPCyeJY2GOdL+A3sH7xVndDfAdiwc8TITP9Y0a+dpDPXHWzZoPccQbvXNg0I5qX+KEAUTO+N4cMGCaHVTx+5ZVhLv0CYHkNUCUpvgUjf0yKH95v3pCLWCn7dRtmVMO7ZZD84w4n7msaO+Ot6KlNyC6YSX6e77zhhgBpdvnWFt4lWFhVQ9TZX6Nj7e7jc3FxaqPK418S8YUXZ3qMKRUdCpE0au4WST4L4AYAyNNb3YW8soN/rWhy8qxFdYPJCT3PLH/FqA5PgoXMTpO/Liftg8ZA3rccV2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2JrniC6ThdN5fevlL7m+SoatsDyXqg5o/sMCDO01rv4=; b=GZFuIWCXe31Ey5vAFmvi0NFCJEsh4dbsbPVQUmbBz8Jwx3EhfSx65dULrvRXTSv+ntYycj93QQF+PG5il7ByUCL0DHyyh1rWgOQuK+xiLQK5d4ddIuq55fsiBmIUdX/7Wgdc1MptT7CV74uPGNFVncDTzxlILuP1RjxvnUGlOvIBhQCcEDnTjuU4FsHD4kr6g83MWq/92ZXkc0il+6hBVLsDxNcM9aQyinVBT+bprRuVjmRRYCvC6TOSzKkujhOVSeG/mtBDqyuvjFn8VyJbc3ly3tNvn9JjZEuYiJV0msfDPTTMyQij0Hp9B4Af1s9AFkr6zECnFZkKm319ywaSWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2JrniC6ThdN5fevlL7m+SoatsDyXqg5o/sMCDO01rv4=; b=AZIFHN/IZZYF+cFUHDIQE/+4TtMQdbQLUhGo0hJ+YcbQIKVzVlUJq/kn+xSgtMxqemxFwLSwQAQt8BqAmx1DnRKdwRPDyqPWveAfDnTz5yru+cEeZMpUn7JzyxSrl5Kd+G0t0TrAu2sz4nk2i4c635WZLzr3q8XDSoH9w53+UnM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBAPR08MB5813.eurprd08.prod.outlook.com (2603:10a6:10:1a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 12:34:04 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:34:04 +0000 Message-ID: <22e077ba-0067-f56a-689b-861305056e12@arm.com> Date: Wed, 26 Oct 2022 13:34:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 03/14] DynamicTablesPkg: Update CmObjParser for IORT Rev E.d To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-4-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-4-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P265CA0178.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DBAPR08MB5813:EE_|DBAEUR03FT033:EE_|PAWPR08MB9055:EE_ X-MS-Office365-Filtering-Correlation-Id: 11976033-77a0-41e7-54ea-08dab74e665e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sg+GH2tfTCpmcTUX62cAc+dK0BpMGkLkBCix7Nyoyg4icoXfznXYEH60c6jTl7mwlKMYux0kCcn07XffcVee62XWh3sPelUwa73+bn6hW1kxc2EQwdwrBhTpfucLmbcUrlQwBfcQnbu8b8PA6+UOZlX/CA26rETUycbj2lzGMeb6v04Z3JHTRzXBI7Ltr55Mdmhv6LJljlZTS/mQ2DkweKPfnKVXPso1izMbBgwc8dBuJ3NW2y0E+Pfzs0siKHvgqvRcUNvf0WrnNG8aDhybcpvqErwxoCn4UP9o8CA3b/cnE1oe0Zgt6eWUjwMpO+WHLx65uzlRW7ujf/JvwOf93ZZQ3r1NqvslMm/S4ijrcxXKsX9UBBdVuTw4IIJG89aeaHEuECs+LWOyE2+u0Y5NN8DcBcK9dhmzLRpTcCTWDEXW2kxbasRQA2lDgcFQPm/EkTqwwh7fEEi7hgoDngrqx+3NXhhUPdD+8y3jeIAdKzXKR/FkexpPqUrYVUggXf03ixTxS9i4W4weMh1fezzebP2oyr081790MLydivPBF4n25uZ6Uf/Onkf1NXckR5fonwW0ZmGjAYhiHEjw+9Ppfpum1j0S2HZAEWSeGtEzNiSRLRjRL+m8mT8MXW6+1XLgGLfk22gIBQfa05+SV71yKn8EO3Pd3mOXZ2Wb2Cx1/sdn2DTiWtLH78qWw30Qd9e00fqurgtOAZudXWelKBgEf7mEiajJ/77lzAUoC1b0V7g6xUO4NMhb3ZP4dlSBS3NOdmCC7GBCKcPfrgE/1yJ/SGCwT6hK92uoh4Af8rF+e1c= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(38100700002)(6512007)(36756003)(15650500001)(186003)(2906002)(31686004)(83380400001)(41300700001)(2616005)(26005)(8936002)(5660300002)(44832011)(6486002)(478600001)(86362001)(31696002)(6506007)(8676002)(66556008)(66946007)(66476007)(4326008)(53546011)(316002)(19627235002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5813 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 158162ea-60f0-4b88-6283-08dab74e5e0e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q+ql6l5MN/A2jCA91QntQZmIV2UyEmt5Xfp/zqhZAhSmSqTAQ5FIVGRZ2OycrvVlCz7vsdtOXqfmCHuH6eGq8WTF8pBonk7hk6idhBxKzgO6l1QeJiwtDa0fTtGh1pevgpVkHtyXnJ3anY3GjUldij6w2UMTTU33kHVcQ4yOIbcDSdYa1WtQd6rEi1F73zwme+FZMwjAWOgd0+gk4MepyLRzST6UbriKhPZBzROa/xoNJc0oGGMMzimb/7B33PyS1s0BB/zWVZoxbwCtzBc9LFmqK/Ck9UncnhKNkM7y4o66UsfzGVDWeOIJPh0OpIHWuUrDEOzo/2+hTkCOBjJrkbdq2vzJiJuCGikuO+gaIMquZin1fB5OoOGR5N8+1IKDVG3gb5AeXZBAvdWRV4NF61OfMzufA+rlnMSwTU0uzTlOcgJ39/PgoPbrGEv1YDX6n7ocS3gz/qSLnGWSIm6K0X9oNjUFOHkcJJ5QdeYIqTR2S2NSoSoxJvmlgaiqdFXvy0U42Nsmeqe9JiVMUzNGfECe+cGI/yTW2WNlyvGVVaarKvn0qhnrPY94P+Mt6YaS9+V6AaIvYc7egvHKXjhVlYWytkO0f4+1VQGxArjvRHn1VYByKqSjD0wZsnknpCd2rDjfQQy5Zq6kXbmsmmHqGbDq2j7MLLggiToVbaodJWf8DzdLNLe54Hfy0I2fV+po/c2QrXSHlvzZlNNyx56Pta4Ilk/0DZGxn8boFDbx3+Fkzk8iUnxR2OLFsramRmjAqULHaE43+TDRrf2PYya2NbGCcVwWj19LBM/36hQI1gR07TdFMYMOzjfO8k1bLq5I X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(8936002)(5660300002)(31686004)(44832011)(83380400001)(186003)(2906002)(41300700001)(86362001)(54906003)(336012)(81166007)(4326008)(47076005)(2616005)(36756003)(15650500001)(82310400005)(356005)(8676002)(70206006)(70586007)(6512007)(53546011)(6506007)(26005)(40480700001)(36860700001)(82740400003)(6486002)(316002)(31696002)(40460700003)(478600001)(19627235002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:34:17.9136 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11976033-77a0-41e7-54ea-08dab74e665e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9055 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, I have one comment marked inline as [SAMI]. Other than that change this patch should be good. Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > commit de200b7e2c3c ("DynamicTablesPkg: Update ArmNameSpaceObjects for > IORT Rev E.d") > adds new CmObj structures and fields to the ArmNameSpaceObjects. > Update the CmObjectParser accordingly. > > Signed-off-by: Pierre Gondois > --- > .../ConfigurationManagerObjectParser.c | 59 ++++++++++++++----- > 1 file changed, 45 insertions(+), 14 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > index b46f19693bb5..80ebb0708661 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > @@ -183,21 +183,23 @@ STATIC CONST CM_OBJ_PARSER CmArmFixedFeatureFlagsParser[] = { > STATIC CONST CM_OBJ_PARSER CmArmItsGroupNodeParser[] = { > { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > { "ItsIdCount", 4, "0x%x", NULL }, > - { "ItsIdToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL } > + { "ItsIdToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "Identifier", 4, "0x%x", NULL }, > }; > > /** A parser for EArmObjNamedComponent. > */ > STATIC CONST CM_OBJ_PARSER CmArmNamedComponentNodeParser[] = { > - { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > - { "IdMappingCount", 4, "0x%x", NULL }, > - { "IdMappingToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > - { "Flags", 4, "0x%x", NULL }, > - { "CacheCoherent", 4, "0x%x", NULL }, > - { "AllocationHints", 1, "0x%x", NULL }, > - { "MemoryAccessFlags", 1, "0x%x", NULL }, > - { "AddressSizeLimit", 1, "0x%x", NULL }, > - { "ObjectName", sizeof (CHAR8 *), "%a", NULL } > + { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "IdMappingCount", 4, "0x%x", NULL }, > + { "IdMappingToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "Flags", 4, "0x%x", NULL }, > + { "CacheCoherent", 4, "0x%x", NULL }, > + { "AllocationHints", 1, "0x%x", NULL }, > + { "MemoryAccessFlags", 1, "0x%x", NULL }, > + { "AddressSizeLimit", 1, "0x%x", NULL }, > + { "ObjectName", 1, NULL, PrintString }, [SAMI] I think the Length field for ObjectName should be "sizeof (CHAR8 *)" otherwise PrintCmObjDesc() would not advance to the next field correctly/ If you agree, I will make this change locally before pushing the patch. [/SAMI] > + { "Identifier", 4, "0x%x", NULL }, > }; > > /** A parser for EArmObjRootComplex. > @@ -211,7 +213,10 @@ STATIC CONST CM_OBJ_PARSER CmArmRootComplexNodeParser[] = { > { "MemoryAccessFlags", 1, "0x%x", NULL }, > { "AtsAttribute", 4, "0x%x", NULL }, > { "PciSegmentNumber", 4, "0x%x", NULL }, > - { "MemoryAddressSize", 1, "0x%x", NULL } > + { "MemoryAddressSize", 1, "0x%x", NULL }, > + { "PasidCapabilities", 2, "0x%x", NULL }, > + { "Flags", 4, "0x%x", NULL }, > + { "Identifier", 4, "0x%x", NULL }, > }; > > /** A parser for EArmObjSmmuV1SmmuV2. > @@ -231,7 +236,8 @@ STATIC CONST CM_OBJ_PARSER CmArmSmmuV1SmmuV2NodeParser[] = { > { "SMMU_NSgIrpt", 4, "0x%x", NULL }, > { "SMMU_NSgIrptFlags", 4, "0x%x", NULL }, > { "SMMU_NSgCfgIrpt", 4, "0x%x", NULL }, > - { "SMMU_NSgCfgIrptFlags", 4, "0x%x", NULL } > + { "SMMU_NSgCfgIrptFlags", 4, "0x%x", NULL }, > + { "Identifier", 4, "0x%x", NULL }, > }; > > /** A parser for EArmObjSmmuV3. > @@ -249,7 +255,8 @@ STATIC CONST CM_OBJ_PARSER CmArmSmmuV3NodeParser[] = { > { "GerrInterrupt", 4, "0x%x", NULL }, > { "SyncInterrupt", 4, "0x%x", NULL }, > { "ProximityDomain", 4, "0x%x", NULL }, > - { "DeviceIdMappingIndex", 4, "0x%x", NULL } > + { "DeviceIdMappingIndex", 4, "0x%x", NULL }, > + { "Identifier", 4, "0x%x", NULL }, > }; > > /** A parser for EArmObjPmcg. > @@ -261,7 +268,8 @@ STATIC CONST CM_OBJ_PARSER CmArmPmcgNodeParser[] = { > { "BaseAddress", 8, "0x%llx", NULL }, > { "OverflowInterrupt", 4, "0x%x", NULL }, > { "Page1BaseAddress", 8, "0x%llx", NULL }, > - { "ReferenceToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL } > + { "ReferenceToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "Identifier", 4, "0x%x", NULL }, > }; > > /** A parser for EArmObjGicItsIdentifierArray. > @@ -432,6 +440,25 @@ STATIC CONST CM_OBJ_PARSER CmPciInterruptMapInfoParser[] = { > ARRAY_SIZE (CmArmGenericInterruptParser) }, > }; > > +/** A parser for EArmObjRmr. > +*/ > +STATIC CONST CM_OBJ_PARSER CmArmRmrInfoParser[] = { > + { "Token", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "IdMappingCount", 4, "0x%x", NULL }, > + { "IdMappingToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "Identifier", 4, "0x%x", NULL }, > + { "Flags", 4, "0x%x", NULL }, > + { "MemRangeDescCount", 4, "0x%x", NULL }, > + { "MemRangeDescToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > +}; > + > +/** A parser for EArmObjMemoryRangeDescriptor. > +*/ > +STATIC CONST CM_OBJ_PARSER CmArmMemoryRangeDescriptorInfoParser[] = { > + { "BaseAddress", 8, "0x%llx", NULL }, > + { "Length", 8, "0x%llx", NULL }, > +}; > + > /** A parser for EArmObjCpcInfo. > */ > STATIC CONST CM_OBJ_PARSER CmArmCpcInfoParser[] = { > @@ -588,6 +615,10 @@ STATIC CONST CM_OBJ_PARSER_ARRAY ArmNamespaceObjectParser[] = { > ARRAY_SIZE (CmArmPciAddressMapInfoParser) }, > { "EArmObjPciInterruptMapInfo", CmPciInterruptMapInfoParser, > ARRAY_SIZE (CmPciInterruptMapInfoParser) }, > + { "EArmObjRmr", CmArmRmrInfoParser, > + ARRAY_SIZE (CmArmRmrInfoParser) }, > + { "EArmObjMemoryRangeDescriptor", CmArmMemoryRangeDescriptorInfoParser, > + ARRAY_SIZE (CmArmMemoryRangeDescriptorInfoParser) }, > { "EArmObjCpcInfo", CmArmCpcInfoParser, > ARRAY_SIZE (CmArmCpcInfoParser) }, > { "EArmObjMax", NULL, 0 },