From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.88]) by mx.groups.io with SMTP id smtpd.web10.1577.1634248714021719009 for ; Thu, 14 Oct 2021 14:58:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=4vd4NDx+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.88, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rx26r0DDoEdy+Qnd2PtvEicMUVUYF+5DeYdupUAocjoJKAb3rtymV4FTamfovcZlezZpev/87snPi2FIbZK23qsfzc2rr/zqdPPxP0AHVk4LWTpaUu02DQG75E1RgDgiaFlfBBJPM7J8WEbe7jdLX2i5f1Yqj3i3bus5H9NLLe0GF6ISs/p7o9B2xiiviHGJUi4oBe5H6cv4b26VLGzOxOYrlXMWP10+/fM3zKOT9C2fToXcoeb2kQ1gwkO8qqEq5pON3aoTfmvN8m1S/IBFZ9wQS3Kx/UWGu04uRZQ6eqQjT5EQiN4/zMG55TbTE5MoUL++zc8EhkQPZKkvMsIoWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u2wIOFlFV5poPwBL0ylQOAJPdv2HrsPIcgYownaiszM=; b=Ozx8SlY99gmb5WDL464V8y4cmYHnhny/BkOUDbS7rs3Vew8WSRMsS1tesW1UFb7eoFMiiZgU25jnr/wFz0qeLKMpeXVpv1aS9BESsLmzjSFQh0U/IqO2mUBktZBZm6huLE1+WmAnMYO51aZH/6OpJRTBXYnYF2VpSn9fjhGsLfesy4LRYZccyi9LeMe5pHDjDXYEC0PzMcSrcJXNIbyDOMsfTJLN4BDjhZqLJI7N3O8jTRHdYVFjB89eeR5wJvkUOhFrDLbcOHR6WPYwhTJaErdNgYO66fXWG5fSQd3ckYvBzOmBaEzhZsKMDjHsk7Nxg8GHlbFiRHTm4IejDxbd2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u2wIOFlFV5poPwBL0ylQOAJPdv2HrsPIcgYownaiszM=; b=4vd4NDx+CkB2vHxVNu+qqEwS4xZf1dxWEsfaWe8E0V2VtWHxCSTgj7YpZ5LupY0/inveZ+KFY4xyldaBDEY9ulFPt5pngf97YOYkwmiAHHxox0yDXLGivvZeOE1Rvomo9Odpkx57RkWGszioJPKD1ruKSTLNwjRySlQ3K0ql6po= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4574.namprd12.prod.outlook.com (2603:10b6:806:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 21:58:32 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021 21:58:31 +0000 Cc: brijesh.singh@amd.com, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth , Ray Ni , Rahul Kumar , Eric Dong Subject: Re: [edk2-devel] [PATCH v9 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status To: devel@edk2.groups.io, kraxel@redhat.com References: <20211013165713.727815-1-brijesh.singh@amd.com> <20211013165713.727815-23-brijesh.singh@amd.com> <20211014084128.6hnvptdxmpy5y2v7@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: <23101822-96e8-5b18-a441-554d8130af4c@amd.com> Date: Thu, 14 Oct 2021 16:58:27 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20211014084128.6hnvptdxmpy5y2v7@sirius.home.kraxel.org> X-ClientProxiedBy: SA9PR13CA0039.namprd13.prod.outlook.com (2603:10b6:806:22::14) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (165.204.78.25) by SA9PR13CA0039.namprd13.prod.outlook.com (2603:10b6:806:22::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.9 via Frontend Transport; Thu, 14 Oct 2021 21:58:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: edb678a2-73b5-4a88-e8d5-08d98f5dc303 X-MS-TrafficTypeDiagnostic: SA0PR12MB4574: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:459; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 19k5T30cifJwOc3rmHzVqiKziE09G6U+wpq7S9mn/0EqXHp6Qw3cI6KJ2RV0Ea6nZoHCRnPwIKKswP15UIRK2Bhv5FsWyqpzIZJhStRL8Z31UOFlGlW1Khb3bW1VgRH5T4aBy4GlbYb0EY+mR0hB5kwhpU4qPdtDFeOQAhTrtkNQg3pJ/zp2HN4DvjlRCq1t+iKx4UPJt26e05HoakIiN3jeiRYxONw1NzDkXJIU3BzSKpEdO7pXOeSW/vIO/PsA8xa20Rf4FoGutSsawUA1ljH50Y/T0tsIkhK2YWIxPn1KR8d9G6vkl1ULENaWHMPLz4L4oznEeUu9RnvSmTCCwREpjXUIckjJuRvv8F74gPsf1KoWqvHjSjAcF++DXiRjCwcrS1GpVDUZYALRHYVNnFWMHc81W3j0Ng7M7gLpmqGYdUsAyBkh7uWRR+J7I0v90xtULsLl8c54YeRuGwOGmqJzdXp6yucrqv6KfRGxzy11nRLSo7HkNq4DaxVj/IFsHJfw9/FWrB6g8q8ol1fkNavdpu7IpEvcTrrzWlRRY3p0VML27x/V3lRkhr/F0/JlHfsGX5ZG8yIIvTpuNb6/GzrbmZzzHvz6qY+/zLD+DfUZ0VM5aKumuho3TNVIB/a4MwXYj06k1YDDW3ygf3D9UdI0Qy4+64nfXh2Hg5PAd9w+7AMDUr1uoWyAzrY5C/Sd0lRweFRaqAIuGfGuW6pDpRuwliIpB5Fkui7VdgGjLBJ53O5bZo0SKtzi1GrV049o2znwy0/IgMVLEi8gkshDhleXVqyMGWRKpyNiuPfJkit+C1yrBsXTHOYk+KQGlNYmGJLaO10PAw7sAE+AuQX4lQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(66946007)(38100700002)(31696002)(83380400001)(6512007)(31686004)(8936002)(956004)(2906002)(66556008)(508600001)(6486002)(966005)(44832011)(316002)(54906003)(45080400002)(2616005)(7416002)(6666004)(4326008)(66476007)(36756003)(186003)(53546011)(5660300002)(26005)(86362001)(8676002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akpYeks5NEJqK0JlV0hJUFJDVmx6SXBkNFR2TmlnQ1lhanVNdUQ0NGFZVGtS?= =?utf-8?B?a3FyYzN3YUdUNzdCNElaMytweGZJYVdrcUgwbkVDYVZiYnlkMEt3V2pvS0xJ?= =?utf-8?B?Q1VnWElYMDVyYmV2QUY2NVBkWityRTVjQkFHLzdhZ3IwQzVETHppZmdjNTBs?= =?utf-8?B?NDY4bStZSFVvcTBKSGRoT1NkZXVqdUNWOERHbUkzVFY0c2YwQit3Z2Y2NUYz?= =?utf-8?B?SzNEbzdTSXEzSFJ0NGFkOE5SZm5keGY1WkZHOEhjRHZjdnlxaHhWVm1mKzdN?= =?utf-8?B?cGFnWG9VaHlhWWlKVWkrbHV4Ni82YzNSTitVb0ZDdDZ6d3JJTldoOGMyaHlo?= =?utf-8?B?UkU2eVlSVjhEYjJkY0QzZi91U0JZZUk2SnpUS1k0MEl0ODQ1VWUxeGFSeVlt?= =?utf-8?B?SWxpQkFWNDZhNTE2RWdFQ1VSQUpXK1BLSlZ1d1lMenJQU2MvNFlSKzFNYklw?= =?utf-8?B?Y2ZmcXJqUmlOOElqMWpNYU5BZTZPSms1dVVQNkdBQWpUUmU1Z3JkRGFPSmdV?= =?utf-8?B?T1BUYlpZM1hBTlpuR3B6SEdKTXZVOHZOQWhCYnZhSTR5QXl5Z2xxS0YwbjBW?= =?utf-8?B?d2JWeWdKTjhiclk1YktuK0V3bGdlcEx0ay9KblJpeFRjcVNJamEreEVPQ3pT?= =?utf-8?B?NjhOVElwRk5RSUVyM0ZYMWtISTdyZi9LYTFCT25ZYmlyWE5VZEQzWTNsNzJD?= =?utf-8?B?Q1NwTDJ6NFhZdnJQN0VSSGVNdUFNWHdvb3kwTGNFU1A3REY1UTV4Y0xTRDlQ?= =?utf-8?B?NlJTTzdRZlVRbUJnYkpYcE8rNDVmekw2Rm9UMWY1SHVnbVU2Zkl5d0pCY1dY?= =?utf-8?B?OXlKK29ZcGpxTml6Q0FPMEtFNFo2aVdvVWFURFlLUFF3dit6SS9YVVM3b21o?= =?utf-8?B?RWFVcWM5c1RkRUgrTm9OclhJK25vT2lhTHROQStDRUI4MHV6Ry9Ib3pYTmR5?= =?utf-8?B?K2tST0l2K3Qyb0RiTHh1cG41cHJGQXdOWmFQWXdDNSsySzgyOGkxMlFLc3d2?= =?utf-8?B?Y3FHdTJvam5kYWlmWUx5amdpczZ0N3NvcnI4LzdKaDYweFFjS0hUM05vcjFz?= =?utf-8?B?cmFXV3F1VUZGWmFGenY1Y1RzL2xIemtTOXNFZlI2TndNVFRNandZK0EyYXJa?= =?utf-8?B?TU01VGxhcExYb3VwWFo1WHhJS0d2TWdZV2w3dlVOWTJLMHB2QnZDb2dSd0Rp?= =?utf-8?B?enZmenVxQk1vNlMydS9mRDBLQjhuM2xqbEpjRW5CTi9NajlhMUZqTjZsd0U0?= =?utf-8?B?MmttMDJuU3RkTFdiNUNreDAvYkVqZXdXQmlqNFVPOE1tVGsrZ2V1YlJ0Z1hU?= =?utf-8?B?V1ZxSUZhM3o0OWdkcDFmMDZnRTRoRnp6TDE5TlhPbFBsTHJwSkNHdTBNUjU3?= =?utf-8?B?WlJTOWJBREw3Wjl1NXo1N3RTUlBITGZaTk9EYXdqQThqeFpqakJqVnRobnp4?= =?utf-8?B?aU90dU5SOVdYMFBIOENFeHkvUWxaNTB3cFEzRW9GaStpVDMzOFZxcEJmNjNB?= =?utf-8?B?Sndqb2YwSmVlU2Fmc3ZpMVUzNWlTSXAvNHJ2ZENmT29HVitDMTZaV1BwbllU?= =?utf-8?B?NU94T2xkbWt5YUM0Zk5IT013U0NrWVpjV25FRmFiV2NESUpEQ1QzTThOLy9H?= =?utf-8?B?OHc2K2FjbkhjQ0d0alFNZkNXSlZ3RzRuSGlkaTBDTjk2anJtOG45cnVrdzV4?= =?utf-8?B?V3dzL2FJRzBhRVBnQ3JZQmhzVUhGR0U4ak1VQkhNNTdHSGJVZGlFM2VvcCtq?= =?utf-8?Q?wsX5Gk/bFJ/+2NrnLC+73oqxpt3Lz73EEs1M42R?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: edb678a2-73b5-4a88-e8d5-08d98f5dc303 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 21:58:31.8508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gZBGqcaO9w6KLHBHQBG/TpZCkqDz1u7xp0cs8Kqv0iMenY3R6CQ1YA0xVuzIWPk25MSIY/TF3nHMHiVTi5dktA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4574 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 10/14/21 1:41 AM, Gerd Hoffmann via groups.io wrote: > On Wed, Oct 13, 2021 at 11:57:03AM -0500, Brijesh Singh wrote: >> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C45efbf71c7bc43fab38408d98eee7260%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637697977052800369%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2M1RTR8HQOAcpxA7tlWs%2B5uF%2Bn1JaLAFvagSn7v4SNw%3D&reserved=0 >> >> Previous commit introduced a generic confidential computing PCD that can >> determine whether AMD SEV-ES is enabled. Update the MpInitLib to drop the >> PcdSevEsIsEnabled in favor of PcdConfidentialComputingAttr. > Is there anything that guarantees MpLib initializes after PlatformPei so > it can depend on the PCD (see discussion in tdx thread) ? At least in the current Ovmf implementation the PlatformPei must initialize some of the PCDs used by the MpLibInit such as PcdCpuBootLogicalProcessorNumber and other AP related PCD. PlatformPei uses the Qemu FW_CFG to get the number of APs etc needed by the MpLibInit, so, I believe its safe to say that MpLib initializes after the PlatformPei. > > thanks, > Gerd > > > > > >