From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1E9A2740032 for ; Thu, 25 Apr 2024 22:04:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4GXpkcmLYrGSpIMpXJGCFAV4eKG1Jpp9MfN9VDheNMg=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1714082650; v=1; b=ar2z6xEirPN5B8I7KNyrya7v5fMtFjKiVa5t9lRnehjIm4yf41xCvKy4smB5fn716DvHd4jd r/R7Xs0gz/H1DHBZkS32G7BmeBgMV+wNz0IeJimlk9T8/dea9Sh2t3hW5x8eqcX9hKuY4B9VRKY L1yGxHiq6V9aRk4NyuOnNBLyjmgoY5Ux8VdS6z37BqNztVxXOY0xHs+rWTNsUU4jHqHntfxcGuW fDWTpuwoH+d7vY4bvuPKkcmfp81+EKBqRjy7zj6B4pUBkZUpr/5PnL4Vvjm+//CrkkwhPimXna5 hShnEBGBetEDJvRDX7ge3nSTmyzVSN4LiYCnbfvht56IA== X-Received: by 127.0.0.2 with SMTP id erjwYY7687511xMypnkOCp5E; Thu, 25 Apr 2024 15:04:10 -0700 X-Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web10.14005.1714042779675869764 for ; Thu, 25 Apr 2024 03:59:40 -0700 X-Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-34a3e0b31e6so673130f8f.1 for ; Thu, 25 Apr 2024 03:59:39 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXHwU5crGc8uDSiQ8Y3OEjO16J9mxw5jwGITVei9LPGd2PjyhRLotIP9Q5JC+lPuex3DrTeNWGDe6Nl9YA+4jdoLocYbg== X-Gm-Message-State: rqnJgNNjQHACKq3ZRKSP8avxx7686176AA= X-Google-Smtp-Source: AGHT+IG6WQ7cKaYqFwgmmNgoUrWZOhgJc+R60rthgA6fB6PhEy747eiVbTAL4NYU0SM4Wdpki2PfVw== X-Received: by 2002:adf:eaca:0:b0:343:9fec:eb35 with SMTP id o10-20020adfeaca000000b003439feceb35mr3705365wrn.24.1714042778103; Thu, 25 Apr 2024 03:59:38 -0700 (PDT) X-Received: from perard.uk.xensource.com (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id t10-20020a5d49ca000000b0034bfc32a4f6sm1847396wrs.48.2024.04.25.03.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 03:59:37 -0700 (PDT) Date: Thu, 25 Apr 2024 11:59:37 +0100 From: "Anthony PERARD via groups.io" To: Alejandro Vallejo Cc: Gerd Hoffmann , devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Set PcdCpuMaxLogicalProcessorNumber in OvmfXen Message-ID: <23141198-8725-4755-8f1f-2b35d6f3f4d7@perard> References: <5c832dc4-57e9-43a4-96ed-63074da2652f@cloud.com> MIME-Version: 1.0 In-Reply-To: <5c832dc4-57e9-43a4-96ed-63074da2652f@cloud.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 25 Apr 2024 15:04:07 -0700 Resent-From: anthony.perard@cloud.com Reply-To: devel@edk2.groups.io,anthony.perard@cloud.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ar2z6xEi; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Apr 25, 2024 at 11:42:01AM +0100, Alejandro Vallejo wrote: > Hi, > > On 25/04/2024 08:31, Gerd Hoffmann wrote: > > On Wed, Apr 24, 2024 at 02:36:32PM +0100, Alejandro Vallejo wrote: > >> Bump the compile-time constant for maximum processor count from 64 to 128 > >> in order to allow that many vCPUs to be brought online on Xen guests with > >> the default OVMF configuration. > > > >> + # UefiCpuPkg PCDs related to initial AP bringup and general AP management. > >> + gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|128 > > > > Note that this is a dynamic PCD, so you can set it at runtime to the > > number of vcpus present in the VM. See MaxCpuCountInitialization() in > > OvmfPkg/PlatformPei/Platform.c for example. > > > > take care, > > Gerd > > > > Thanks for the heads up. Do you mean setting it at runtime through > fw_cfg? I saw PlatformMaxCpuCountInitialization() providing some > customizability, but Xen's toolstack doesn't provide fw_cfg at the > moment so it can't (as far as I've seen) use it. We don't need fw_cfg to set a PCD at runtime. It's a bit more complicated than setting it at build time, but we can always ask Xen how many vcpu we have and set the PCD accordingly. This is something that can happen in OvmfPkg/XenPlatformPei module. But to be honest, I don't know if it's worth it, because I don't know the downside of having a higher value for PcdCpuMaxLogicalProcessorNumber. Cheers, -- Anthony PERARD -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118304): https://edk2.groups.io/g/devel/message/118304 Mute This Topic: https://groups.io/mt/105721898/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-