public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "Prabin CA" <prabin.ca@arm.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 5/6] Platform/Sgi: Define RD-V2 platform id values
Date: Sun, 31 Mar 2024 00:30:55 -0700	[thread overview]
Message-ID: <23235.1711870255685294610@groups.io> (raw)
In-Reply-To: <20240301162957.2854546-6-prabin.ca@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

Hi Prabin,

Thank you for this patch.
On Fri, Mar 1, 2024 at 08:30 AM, Prabin CA wrote:

> 
> Add RD-V2 platform identification values including the part number
> and configuration number. This information will be used in populating
> the SMBIOS tables.

In the cover letter you mention the following:
The system architecture of the RD-V2 platform is
similar to the RD-N2 platform, except for the CPU and L2 cache size. Unfortunately that information is lost when the patches are merged. I would prefer that to be included in the commit message for the relevant patch.
Also, I cannot find a patch similar to 4/6 for RD-N2 and there is no clear information on how one can build the firmware for RD-N2 platform. Can you clarify, please?
As you mention the differences from RD-N2 are CPU and L2 cache sizes, should the PPTT not be updated? I do not see a patch for that. Is something missing here?

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117254): https://edk2.groups.io/g/devel/message/117254
Mute This Topic: https://groups.io/mt/104668455/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1836 bytes --]

  parent reply	other threads:[~2024-03-31  7:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 16:29 [edk2-devel] [edk2-platforms][PATCH v5 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform Prabin CA
2024-03-01 16:29 ` [edk2-devel] [edk2-platforms][PATCH v5 1/6] Platform/Sgi: remove +nofp gcc option flag Prabin CA
2024-03-08 12:51   ` levi.yun
2024-03-01 16:29 ` [edk2-devel] [edk2-platforms][PATCH v5 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency Prabin CA
2024-03-08 12:52   ` levi.yun
2024-03-01 16:29 ` [edk2-devel] [edk2-platforms][PATCH v5 3/6] Platform/Sgi: Add a PCD to specify platform variant Prabin CA
2024-03-08 12:52   ` levi.yun
2024-03-01 16:29 ` [edk2-devel] [edk2-platforms][PATCH v5 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform Prabin CA
2024-03-08 12:53   ` levi.yun
2024-03-31  5:08   ` Sami Mujawar
2024-03-01 16:29 ` [edk2-devel] [edk2-platforms][PATCH v5 5/6] Platform/Sgi: Define RD-V2 platform id values Prabin CA
2024-03-08 12:53   ` levi.yun
2024-03-31  7:30   ` Sami Mujawar [this message]
2024-03-01 16:29 ` [edk2-devel] [edk2-platforms][PATCH v5 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform Prabin CA
2024-03-08 12:54   ` levi.yun
2024-03-04 10:52 ` [edk2-devel] [edk2-platforms][PATCH v5 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and " Thomas Abraham
2024-03-31  9:36 ` Sami Mujawar
2024-03-31  9:37   ` Sami Mujawar
2024-04-03 17:41   ` Prabin CA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23235.1711870255685294610@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox