From mboxrd@z Thu Jan 1 00:00:00 1970
Subject: ASL build tools - EDKII trim tool questions
To: devel@edk2.groups.io
From: erik.schmauss@intel.com
X-Originating-IP: 192.55.54.39
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Thu, 04 Apr 2019 12:08:17 -0700
Message-ID: <23357.1554404897032705015@groups.io>
Content-Type: multipart/alternative; boundary="8OOxNO3lPwukHtlOlFs1"
--8OOxNO3lPwukHtlOlFs1
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Hello,
I work on the ACPICA project (iASL, acpidump, acpiexec, and etc). I=E2=80=
=99ve been looking at the EDKII repository and tools that relate to ACPI a=
nd ASL.
In particular, I=E2=80=99ve been looking at the trim tool https://github.c=
om/tianocore/edk2/blob/master/BaseTools/Source/Python/Trim/Trim.py
According to the source code, the =E2=80=9C--asl-file=E2=80=9D option repl=
aces #include and Include (a.k.a. the =E2=80=9CASL include=E2=80=9D) with a=
ctual contents of the file.
I would prefer everyone to use iASL compiler to do this instead. The probl=
em with trim is that it makes iASL compiler errors more difficult to unders=
tand because the original file has been preprocessed by trim and the line n=
umbers from iASL remarks/warnings/errors do not make sense to the programme=
r... The iASL compiler handles ASL include statements as well as preprocess=
or #include statements. When compiling these files with include statements/=
directives, iASL displays the correct line number and file name of the incl=
uded file. Therefore, I think it would be beneficial to developers to use o=
nly iASL rather than trim "--asl-files" and iASL to work on ASL files.
I've been talking to some people internally about this trim tool but I wou=
ld like to ask this community if anyone has thoughts/opinions on deprecatin=
g trim's ASL option.
Thanks,
Erik
--8OOxNO3lPwukHtlOlFs1
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Hello,
I work on the ACPICA project (iASL, acpidump, ac=
piexec, and etc). I’ve been looking at the EDKII repository and tools=
that relate to ACPI and ASL.
In particular, I’ve been looking at the tr=
im tool https://github.com/tianocore/edk2/blob/master/B=
aseTools/Source/Python/Trim/Trim.py
According to the source code, the “--asl-f=
ile” option replaces #include and Include (a.k.a. the “ASL incl=
ude”) with actual contents of the file.
I would prefer everyone to use iASL compiler to =
do this instead. The problem with trim is that it makes iASL compiler error=
s more difficult to understand because the original file has been preproces=
sed by trim and the line numbers from iASL remarks/warnings/errors do not m=
ake sense to the programmer... The iASL compiler handles ASL include statem=
ents as well as preprocessor #include statements. When compiling these file=
s with include statements/directives, iASL displays the correct line number=
and file name of the included file. Therefore, I think it would be benefic=
ial to developers to use only iASL rather than trim "--asl-files" and iASL =
to work on ASL files.
I've been talking to some people internall=
y about this trim tool but I would like to ask this community if anyone has=
thoughts/opinions on deprecating trim's ASL option.
Thanks,
Erik
--8OOxNO3lPwukHtlOlFs1--