From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mx.groups.io with SMTP id smtpd.web08.4979.1606398151805351941 for ; Thu, 26 Nov 2020 05:42:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.191, mailfrom: xiewenyi2@huawei.com) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Chf7R1CwvzLvgB; Thu, 26 Nov 2020 21:41:55 +0800 (CST) Received: from [10.174.152.217] (10.174.152.217) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Thu, 26 Nov 2020 21:42:20 +0800 Subject: Re: [PATCH edk2-platforms 00/15] arm platform fixes triggered by VariablePolicy To: Leif Lindholm CC: References: <20201125125559.11631-1-leif@nuviainc.com> <20201125131154.GO1664@vanye> <0c7aa9c4-0367-f168-fc55-e8723cacdf57@huawei.com> <20201126133132.GW1664@vanye> From: "wenyi,xie" Message-ID: <233a9854-1f4e-71ba-b5c1-d504cc93bba1@huawei.com> Date: Thu, 26 Nov 2020 21:42:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: <20201126133132.GW1664@vanye> X-Originating-IP: [10.174.152.217] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit I see. I will add myself to Maintainers.txt later. Thanks Wenyi On 2020/11/26 21:31, Leif Lindholm wrote: > On Thu, Nov 26, 2020 at 18:44:55 +0800, xiewenyi (A) wrote: >> >> >> On 2020/11/25 21:11, Leif Lindholm wrote: >>> On Wed, Nov 25, 2020 at 12:55:44 +0000, Leif Lindholm wrote: >>>> The recently merged VariablePolicy set in edk2, >>>> d448574e7310..124b3f9289f1, broke everything[tm]. >>>> Fix up the ARM platforms I have any sort of history about, >>>> including some unrelated things that popped up along the way. >>>> >>>> Note: the hisilicon server platforms still don't build due to use >>>> of now deleted (previously deprecated) string functions in >>>> the SMBIOS code. Rebecca Cran has been sending out a genericised >>>> set *based* on this code, but now fixed. If Hisilicon could look >>>> into making use of that version instead, that might be less hassle >>>> than fixing the current implementation: >>>> https://edk2.groups.io/g/devel/message/67255 >>> >>> Double-whoops on the Hisilicon patches: >>> 1) Ming Huang bounces. >>> 2) I have a misfiled v3 of a set to deal with the above in my inbox >>> from Wenyi Xie >>> Adding them to this posting. >>> >>> Wenyi - could you add an entry or entries to Maintainers.txt for the >>> Hisilicon platforms? >>> >> May I ask what does entry mean, I don't understand. > > Maintainers.txt defines several sections, describing who should be > Cc:d on patches to different parts of the source tree. > > Ah, now that I look, I see we already have: > HiSilicon > F: Platform/Hisilicon/ > F: Silicon/Hisilicon/ > M: Leif Lindholm > R: Ard Biesheuvel > > However, it would be very useful to have someone from Hisilicon/Huawei > to help out with reviewing patches to the Hisilicon platforms. > And if the mobile/server platforms should have different reviewers, it > would be useful to reflect that as well. > At a minimum, could you send a patch adding yourself as a reviewer (R: > ) to the existing Hisilicon section? > > Best Regards, > > Leif > >> Thanks >> Wenyi >> >>> Best Regards, >>> >>> Leif >>> >>>> Cc: Abner Chang >>>> Cc: Ard Biesheuvel >>>> Cc: Bret Barkelew >>>> Cc: Daniel Schaefer >>>> Cc: Graeme Gregory >>>> Cc: Marcin Wojtas >>>> Cc: Meenakshi Aggarwal >>>> Cc: Ming Huang >>>> Cc: Radoslaw Biernacki >>>> Cc: Tanmay Jagdale >>>> Cc: Thomas Abraham >>>> >>>> Leif Lindholm (15): >>>> Silicon/AMD: update Styx to use PcdSet*S APIs >>>> Platform/AMD: add RngLib for Overdriveboard >>>> Platform,Silicon: fix beagleboard tautological compares >>>> Silicon/Hisilicon: add RngLib for Hisilicon >>>> Platform/ARM: VExpressPkg fixes to work with new VariablePolicyLib >>>> Platform/AMD: add VariablePolicy library resolutions for Overdrive >>>> Platform/SoftIron: add VariablePolicy resolutions for Overdrive1000 >>>> Platform/LeMaker: add VariablePolicy resolutions for cello >>>> Platform/SiFive: add VariablePolicy resolutions >>>> Platform/Qemu: add VariablePolicy resolutions >>>> Silicon/Marvell: add VariablePolicy resolutions >>>> Platform/BeagleBoard: add VariablePolicy resolutions >>>> Silicon/NXP: add VariablePolicy resolutions >>>> Platform/SocioNext: add VariablePolicy resolutions >>>> Silicon/Hisilicon: add VariablePolicy resolutions >>>> >>>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + >>>> Silicon/Hisilicon/Hisilicon.dsc.inc | 4 ++++ >>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 5 ++++- >>>> Silicon/NXP/NxpQoriqLs.dsc.inc | 4 ++++ >>>> .../AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++++ >>>> .../BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++++ >>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 ++++ >>>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 +++ >>>> .../FreedomU500VC707Board/U500.dsc | 4 ++++ >>>> .../FreedomU540HiFiveUnleashedBoard/U540.dsc | 4 ++++ >>>> .../Socionext/DeveloperBox/DeveloperBox.dsc | 3 +++ >>>> .../Overdrive1000Board/Overdrive1000Board.dsc | 4 ++++ >>>> .../Library/ResetSystemLib/ResetSystemLib.c | 2 +- >>>> .../Styx/Drivers/PlatInitPei/PlatInitPei.c | 11 ++++++---- >>>> .../Library/MemoryInitPei/MemoryInitPeiLib.c | 20 +++++++++++-------- >>>> .../Omap35xxPkg/SmbusDxe/Smbus.c | 2 +- >>>> 16 files changed, 64 insertions(+), 15 deletions(-) >>>> >>>> -- >>>> 2.20.1 >>>> >>> . >>> > . >