From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, edk2-devel@lists.01.org
Subject: Re: [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments.
Date: Fri, 1 Mar 2019 16:32:23 +0100 [thread overview]
Message-ID: <233d9d08-4d23-8442-829b-b184012bdb1f@redhat.com> (raw)
In-Reply-To: <20190301053957.3572-5-eric.dong@intel.com>
On 03/01/19 06:39, Eric Dong wrote:
> Cc: Ray Ni <Ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> index 3e8e899766..a78ef44491 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> @@ -1174,8 +1174,8 @@ PreSmmCpuRegisterTableWrite (
> @param[in] CpuBitMaskSize The size of CPU feature bit mask buffer
> @param[in] Feature The bit number of the CPU feature
>
> - @retval TRUE The CPU feature is set in PcdCpuFeaturesSupport.
> - @retval FALSE The CPU feature is not set in PcdCpuFeaturesSupport.
> + @retval TRUE The CPU feature is set in CpuBitMask.
> + @retval FALSE The CPU feature is not set in CpuBitMask.
>
> **/
> BOOLEAN
>
Okay, this patch is simple enough, and I vaguely remember that I
suggested it.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
next prev parent reply other threads:[~2019-03-01 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 5:39 [Patch v2 0/4] Simplify CPU Features solution Eric Dong
2019-03-01 5:39 ` [Patch v2 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions Eric Dong
2019-04-02 7:07 ` Ni, Ray
2019-03-01 5:39 ` [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration Eric Dong
2019-03-05 9:55 ` Zeng, Star
2019-03-05 9:56 ` Zeng, Star
2019-03-07 2:48 ` Dong, Eric
2019-04-02 7:15 ` Ni, Ray
2019-03-01 5:39 ` [Patch v2 3/4] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport Eric Dong
2019-04-02 7:22 ` Ni, Ray
2019-03-01 5:39 ` [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments Eric Dong
2019-03-01 15:32 ` Laszlo Ersek [this message]
2019-04-02 7:22 ` Ni, Ray
2019-03-01 15:30 ` [Patch v2 0/4] Simplify CPU Features solution Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=233d9d08-4d23-8442-829b-b184012bdb1f@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox