Re: [edk2-devel] [PATCH v2 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support

["PierreGondois" <pierre.gondois@arm.com>]

Hi Sami,

I have a minor comment to:
- [PATCH v2 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5

Otherwise for the other patches:
Reviewed-by: Pierre Gondois  <pierre.gondois@arm.com>

Regards,
Pierre

On 9/13/23 14:49, Sami Mujawar wrote:
> This patch series provides the following updates:
> - The patches 1 & 2 add the new fields introduced
>    in MADT (APIC table) by ACPI 6.5 and the patch
>    7/11 updates the Acpiview MADT parser accordingly.
> - The patches 3, 4 & 5 adds TRBE support to the MADT
>    table generator in DynamicTablesPkg.
> - Patch 6/11 updates the FADT ACPI revision to 6.5.
> - The patches 8, 9 & 10 add support to generate ETE
>    device nodes.
> - The last patch series fixes a bug wherein the CPC
>    token was incorrectly referenced.
> 
> Updates from v1 patch series:
>    - Fixed issue with setting TRBE interrupt in patch 5/11.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v2
> 
> Sami Mujawar (11):
>    MdePkg: MADT: Add Online capable flag in GICC
>    MdePkg: MADT: Add TRBE interrupt to GICC
>    DynamicTablesPkg: Add TRBE interrupt to GICC object
>    DynamicTablesPkg: Add TRBE interrupt to GICC object parser
>    DynamicTablesPkg: Update MADT generator for ACPI 6.5
>    DynamicTablesPkg: Update FADT generator to ACPI 6.5
>    ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
>    DynamicTablesPkg: Add an ET info object to Arm namespace
>    DynamicTablesPkg: Add an ET info object parser
>    DynamicTablesPkg: Add ETE device to CPU node in AML
>    DynamicTablesPkg: Fix referencing of CPC token
> 
>   DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                         |  32 +++-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                       | 108 +++++------
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                       |  83 +++++----
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h |  11 +-
>   DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c      |  11 +-
>   MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4 +-
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c                 |  48 ++++-
>   8 files changed, 386 insertions(+), 99 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108982): https://edk2.groups.io/g/devel/message/108982
Mute This Topic: https://groups.io/mt/101335843/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-