From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3F7FAD802AC for ; Fri, 22 Sep 2023 08:52:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wuWmMeUXCa4DPqS+HrDLpvASJzqGlhcqmVkDfFDQuNA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695372747; v=1; b=UJmfJX7uePy1w70/UYsf+++t1IkGU9r1xd16J4I/33gF60n+YuEZlpfR04iz8+KwV1Daxvlp RsDq6B5BwBx2xhatYa7f5jHFczq2sOr3bzBizruHFBE3ZOugTBHGRj84mAA/FQOnxhcSNCvkn49 2s+hSjrzn6roGb1ogJrAuYEQ= X-Received: by 127.0.0.2 with SMTP id kDcbYY7687511xaYNEPvpZMC; Fri, 22 Sep 2023 01:52:27 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.16866.1695372747010314075 for ; Fri, 22 Sep 2023 01:52:27 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38B80DA7; Fri, 22 Sep 2023 01:53:03 -0700 (PDT) X-Received: from [10.34.100.121] (e126645.nice.arm.com [10.34.100.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 44B6E3F5A1; Fri, 22 Sep 2023 01:52:24 -0700 (PDT) Message-ID: <235b9086-2729-1827-52ee-619d36fa37b3@arm.com> Date: Fri, 22 Sep 2023 10:52:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support To: Sami Mujawar , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, zhichao.gao@intel.com, Anshuman.Khandual@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Sibel.Allinson@arm.com, jeshuas@nvidia.com, nd@arm.com References: <20230913124935.38768-1-sami.mujawar@arm.com> From: "PierreGondois" In-Reply-To: <20230913124935.38768-1-sami.mujawar@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zXTOAsABlnHduOfJZM0sVcIjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UJmfJX7u; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) Hi Sami, I have a minor comment to: - [PATCH v2 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5 Otherwise for the other patches: Reviewed-by: Pierre Gondois Regards, Pierre On 9/13/23 14:49, Sami Mujawar wrote: > This patch series provides the following updates: > - The patches 1 & 2 add the new fields introduced > in MADT (APIC table) by ACPI 6.5 and the patch > 7/11 updates the Acpiview MADT parser accordingly. > - The patches 3, 4 & 5 adds TRBE support to the MADT > table generator in DynamicTablesPkg. > - Patch 6/11 updates the FADT ACPI revision to 6.5. > - The patches 8, 9 & 10 add support to generate ETE > device nodes. > - The last patch series fixes a bug wherein the CPC > token was incorrectly referenced. >=20 > Updates from v1 patch series: > - Fixed issue with setting TRBE interrupt in patch 5/11. >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v2 >=20 > Sami Mujawar (11): > MdePkg: MADT: Add Online capable flag in GICC > MdePkg: MADT: Add TRBE interrupt to GICC > DynamicTablesPkg: Add TRBE interrupt to GICC object > DynamicTablesPkg: Add TRBE interrupt to GICC object parser > DynamicTablesPkg: Update MADT generator for ACPI 6.5 > DynamicTablesPkg: Update FADT generator to ACPI 6.5 > ShellPkg: Acpiview: Update MADT parser for TRBE interrupt > DynamicTablesPkg: Add an ET info object to Arm namespace > DynamicTablesPkg: Add an ET info object parser > DynamicTablesPkg: Add ETE device to CPU node in AML > DynamicTablesPkg: Fix referencing of CPC token >=20 > DynamicTablesPkg/Include/ArmNameSpaceObjects.h = | 32 +++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c = | 108 +++++------ > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c = | 83 +++++---- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopo= logyGenerator.c | 188 +++++++++++++++++++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopo= logyGenerator.h | 11 +- > DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObje= ctParser.c | 11 +- > MdePkg/Include/IndustryStandard/Acpi65.h = | 4 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c = | 48 ++++- > 8 files changed, 386 insertions(+), 99 deletions(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108982): https://edk2.groups.io/g/devel/message/108982 Mute This Topic: https://groups.io/mt/101335843/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-