From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.3769.1635917822859919317 for ; Tue, 02 Nov 2021 22:37:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=dIyhgEKw; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=09410b13be=daniel.schaefer@hpe.com) Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1A2MVeu3019309; Wed, 3 Nov 2021 05:37:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=tKzbblxMuQVXhnRMoQt3ua1MG0NJ+R3ErmWpayk4/xo=; b=dIyhgEKwnmJOyWO7DMRastQLw9zvqO34jJvt6jNub3KU/dKHggLnKuvrcZkcXpcwos7n BFa3TmDMBSCIpKXVQf0EmddMUUIqzpjmpGN5/vXfUKR2F8Ea3CYXmWjEgTo+rMdFv359 IYqCIdqvHnc/Ru/zWdOcRFNGauCLFLibrsy7FjD9Ma7kWwJe4B3uDAmyP8Ca0YTweVut jxfESddJnyAO7s9sI0Xh9DECT6KdmgepB0Kl2uO2wPIh7T6/uGyiNxVjYqYPxdXtBs9h m8Kc1vefSOVTdjF1EJFdYPiGUe7k9qOLtm5TOX4MfApgtBCJp/kLrRVZt/4bSxwRUorn rw== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0a-002e3701.pphosted.com with ESMTP id 3c3e71aac4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Nov 2021 05:37:01 +0000 Received: from G9W8455.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 6B09A4F; Wed, 3 Nov 2021 05:37:00 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Wed, 3 Nov 2021 05:37:00 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.12) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Wed, 3 Nov 2021 05:37:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WgcVDaP4Es9FAb5jvlWGUAlSy8ft5BTZ4E3ls8ofUrBmaNdU19pJkcSS6+tdZEwHWPOHu4HNtW7Ch1hSoh8/CHZnkA191yRPEuB3kWliJrNXAWspqGq3MKSnv37t97gpKPe0XHJzBtR/ggqMDlMFAEN5Av7E3pxx5FzuyYwohjPV06iYSOsGGdWM1ZQaIYNqZ2Ctv+6Qcg3dljJ4C59poVOjn6gmawDwGhI6TwcnhEXKW/XCfDiqnNW8svEMjqEl82TcZ0awTi5Ro/VkxupdDfVASvl3URdt7x0oMJEfVw7d0Zk2ySbi06pn+S/1TlAxlnNcLr17/uZVnf4j5+IBZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tKzbblxMuQVXhnRMoQt3ua1MG0NJ+R3ErmWpayk4/xo=; b=Tz5706PI6OWV11cDGonlKTRNWMmDc7szclXWjmZOph89fwNeovZqgbqA0MAwsSwVpU/8r/miXU4C1ZSHTQlwhFKdZPC0kp2/cUw1hgNZywJ7VGatzXy0ldW8Ytzal4a+qNMCyaZjb73HjUpRGvXYaNbwvScFaeEWcUjV+UFMafHHOV9gaqXsdzh4eqpYHerex7LXI7ZilJjDRkZJm3xtuTgREUcjnsrQmE2mbzMldPDf9Tkld7JPUy+R/8iXL2mhX9HThN8yGSQ71WsO14oI8DO6aHPEUA3sw2E1Dkm4huyzTdvVtraist5946wnOo5bZlfp4mMOt5S5c9akXMUy0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) by DF4PR8401MB0603.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.18; Wed, 3 Nov 2021 05:36:59 +0000 Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f16b:a443:db34:2774]) by DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f16b:a443:db34:2774%11]) with mapi id 15.20.4649.020; Wed, 3 Nov 2021 05:36:59 +0000 Message-ID: <236166f4-27be-5f5f-baa5-d424ce37ecfd@hpe.com> Date: Wed, 3 Nov 2021 13:36:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64 To: Michael D Kinney , CC: Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ard Biesheuvel , Abner Chang References: <20211103030542.1529-1-michael.d.kinney@intel.com> <20211103030542.1529-3-michael.d.kinney@intel.com> From: "Daniel Schaefer" In-Reply-To: <20211103030542.1529-3-michael.d.kinney@intel.com> X-ClientProxiedBy: SN4PR0801CA0023.namprd08.prod.outlook.com (2603:10b6:803:29::33) To DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) Received: from [192.168.100.243] (123.193.58.60) by SN4PR0801CA0023.namprd08.prod.outlook.com (2603:10b6:803:29::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 05:36:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 724d4b8c-df6d-431e-3f0c-08d99e8bf45a X-MS-TrafficTypeDiagnostic: DF4PR8401MB0603: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YyB4n/ms8zGAIHOjY0HZsscLYbx0ZPS4F9Bz5d/XyB2dLErvap0sGgdIERQ3CesS7aS0vhrDgPGB7r0sH9cfJeVu6Rzlnm9IzXD6w/14rAmDYbuPg97zn1wWWgT7r67qQ3YD8pn1r4070NCoByut90KvWUiIQ/QYmwlSk/kXRBy12yjdeZjr+9ZHLdm0dv6+60HxXGyVArkJleA+jMRDO/XVHuXv6nx7UMEPwBOGbG2gsf22ycnTKxwd27JGXdlcuxa/mj/ogNuLR++SSaRO9IoYH18cDcnypxLtF+aF2uex0WkjgAdlGHTwYQVZNMTsB3MAQvxfQ8dpGT0uJi/wqBIR4PqJzhWdpar4BQ/hsDAXfnAw2bP7KG3zpUJS0eslXyZrqUzmbIqaeHKwc14m+jhuAxQGAxLr1Ohr2UllOHFiTKhS1Rs5qPaW7UEjgkh2zpTJFc2vKqy1yCujrLl3DF7v6bcDDWZ3Ixbn3u936y6pghyckBH7Jyp/rEABL2bNXjwyf7BgSsOBe+cnUcJ/FdXzADVahJ8B3oOECHmA7F/1IDU7rKo6yO1tEIHFJzvwV+2UakN6AuoOVQnmHjYJxXGUTerylEd3qzQwZsoIpk9l4dDLsRuY1icz4C4Y3dT1PNMLHZQDCtul8r+/JiaxBAnFPLxSbqjQKlnxV/yoQr5TZ50WrAjcOuHpb/9K5G1SsBP+gUp9UwGnDzlpkdQy5xbXfwUoYyRyeDN3z944dZWqz7IunKcga/d+1zq3XzkRryR7j61sKcL/f8O6+aXVKoBQDztIrNppcevtEU4cqzwPtNqTUSb89Mkt5bhqsgP4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(5660300002)(54906003)(4326008)(8676002)(53546011)(31696002)(508600001)(86362001)(316002)(16576012)(38100700002)(66556008)(66476007)(82960400001)(966005)(2906002)(31686004)(6486002)(2616005)(44832011)(956004)(36756003)(6666004)(186003)(8936002)(26005)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K00wU0x3Mnh0VFV2RUI1djJ4Y3pWb3NkUDExZzRDWjlScmcxQmVlSEtlSWtP?= =?utf-8?B?NlhBSXBoRGZYQTEzVi9DUEZCQkYvelArZ2tML2sxYWp4Z1RtVWVXR0FiNkpz?= =?utf-8?B?TmVOYXpqb0RERGFua3A4R214cGFncE1lTXp3aGUyVEZ0dFFDaDRSOVFpcnc3?= =?utf-8?B?eXJHYUdwMi9yd2crQ3dMV2NWZkJpb2d5bktuNWEyK041b2pURUNvWEJzZmFy?= =?utf-8?B?K1lIV0JSdmtYQmswQlZ5UUdySU5sTTdTaUVzSnJQalc5L1d5S0s1QU5VcUVJ?= =?utf-8?B?b0V1SU5IeTVPNTBFRGxQR2Y3b1FwN2FXNzlMSlhBa2U0Mk02VHV0OGdWRWtB?= =?utf-8?B?djI5R21keDRJakZ1YzFMTStnaFhML3ZVYlpyamMrTko2V0FMS3l4NG5QaEVX?= =?utf-8?B?L0JUdmdIbTB4S3hzd0NVdHhJdDJhYWNBNWJQOUU2YVZvOWc2dlVmQTJ3U0tL?= =?utf-8?B?ZFllTzhMRDBQa1RzRFZabFVhZHoya1VYVGl3RnRncTVKRUR2VldHWkYyVC9E?= =?utf-8?B?WkQvRW1ndkN2UUJEdi9iRFBaNXZvNXFQVUNFY044T2lmaWdvK01PT3BjcE05?= =?utf-8?B?RzBQRDVKZjJtVWNxM0RERjNraXRqY0RjMGJLUmF3dEVZRC9VNVljK3FTYWlN?= =?utf-8?B?Q0FHVWdwYTlRMDFIT3F1MFlydHVtcC9sU0xlREozNE1Zc29OUUxZQVBsbUt4?= =?utf-8?B?UDlyMzlqVlF1d3V5b0Y4ZGd3T1NVNWhHcllmRGJSMXo3Qzl1Q0NHY0xYREFw?= =?utf-8?B?am5HMzNueXhOQUhUcVJRbGtjdkxDOGYwT1pNQmNFUEpBWXcyTHNTNHV4YnRV?= =?utf-8?B?NVczRWIyMi9yYzdNQmhRdWozcEExZjFYa0gxb2wzdzl2cEZYbEtHMGxhdFd0?= =?utf-8?B?MU5KeGFSSG5rWWhCYTgyMURVVXZCdXMxUHRzSUNSQi8wclFLTnhJTGg1bkFp?= =?utf-8?B?WU1rTWlad0l2VVBqQjk4WDRuRUJSZjJUQVdsN0h3a3dNa1NDU2tNbmtpNE9q?= =?utf-8?B?SGszZ2swUmFjU2NLVDNPeXhHZUhVY2Q5U2pyVnE2S0RybjlRTitVd1ZVS1d4?= =?utf-8?B?cENWdWo3UUtYeUpHVzVRYkhvNUp1Mm4vSWNSdE1HalBobWo3WGNZbkR3NHlr?= =?utf-8?B?VXBiemYzclB2OGs1U2RKcnhpZFg3dzVWZDZIcW1qc1lhclJsOE8vcmNTMG5n?= =?utf-8?B?MlpLQ1Ryem5naGlCcEsvSldoV2p4QjlzU2d6MDNJVEZHNmVSL1FKb0k2SEJE?= =?utf-8?B?SDlrdVBoU1pkWWZiTmd5dkdpTTgrUlhFSW0rMFNoQ1BqVzR1OXZKVjlGV3JK?= =?utf-8?B?OWxmdDdKdlkyNFlTMEZMbmNlUStLR0o3TzdydXpUT3RzTFJoR2UwbGNhOEVR?= =?utf-8?B?Z2xtUUlrUDFaU2hDbnI4eWp1R2Z0UlNpVVRIdkhoOHNuWkRDMlJqcVBZZEdN?= =?utf-8?B?UUdGSUdXSVp4OFFtRzZJN1BzNEVLTElPT3lEY1kzM2JCc1VrS1hlNCtZa1kv?= =?utf-8?B?L3FuWUhrU2RFU0JxNmZ5c3B1K0tmRXRJRmw2VFV1bldiK1IzejkxWm00VVBk?= =?utf-8?B?dVBNbE0vRitBcjVmNldMSzZXSkoyREVZR2JoTTRzQXRWcXJWeERQZnJTOFU5?= =?utf-8?B?VkhKM04xL29haHhoV21tNVVpWURRenREYWNGbW16SGZUVzI4ZHhJWCtIczJ0?= =?utf-8?B?QzBFZ2Fpb0t6UmMwdWtOcWJiTENzS0JQZFcxcG5jNUtpZStYTGJaUmpkcDdI?= =?utf-8?B?aXFtTnZqaHU5Vnl2YXFscFlmZjNxRjlQUlRxTTdiUHdYYkpVbncyN1Vib2hM?= =?utf-8?B?NHM2N2U3Wm8yREJZdjVySVpCcWJLc1duMzlTVFpNTVZ5YTRtaHBHaUd4d2lt?= =?utf-8?B?c2crL0FTb09SYTRPVFVTc2NiYlpGQlAyaWFFdi9MbzgxeFNUanlFdks3ZWJZ?= =?utf-8?B?K3A1eUE1c2hheEpWd2Y4OHVKNE1qT2FSazY1MmxnUTNHTm9CbmVLc1ZJeUhF?= =?utf-8?B?dEVqTWxnNFBTQSs0L1R4U2tLNXRmRy9wdzAyUGtVWXNqYWZObUZVR3o3VEU1?= =?utf-8?B?MUt3bm5kbDNJcm9oRlpZZGh2TkhubkxFbXdDdWttcjA3Y1R6K1p2MGpTQWxv?= =?utf-8?B?ZUlqRmJkMVNJQWpIV0JXK293d2Y4Q1hGQm5mUytrSTJvZm5nWjZGNVdiMEFB?= =?utf-8?Q?vzPbj9MkVJdmhhsUH+Z5m+U=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 724d4b8c-df6d-431e-3f0c-08d99e8bf45a X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 05:36:58.8632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ypLto/mWZmWz46sbHr/tYWh2in0alRWFSKZArPgnWQ0tuW+9X6T7K3tG6BSno3tMURSiBJigdjeEn+soi6fB9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0603 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: SxKqAA50tNghkbzKCe0a6qPiKoSK-kww X-Proofpoint-GUID: SxKqAA50tNghkbzKCe0a6qPiKoSK-kww X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-03_01,2021-11-02_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111030033 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Perfect, thanks. I think BaseRngLib has an implementation for ARM or perhaps only AARCH64. I'm working one for RISCV64: https://bugzilla.tianocore.org/show_bug.cgi?id=3676 But until then this is good. Reviewed-by: Daniel Schaefer On 11/3/21 11:05, Michael D Kinney wrote: > Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib > mapping. > > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Signed-off-by: Michael D Kinney > --- > NetworkPkg/NetworkPkg.dsc | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc > index cf2164aefe25..8691a0f5d07a 100644 > --- a/NetworkPkg/NetworkPkg.dsc > +++ b/NetworkPkg/NetworkPkg.dsc > @@ -79,6 +79,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64] > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > +[LibraryClasses.ARM] > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > + > +[LibraryClasses.RISCV64] > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > + > [PcdsFeatureFlag] > gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE >