[edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo

[edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo

[Rebecca Cran]

Some improvements to the edk2-test repository.

Since buildzip.sh creates output that appears more useful for running on
the target machine, I wonder if we might want to mention it in the
documentation someplace?

Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty
outdated. Should we delete it?

Finally, is the TianoCore Contribution Agreement still relevant? I know
it is for the edk2 docs repositories, but not sure if edk2-test should
be updated to match the other code repos like edk2 and edk2-platforms?

CHANGES FROM v1 to v2:

Converted tabs to spaces in the echo line added to buildzip.sh

Rebecca Cran (4):
  Unbreak buildzip.sh
  Rename files in HowToBuild to avoid spaces in filenames
  Point users to the URL for edk2-test-parser if it doesn't exist
  Fix the URL for the edk2-test repo

 Maintainers.txt                                                                              | 2 +-
 uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
 uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
 uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
 uefi-sct/SctPkg/buildzip.sh                                                                  | 4 +---
 5 files changed, 2 insertions(+), 4 deletions(-)
 rename uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} (100%)
 rename uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt} (100%)
 rename uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt} (100%)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111058): https://edk2.groups.io/g/devel/message/111058
Mute This Topic: https://groups.io/mt/102513312/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-test v2 1/4] Unbreak buildzip.sh

[Rebecca Cran]

Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless
WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will
error out.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/SctPkg/buildzip.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg/buildzip.sh
index 625475701f12..c7f4673f62b2 100755
--- a/uefi-sct/SctPkg/buildzip.sh
+++ b/uefi-sct/SctPkg/buildzip.sh
@@ -32,9 +32,6 @@ esac
 # clear all positional parameters
 set --
 
-source ./edk2/edksetup.sh
-
-
 NUM_CPUS=$((`getconf _NPROCESSORS_ONLN` + 2))
 
 make -j"$NUM_CPUS" -C edk2/BaseTools/
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111059): https://edk2.groups.io/g/devel/message/111059
Mute This Topic: https://groups.io/mt/102513313/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

[Rebecca Cran]

Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
 uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
 uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
 3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/uefi-sct/HowToBuild/How to accelerate SCT execution.txt b/uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to accelerate SCT execution.txt
rename to uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT.txt b/uefi-sct/HowToBuild/HowToBuildSct.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT.txt
rename to uefi-sct/HowToBuild/HowToBuildSct.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT in UDK2017.txt b/uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT in UDK2017.txt
rename to uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111060): https://edk2.groups.io/g/devel/message/111060
Mute This Topic: https://groups.io/mt/102513314/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-test v2 3/4] Point users to the URL for edk2-test-parser if it doesn't exist

[Rebecca Cran]

If edk2-test-parser doesn't exist, tell the user where they can clone it
from.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/SctPkg/buildzip.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg/buildzip.sh
index c7f4673f62b2..639d5152c9d2 100755
--- a/uefi-sct/SctPkg/buildzip.sh
+++ b/uefi-sct/SctPkg/buildzip.sh
@@ -54,6 +54,7 @@ cp Build/MdeModule/RELEASE_GCC5/${TARGET_ARCH}/CapsuleApp.efi ${TARGET_ARCH}_SCT
 if [ ! -d "${pwd}edk2-test-parser" ]
 then
         echo "edk2-test-parser repo is missing from current directory, please clone and try again"
+        echo "The URL for edk2-test-parser is https://git.gitlab.arm.com/systemready/edk2-test-parser.git"
         exit
 fi
 
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111061): https://edk2.groups.io/g/devel/message/111061
Mute This Topic: https://groups.io/mt/102513315/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo

[Rebecca Cran]

Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
the repo.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 Maintainers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index a94255f015ad..ae6dd7008bcd 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -28,7 +28,7 @@ Descriptions of section entries:
 
 UEFI-SCT
 ------
-T: git - https://github.com/tianocore/edk2-test/uefi-sct
+T: git - https://github.com/tianocore/edk2-test
 
 
 Responsible Disclosure, Reporting Security Issues
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111062): https://edk2.groups.io/g/devel/message/111062
Mute This Topic: https://groups.io/mt/102513318/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo

[Laszlo Ersek]

On 11/10/23 20:08, Rebecca Cran wrote:
> Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
> the repo.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> ---
>  Maintainers.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index a94255f015ad..ae6dd7008bcd 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -28,7 +28,7 @@ Descriptions of section entries:
>  
>  UEFI-SCT
>  ------
> -T: git - https://github.com/tianocore/edk2-test/uefi-sct
> +T: git - https://github.com/tianocore/edk2-test
>  
>  
>  Responsible Disclosure, Reporting Security Issues

Reviewed-by: Laszlo Ersek <lersek@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111156): https://edk2.groups.io/g/devel/message/111156
Mute This Topic: https://groups.io/mt/102513318/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi Rebecca,
Thank you for these updates.
Just a matter of style, but can we do HowToBuild *SCT*.txt instead of HowToBuild *Sct*.txt?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111838): https://edk2.groups.io/g/devel/message/111838
Mute This Topic: https://groups.io/mt/102513314/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1067 bytes --]

Re: [edk2-devel] [PATCH edk2-test v2 3/4] Point users to the URL for edk2-test-parser if it doesn't exist

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Thank you for the update.
Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111839): https://edk2.groups.io/g/devel/message/111839
Mute This Topic: https://groups.io/mt/102513315/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 873 bytes --]

Re: [edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111840): https://edk2.groups.io/g/devel/message/111840
Mute This Topic: https://groups.io/mt/102513318/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 842 bytes --]

Re: [edk2-devel] [PATCH edk2-test v2 1/4] Unbreak buildzip.sh

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>
Thank you for the update.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112175): https://edk2.groups.io/g/devel/message/112175
Mute This Topic: https://groups.io/mt/102513313/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 873 bytes --]

Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

In keeping the consistency with existing file names, I think the names that you suggested is okay.
Thank you again.

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112185): https://edk2.groups.io/g/devel/message/112185
Mute This Topic: https://groups.io/mt/102513314/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 974 bytes --]

Re: [edk2-devel] [PATCH edk2-test v2 1/4] Unbreak buildzip.sh

[Sunny Wang]

Looks good to me.

The commit message looks a little confusing to me in the beginning because one of purposes to run the edksetup.sh is to correctly configure both WORKSPACE and PACKAGES_PATH.
However, since buildzip.sh can be independently run, it seems better to remove the line of sourcing edksetup.

Reviewed-by: Sunny Wang <sunny.wang@arm.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
Sent: Friday, November 10, 2023 7:08 PM
To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-devel] [PATCH edk2-test v2 1/4] Unbreak buildzip.sh

Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless
WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will
error out.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/SctPkg/buildzip.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg/buildzip.sh
index 625475701f12..c7f4673f62b2 100755
--- a/uefi-sct/SctPkg/buildzip.sh
+++ b/uefi-sct/SctPkg/buildzip.sh
@@ -32,9 +32,6 @@ esac
 # clear all positional parameters
 set --

-source ./edk2/edksetup.sh
-
-
 NUM_CPUS=$((`getconf _NPROCESSORS_ONLN` + 2))

 make -j"$NUM_CPUS" -C edk2/BaseTools/
--
2.34.1






IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112291): https://edk2.groups.io/g/devel/message/112291
Mute This Topic: https://groups.io/mt/102513313/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

[Sunny Wang]

Looks good to me.
Better to add https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C#user-content-CamelCase in commit message for reference.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
Sent: Friday, November 10, 2023 7:08 PM
To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
 uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
 uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
 3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/uefi-sct/HowToBuild/How to accelerate SCT execution.txt b/uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to accelerate SCT execution.txt
rename to uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT.txt b/uefi-sct/HowToBuild/HowToBuildSct.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT.txt
rename to uefi-sct/HowToBuild/HowToBuildSct.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT in UDK2017.txt b/uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT in UDK2017.txt
rename to uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
--
2.34.1






IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112292): https://edk2.groups.io/g/devel/message/112292
Mute This Topic: https://groups.io/mt/102513314/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo

[Sunny Wang]

Good catch. Looks good to me. Thanks, Rebecca!
Reviewed-by: Sunny Wang <sunny.wang@arm.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
Sent: Friday, November 10, 2023 7:08 PM
To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-devel] [PATCH edk2-test v2 4/4] Fix the URL for the edk2-test repo

Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
the repo.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 Maintainers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index a94255f015ad..ae6dd7008bcd 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -28,7 +28,7 @@ Descriptions of section entries:

 UEFI-SCT
 ------
-T: git - https://github.com/tianocore/edk2-test/uefi-sct
+T: git - https://github.com/tianocore/edk2-test


 Responsible Disclosure, Reporting Security Issues
--
2.34.1






IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112294): https://edk2.groups.io/g/devel/message/112294
Mute This Topic: https://groups.io/mt/102513318/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

[Rebecca Cran]

On 11/29/2023 1:06 AM, G Edhaya Chandran wrote:
> Hi Rebecca,
> Thank you for these updates.
> Just a matter of style, but can we do HowToBuild*SCT*.txt instead of 
> HowToBuild*Sct*.txt? 

Sure! I can make that change just before I push the series.


-- 

Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112315): https://edk2.groups.io/g/devel/message/112315
Mute This Topic: https://groups.io/mt/102513314/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild to avoid spaces in filenames

[G Edhaya Chandran]

Thank you, Rebecca.
However the other reviewers too felt that your naming convention was more apt.
So we will take it as it is. No need of any changes.

With Warm Regards,
Edhay


> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Monday, December 11, 2023 9:38 PM
> To: G Edhaya Chandran <Edhaya.Chandran@arm.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH edk2-test v2 2/4] Rename files in HowToBuild
> to avoid spaces in filenames
>
> On 11/29/2023 1:06 AM, G Edhaya Chandran wrote:
> > Hi Rebecca,
> > Thank you for these updates.
> > Just a matter of style, but can we do HowToBuild*SCT*.txt instead of
> > HowToBuild*Sct*.txt?
>
> Sure! I can make that change just before I push the series.
>
>
> --
>
> Rebecca Cran

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112318): https://edk2.groups.io/g/devel/message/112318
Mute This Topic: https://groups.io/mt/102513314/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo

[Rebecca Cran]

I don't appear to have permission to push to the edk2-test repo.
Could somebody merge my change please?

Thanks.
Rebecca

On 11/10/2023 12:08 PM, Rebecca Cran wrote:
> Some improvements to the edk2-test repository.
>
> Since buildzip.sh creates output that appears more useful for running on
> the target machine, I wonder if we might want to mention it in the
> documentation someplace?
>
> Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty
> outdated. Should we delete it?
>
> Finally, is the TianoCore Contribution Agreement still relevant? I know
> it is for the edk2 docs repositories, but not sure if edk2-test should
> be updated to match the other code repos like edk2 and edk2-platforms?
>
> CHANGES FROM v1 to v2:
>
> Converted tabs to spaces in the echo line added to buildzip.sh
>
> Rebecca Cran (4):
>    Unbreak buildzip.sh
>    Rename files in HowToBuild to avoid spaces in filenames
>    Point users to the URL for edk2-test-parser if it doesn't exist
>    Fix the URL for the edk2-test repo
>
>   Maintainers.txt                                                                              | 2 +-
>   uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
>   uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
>   uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
>   uefi-sct/SctPkg/buildzip.sh                                                                  | 4 +---
>   5 files changed, 2 insertions(+), 4 deletions(-)
>   rename uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} (100%)
>   rename uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt} (100%)
>   rename uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt} (100%)
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112322): https://edk2.groups.io/g/devel/message/112322
Mute This Topic: https://groups.io/mt/102513312/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo

[Rebecca Cran]

Could someone push these changes to the edk2-test repo please?

On 11/10/2023 12:08 PM, Rebecca Cran wrote:
> Some improvements to the edk2-test repository.
>
> Since buildzip.sh creates output that appears more useful for running on
> the target machine, I wonder if we might want to mention it in the
> documentation someplace?
>
> Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty
> outdated. Should we delete it?
>
> Finally, is the TianoCore Contribution Agreement still relevant? I know
> it is for the edk2 docs repositories, but not sure if edk2-test should
> be updated to match the other code repos like edk2 and edk2-platforms?
>
> CHANGES FROM v1 to v2:
>
> Converted tabs to spaces in the echo line added to buildzip.sh
>
> Rebecca Cran (4):
>    Unbreak buildzip.sh
>    Rename files in HowToBuild to avoid spaces in filenames
>    Point users to the URL for edk2-test-parser if it doesn't exist
>    Fix the URL for the edk2-test repo
>
>   Maintainers.txt                                                                              | 2 +-
>   uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
>   uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
>   uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
>   uefi-sct/SctPkg/buildzip.sh                                                                  | 4 +---
>   5 files changed, 2 insertions(+), 4 deletions(-)
>   rename uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} (100%)
>   rename uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt} (100%)
>   rename uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt} (100%)
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112607): https://edk2.groups.io/g/devel/message/112607
Mute This Topic: https://groups.io/mt/102513312/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-test v2 0/4] Various improvements to the repo

[G Edhaya Chandran]

Hi Rebecca,

   This patch series is upstreamed to https://github.com/tianocore/edk2-test/commits/master/

With Warm Regards,
Edhay



> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Saturday, December 16, 2023 2:56 AM
> To: devel@edk2.groups.io; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>;
> Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; Supreeth Venkatesh
> <Supreeth.Venkatesh@amd.com>
> Subject: Re: [PATCH edk2-test v2 0/4] Various improvements to the repo
>
> Could someone push these changes to the edk2-test repo please?
>
> On 11/10/2023 12:08 PM, Rebecca Cran wrote:
> > Some improvements to the edk2-test repository.
> >
> > Since buildzip.sh creates output that appears more useful for running
> > on the target machine, I wonder if we might want to mention it in the
> > documentation someplace?
> >
> > Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty
> > outdated. Should we delete it?
> >
> > Finally, is the TianoCore Contribution Agreement still relevant? I
> > know it is for the edk2 docs repositories, but not sure if edk2-test
> > should be updated to match the other code repos like edk2 and edk2-
> platforms?
> >
> > CHANGES FROM v1 to v2:
> >
> > Converted tabs to spaces in the echo line added to buildzip.sh
> >
> > Rebecca Cran (4):
> >    Unbreak buildzip.sh
> >    Rename files in HowToBuild to avoid spaces in filenames
> >    Point users to the URL for edk2-test-parser if it doesn't exist
> >    Fix the URL for the edk2-test repo
> >
> >   Maintainers.txt                                                                              | 2 +-
> >   uefi-sct/HowToBuild/{How to accelerate SCT execution.txt =>
> HowToAccelerateSctExecution.txt} | 0
> >   uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}
> | 0
> >   uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt =>
> HowToBuildSctInUdk2017.txt}          | 0
> >   uefi-sct/SctPkg/buildzip.sh                                                                  | 4 +---
> >   5 files changed, 2 insertions(+), 4 deletions(-)
> >   rename uefi-sct/HowToBuild/{How to accelerate SCT execution.txt =>
> HowToAccelerateSctExecution.txt} (100%)
> >   rename uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}
> (100%)
> >   rename uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt =>
> > HowToBuildSctInUdk2017.txt} (100%)
> >

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112608): https://edk2.groups.io/g/devel/message/112608
Mute This Topic: https://groups.io/mt/102513312/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-