From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 374F68044F for ; Mon, 20 Mar 2017 08:48:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 939926264B; Mon, 20 Mar 2017 15:48:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 939926264B Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 939926264B Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-55.phx2.redhat.com [10.3.116.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66477B2271; Mon, 20 Mar 2017 15:48:41 +0000 (UTC) To: "Yao, Jiewen" , edk2-devel-01 References: <20170320110953.10033-1-lersek@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C503A90747D@shsmsx102.ccr.corp.intel.com> Cc: Ard Biesheuvel , "Tian, Feng" , "Zeng, Star" From: Laszlo Ersek Message-ID: <2368b29b-c75f-885b-6c8d-58e6eb857b93@redhat.com> Date: Mon, 20 Mar 2017 16:48:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A90747D@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 20 Mar 2017 15:48:42 +0000 (UTC) Subject: Re: [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is 0" msg to DEBUG_WARN X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 15:48:42 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/20/17 16:09, Yao, Jiewen wrote: > I agree to downgrade the logging level. > > Can we add the comment, from log message to the comment in the C code? > Such as below: > ========================== > // > // UEFI executables that consist of a single read+write+exec PE/COFF section > // isn't actually an error. > // The image can be launched alright, only image protection cannot be applied > // to it fully. > // > // One example that elicits this is (some) Linux kernels (with the EFI > // stub of course). > // > ========================== > > With comment added, reviewed-by: Jiewen.yao@intel.com I updated the patch with the comment. Commit 38b15ebe4fd5. Thanks! Laszlo > > Thank you > Yao Jiewen > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Monday, March 20, 2017 7:10 PM >> To: edk2-devel-01 >> Cc: Ard Biesheuvel ; Tian, Feng >> ; Yao, Jiewen ; Zeng, Star >> >> Subject: [PATCH] MdeModulePkg/Core/Dxe: downgrade "CodeSegmentCount is >> 0" msg to DEBUG_WARN >> >> UEFI executables that consist of a single read+write+exec PE/COFF section >> trigger this message, but such a binary layout isn't actually an error. >> The image can be launched alright, only image protection cannot be applied >> to it fully. >> >> One example that elicits the message is (some) Linux kernels (with the EFI >> stub of course). >> >> Cc: Ard Biesheuvel >> Cc: Feng Tian >> Cc: Jiewen Yao >> Cc: Star Zeng >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c >> b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c >> index 7689c794a8ad..699c9a827720 100644 >> --- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c >> +++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c >> @@ -580,10 +580,10 @@ ProtectUefiImageCommon ( >> } >> >> if (ImageRecord->CodeSegmentCount == 0) { >> - DEBUG ((DEBUG_ERROR, "!!!!!!!! ProtectUefiImageCommon - >> CodeSegmentCount is 0 !!!!!!!!\n")); >> + DEBUG ((DEBUG_WARN, "!!!!!!!! ProtectUefiImageCommon - >> CodeSegmentCount is 0 !!!!!!!!\n")); >> PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN) >> ImageAddress); >> if (PdbPointer != NULL) { >> - DEBUG ((DEBUG_ERROR, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer)); >> + DEBUG ((DEBUG_WARN, "!!!!!!!! Image - %a !!!!!!!!\n", >> PdbPointer)); >> } >> goto Finish; >> } >> -- >> 2.9.3 >