Re: [PATCH 0/2] Add event signal before and after ReadyToBoot

[Laszlo Ersek <lersek@redhat.com>]

On 04/02/19 07:49, Zhichao Gao wrote:
> Add two event guids.
> And signal them immediately before and after the ReadyToBoot signal Event.
> 
> Bret Barkelew (2):
>   MdeModulePkg: Add event guids
>   MdeModulePkg/UefiBootManagerlib: Add two event signals
> 
>  .../Include/Guid/EventPostReadyToBoot.h       | 24 +++++++++++++++++++
>  .../Include/Guid/EventPreReadyToBoot.h        | 24 +++++++++++++++++++
>  .../Library/UefiBootManagerLib/BmBoot.c       |  2 ++
>  .../Library/UefiBootManagerLib/InternalBm.h   |  4 +++-
>  .../UefiBootManagerLib/UefiBootManagerLib.inf |  5 +++-
>  MdeModulePkg/MdeModulePkg.dec                 |  6 +++++
>  6 files changed, 63 insertions(+), 2 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Guid/EventPostReadyToBoot.h
>  create mode 100644 MdeModulePkg/Include/Guid/EventPreReadyToBoot.h
> 

(1) You forgot to include the CC's from the individual patches on the
cover letter. I'm fixing that now.


(2) This is my turn to ask whether the new event group GUIDs have been
standardized and released in a public spec.

If they haven't, I'll nack this series -- contributors should be held to
equal standards.

In particular, the variables are called "gEfiEventPostReadyToBootGuid"
and "gEfiEventPreReadyToBootGuid". The "Efi" infix suggests these are
standard event groups. However, in that case, I believe the changes
should go into "MdePkg/Include/Guid/EventGroup.h", and TianoCore#1676
should minimally indicate the Mantis ticket that introduces the GUIDs.

I've now searched "UEFI_Spec_2_8_final.pdf" (from the USWG member area,
SHA1 1adf5b81c566075574b3ad9e4091a42e9c9a80cb), and PI v1.7 too, for
"7b94c75c", and there are no hits.

In theory, it would be totally fine to introduce these event group GUIDs
as edk2 extensions. In theory. The last time I tried to do something
similar, I was forced to go through the spec process however.

No double standards, please. If UefiBootManagerLib & BdsDxe are now open
to edk2 extensions, and will no longer restrict themselves to specified
behavior, that's great, but I will want it in writing; the policy should
apply to everyone. (Adding Stephano.)

Thanks,
Laszlo