From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F4B82194D387 for ; Tue, 2 Apr 2019 01:40:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD61730FE5BD; Tue, 2 Apr 2019 08:40:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-182.rdu2.redhat.com [10.10.120.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 694A1611C8; Tue, 2 Apr 2019 08:40:55 +0000 (UTC) To: Zhichao Gao References: <20190402054905.19396-1-zhichao.gao@intel.com> From: Laszlo Ersek Cc: edk2-devel@lists.01.org, Bret Barkelew , Jian J Wang , Liming Gao , Michael Turner , Ray Ni , Sean Brogan , Star Zeng , Stephano Cetola Message-ID: <237921d8-1d5a-f467-a1c3-cfb1f9408e3b@redhat.com> Date: Tue, 2 Apr 2019 10:40:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190402054905.19396-1-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 02 Apr 2019 08:40:58 +0000 (UTC) Subject: Re: [PATCH 0/2] Add event signal before and after ReadyToBoot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 08:41:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/02/19 07:49, Zhichao Gao wrote: > Add two event guids. > And signal them immediately before and after the ReadyToBoot signal Event. > > Bret Barkelew (2): > MdeModulePkg: Add event guids > MdeModulePkg/UefiBootManagerlib: Add two event signals > > .../Include/Guid/EventPostReadyToBoot.h | 24 +++++++++++++++++++ > .../Include/Guid/EventPreReadyToBoot.h | 24 +++++++++++++++++++ > .../Library/UefiBootManagerLib/BmBoot.c | 2 ++ > .../Library/UefiBootManagerLib/InternalBm.h | 4 +++- > .../UefiBootManagerLib/UefiBootManagerLib.inf | 5 +++- > MdeModulePkg/MdeModulePkg.dec | 6 +++++ > 6 files changed, 63 insertions(+), 2 deletions(-) > create mode 100644 MdeModulePkg/Include/Guid/EventPostReadyToBoot.h > create mode 100644 MdeModulePkg/Include/Guid/EventPreReadyToBoot.h > (1) You forgot to include the CC's from the individual patches on the cover letter. I'm fixing that now. (2) This is my turn to ask whether the new event group GUIDs have been standardized and released in a public spec. If they haven't, I'll nack this series -- contributors should be held to equal standards. In particular, the variables are called "gEfiEventPostReadyToBootGuid" and "gEfiEventPreReadyToBootGuid". The "Efi" infix suggests these are standard event groups. However, in that case, I believe the changes should go into "MdePkg/Include/Guid/EventGroup.h", and TianoCore#1676 should minimally indicate the Mantis ticket that introduces the GUIDs. I've now searched "UEFI_Spec_2_8_final.pdf" (from the USWG member area, SHA1 1adf5b81c566075574b3ad9e4091a42e9c9a80cb), and PI v1.7 too, for "7b94c75c", and there are no hits. In theory, it would be totally fine to introduce these event group GUIDs as edk2 extensions. In theory. The last time I tried to do something similar, I was forced to go through the spec process however. No double standards, please. If UefiBootManagerLib & BdsDxe are now open to edk2 extensions, and will no longer restrict themselves to specified behavior, that's great, but I will want it in writing; the policy should apply to everyone. (Adding Stephano.) Thanks, Laszlo