public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, wasim.khan@nxp.com
Cc: michael.d.kinney@intel.com, liming.gao@intel.com, v.sethi@nxp.com
Subject: Re: [edk2-devel] [PATCH] MdePkg: Include Acpi hearder file
Date: Thu, 16 Apr 2020 18:53:47 +0200	[thread overview]
Message-ID: <237cee2d-d73e-9a32-571c-2462f2d0075e@redhat.com> (raw)
In-Reply-To: <1586950842-19391-1-git-send-email-wasim.khan@nxp.com>

On 04/15/20 13:40, Wasim Khan wrote:
> ACPI memory mapped configuration space access (MCFG) table requires
> defination of EFI_ACPI_DESCRIPTION_HEADER.
> 
> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> ---
>  .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h        | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
> index 3356ec9..8a4933d 100644
> --- a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
> +++ b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
> @@ -10,6 +10,8 @@
>  #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>  #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>  
> +#include <IndustryStandard/Acpi.h>
> +
>  //
>  // Ensure proper structure formats
>  //
> 

There's a typo in the subject: s/hearder/header/.

(I'll let the MdePkg maintainers review this patch beyond this
superficial comment.)

Thanks
Laszlo


      reply	other threads:[~2020-04-16 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 11:40 [PATCH] MdePkg: Include Acpi hearder file Wasim Khan
2020-04-16 16:53 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237cee2d-d73e-9a32-571c-2462f2d0075e@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox