Re: [PATCH v2 6/8] DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Michael,

Thank you for this fix.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 25/08/2022 04:48 am, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
> index 59001378c4e0..78fa63ff47e5 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
> @@ -436,7 +436,6 @@ IsGicCTokenEqual (
>         "the same GICC Info object. ACPI Processor IDs are not unique. " \
>         "GicCToken = %p.\n",
>         Index1,
> -      IndexedObject1->Token,
>         Index2,
>         ProcNode1->GicCToken
>         ));
> @@ -566,7 +565,7 @@ AddProcHierarchyNodes (
>           DEBUG ((
>             DEBUG_ERROR,
>             "ERROR: PPTT: Failed to get parent processor hierarchy node " \
> -          "reference. Token = %p, Status = %r\n",
> +          "reference. ParentToken = %p. ChildToken = %p. Status = %r\n",
>             ProcInfoNode->ParentToken,
>             ProcInfoNode->Token,
>             Status