From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.83]) by mx.groups.io with SMTP id smtpd.web12.10543.1662028988063751098 for ; Thu, 01 Sep 2022 03:43:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=8sHopTUA; spf=pass (domain: arm.com, ip: 40.107.2.83, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DcUrOpM+QA/BVxFuEKfJTBydRDlymKWn9wBugg6Bby4m5ZkdaVKebGo542t7NOPSNBfUwnCxBzUfdlWXnCAR7Bt5WasuEtXkP8chi8ATQF+M/aJPsLUWCcO+76guJAEPu0SknIbQMYDtpbEdvN09OJv2CANTHs3pqVBDUzPv87qBj5dKiJ9pZXjS/UK5Ct+xQwLf2DjFsx/nsB7n7GL5ZRB5HiTUn8918+Kra4QjyZcgjOoOTec3TKFwJr9Z16a37aL/J2FntH3rewCKisrR7JN+PVzVQH+n/jhZ4MpfJC6qSlHDVvRwk5NzOQBSS22wsVMU7krWVPqCWIDTylZGqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FAaPbbYdgpXVs98I84byVdG5JddK7CApum2AEDrXup8=; b=a25nEC+a98dMeB5a+0bim4DNdAjfFdWKRrzA4Nv7cevqZS7eWFDkZDuBkqiJP5mqkmKtwkliE0ZUynailLKZ2Umf7cyN9V8erKbqv6TgSOM9Cuk7W8qxFB1GFyLi0W0EnwzjFqvekbvVaIPT/4GUG7hB+0xFKuRKwCZSNz4MI0L2NPc/s49GKi3RruZUKMtbUzZ1UaeUCg9sbaWUshulz+g6BilJlNQnsgnZIeHUinYsKigWg5hmSyf+OdwFZ4MoZRG3YsYHBZku7Z9HEH7A6tUGQmvC7uPDgHzFx/OqtfiPIgoWbJS/JeICNCX7HiNMzJoS/hiUNSZzUVtg3RYnrw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAaPbbYdgpXVs98I84byVdG5JddK7CApum2AEDrXup8=; b=8sHopTUA5fYjR3NlNNMDJyqie9Yvdf9Qn/H16Doz3DYZB8zy2bEzSt7P0WJmG1Q3jDVh5Xg3oLFb9k54LimFq5EAa/XwxBHqrFq8aR2+adjEfn2VGZLMKEACeCZhvHXmQjpmX0QmmU+oLqbv+AV+Jx1XDOXoUXO705SakJTjn0U= Received: from DB6P18901CA0018.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::28) by DBBPR08MB6203.eurprd08.prod.outlook.com (2603:10a6:10:201::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 1 Sep 2022 10:43:03 +0000 Received: from DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::67) by DB6P18901CA0018.outlook.office365.com (2603:10a6:4:16::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 10:43:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT047.mail.protection.outlook.com (100.127.143.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 10:43:03 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 01 Sep 2022 10:43:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ad1163fd56c8a44e X-CR-MTA-TID: 64aa7808 Received: from dbc03f4a98a9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0C611C22-564D-4630-9E47-EFEE7296397B.1; Thu, 01 Sep 2022 10:42:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbc03f4a98a9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 10:42:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rdtr+japjVdtRORZltT05AnpIS96aUXXjH8rtvC1J4a6gQi2Du6r1X9Aoz+jh0VsXOf316U2/4HAAb4W1/il7UhwLOJtO4AMk1oMhZn1qUod+nKGwd20p10Kjw9BjtzXGVU1LJCPYCoed3O/uVQDVVrkJbldpSpJY+GmIQdPWwYxMguzqqN2eWZvWXPGRisNnO3Ugbrvf5JC/Q0ba0e2R6kGhpV68FIwTgZIL6qttdtLsBBbRGiYAT1Q+GVCSBqPN5OPCIrPfV0xCsorVw7VkMDegcVCLz+1QOeusX3aSq2rddg//BF+fSqASVoRIUi9VUJ3F+8J1pgs7Q7Jo5551Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FAaPbbYdgpXVs98I84byVdG5JddK7CApum2AEDrXup8=; b=VZCp/2GdB3/O80Cml49ECFoWcZ+3YBAFhSCejScp+3AfEZAXfBUf0REgK+yjp8B+EavjoqP5WZI971geyvZfw55H6tXNNQLl+Anu+hBCKHSCtjyNXF9k/3S5t9zsxHoBBs528rMNeTg3C3/5QydtNpkPDl7ntqg96Fn9dvEr2vWrMrzz04maWv58fTc/HMkcCMw9foBO2G4OQ4TuS29+h/ZaRY9YFn8exp1MtEwMzjvFXeOBTp0SboxbQ45ykIVPx94TBH8NCQH2gxxTUvCr5oREEeMz9hbesKcwSptsJz+9e148xsukrX7ATneo1nM0mUA1jFVMevh0ZxmkZVWcBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAaPbbYdgpXVs98I84byVdG5JddK7CApum2AEDrXup8=; b=8sHopTUA5fYjR3NlNNMDJyqie9Yvdf9Qn/H16Doz3DYZB8zy2bEzSt7P0WJmG1Q3jDVh5Xg3oLFb9k54LimFq5EAa/XwxBHqrFq8aR2+adjEfn2VGZLMKEACeCZhvHXmQjpmX0QmmU+oLqbv+AV+Jx1XDOXoUXO705SakJTjn0U= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PR3PR08MB5673.eurprd08.prod.outlook.com (2603:10a6:102:86::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 10:42:55 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%8]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 10:42:55 +0000 Message-ID: <238eb24d-6cdb-c575-2bcd-18f2901abbdd@arm.com> Date: Thu, 1 Sep 2022 11:42:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 6/8] DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20220825034824.4044-1-mikuback@linux.microsoft.com> <20220825034824.4044-7-mikuback@linux.microsoft.com> From: "Sami Mujawar" In-Reply-To: <20220825034824.4044-7-mikuback@linux.microsoft.com> X-ClientProxiedBy: LO4P123CA0666.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::17) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8a59a196-19dc-4eb3-2ad8-08da8c06bf62 X-MS-TrafficTypeDiagnostic: PR3PR08MB5673:EE_|DBAEUR03FT047:EE_|DBBPR08MB6203:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: l61cChiU3EchVinRSDJmKGC9XzsJjkec4sIoA+gRichM7Ae27G+hsP/NeV378EZ0+4StJ2vRSnn7qnhZ+sB5X5f4aoCVkyzXsMVsiL8Os8XLObe9xP/E/7dKwVAOmcbQai2NA1sG/PWo17ZhBjkFKnZoCbMhTqXNMHEnmpKlLW+g2vRnv+9Lu2vUVB/EYKZnUIQqXmDjwk/5odBlBYn+ANwWNmM5lw9QqtsXxRstAR0EHxRJY/xBmcepDpBhfp/lOdmjQqkLHYms9viu6zU5F//9pazVJZaGNekVPEbCosJIavLab3k2ws8waQpvOqyON6bvmqBZXprkW3i/VaxNFax7ZtRGkMjFyZHAZ1VD0il+qSawuuWosXT7K1VSiQFzd2zi5eWKeRZ3iQHQ24MqtoAojVxbFloD/WLzcKL5BSKfUz7xgZAuYqPTQZ3bsN5ZTbguEVdTcTJpcDQWavSEkv0FOyjYcqlMmAIvE53JdX1bQNHTo2igieMw4OUh00DIjQNhkFoyqHRSWGA/C1vMAWA1RHFS72xZcI0pk17VkDBCNbm+x+xXYtfhGrhPLI+WLfGbkObGFtwsde6G6Dll9VtwIW0EPNVVy+vFs2ByGid3f5vNoLp1F/gEla30WQDUom9ZaTosaknQvOUpnIy6FayCJYY+XyS6kr4X4TYRAOnTqedhwZfOiVfy2Z+Y0WNcNyQ8q5dB5FroZ1nbgS/2qmeTaTBz6M02wp9PlAgfQ3p/eSGHSYfSoC6qcxVAkGlmKVWNCQ9VWSHbEKB8uXZq0SLmclCRuf4nBCRcq53GUBA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(478600001)(2906002)(6506007)(6666004)(53546011)(66946007)(66476007)(66556008)(8676002)(4326008)(36756003)(41300700001)(54906003)(316002)(45080400002)(6486002)(2616005)(26005)(186003)(6512007)(83380400001)(31696002)(44832011)(31686004)(5660300002)(8936002)(38100700002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5673 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2ad1f5d0-b369-465a-35a7-08da8c06b994 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tj4E2ZFJInNTSpo8dWLJPQFaMlFc5d5RO4o8yBk3lYIs1vAPzI9kBRJgxFLzyHibIhwr0m118I6cb7nyaWbdEcK2nc8D/NxdyAYJjRGox07rf7fDevoz+EFRTn5/Y1bXqTPuVyl03TgA2RmEFm13lVm0P6KIum47dJQqxlYWtity8xBrao5q0gcv07OQGYUL+gDyfgeQYZAN8OONdr4UwBhn2ejClh6SLQ+rZyy2ZvcawVZRO5ASvG3+EqVY5KIEqgj5LkX7cVa89z9bMLtZzi9FJtu5s8JE2PMJFZaNKP8a3+41OcjD/kEKd+S+tEwhQJpkE6UrtlHkqBUO67hYH21ORZsS/yMqXOMiNXuy4glFt+NliRw61xyQ+FGYo5SNm/xj7u666JBxXbE1uY2w3Gq8UW/ngV8nH2pPRgCwsozPrQ5gRLrpyFIGJCN7TXRtlqBcTU3RxXw3EEilpDB95kF2yZwPogAwzW1NYll+HlNWv438hZ2xWk6qq1Hb80GJkI7AV8tPfU7x48zwP1iuS2PaeabSiTmwaAz01LEFFS74uRM6J5+E9w2kWkCVZvhxxTll0EpMnejXn8iTgEpNTwIIFnN6aVaGRe8B76e6C53j5yQnF6k7ugw2/3iL+DWwrrnFvIlYe+P2nR0iSKEd331mcVuFvO/+JP+bGW+e5xHuIz00xZAt+uxVzMziKNs8yypwErXRuuFjqhFokHP2H+zhl/pCu1ckFLCAFL6wKvA1ohM8WJTJe/7DaBsmhwgIxzzZ6vE6erpY/WmfXFrJvOCNZTS1Gra7tvbiiY31Udk1baIpggOTs8pRYzAqM6YS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(376002)(39860400002)(346002)(36840700001)(40470700004)(46966006)(8676002)(70206006)(6486002)(41300700001)(4326008)(40480700001)(478600001)(336012)(70586007)(2906002)(53546011)(36860700001)(40460700003)(83380400001)(6506007)(47076005)(26005)(6512007)(6666004)(5660300002)(8936002)(44832011)(31686004)(82740400003)(316002)(81166007)(82310400005)(86362001)(45080400002)(54906003)(2616005)(36756003)(356005)(31696002)(186003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 10:43:03.4764 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a59a196-19dc-4eb3-2ad8-08da8c06bf62 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6203 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michael, Thank you for this fix. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 25/08/2022 04:48 am, mikuback@linux.microsoft.com wrote: > From: Michael Kubacki > > Cc: Sami Mujawar > Cc: Alexei Fedorov > Signed-off-by: Michael Kubacki > --- > DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c > index 59001378c4e0..78fa63ff47e5 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c > @@ -436,7 +436,6 @@ IsGicCTokenEqual ( > "the same GICC Info object. ACPI Processor IDs are not unique. " \ > "GicCToken = %p.\n", > Index1, > - IndexedObject1->Token, > Index2, > ProcNode1->GicCToken > )); > @@ -566,7 +565,7 @@ AddProcHierarchyNodes ( > DEBUG (( > DEBUG_ERROR, > "ERROR: PPTT: Failed to get parent processor hierarchy node " \ > - "reference. Token = %p, Status = %r\n", > + "reference. ParentToken = %p. ChildToken = %p. Status = %r\n", > ProcInfoNode->ParentToken, > ProcInfoNode->Token, > Status