From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2005E740039 for ; Thu, 10 Apr 2025 16:46:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wNJ4lKVZaLkQMGZ3LpT83J0dHrqWxpZQukzgCbX3xRk=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1744303613; v=1; x=1744562812; b=G8xfhctJy15jO2CLTqUHGyWZWbSb5dABxvZ+oxODoQzo3gYoQcNe5K43HEC2YIJbOyybTVbD HaqEzLFZI4assuexOr1OnTVgog/itukdUPuP5XsqS1l/rGm/nawcu/FQwc1rjzzPKkoTt+k8lcx ga/irrG95791lbNKPO/jHDG9kCqz26MjwOCAvk8xhknKSB9v2q031CYusxS6Zx7eYVr01Daq75/ XWVZYUbzFtSiS3+rN4ElCa46uBD7/dShZSsWYVYQ9cJMXII5/EflZ09smRzqAa49WDp0c6DkITP jjQSKwdryUAVPUFKeDUUoxpdSuyuRUxcn6I5wSzjLxNbw== X-Received: by 127.0.0.2 with SMTP id qh5gYY7687511xNOUrsYdlE4; Thu, 10 Apr 2025 09:46:52 -0700 Subject: Re: [edk2-devel] ACPI table generator unit test To: "PierreGondois" , devel@edk2.groups.io From: "Sophia Wang via groups.io" X-Originating-Location: Mountain View, California, US (104.133.9.84) X-Originating-Platform: Linux Chrome 135 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 10 Apr 2025 09:46:52 -0700 References: <682dc0ef-849b-4d94-b86e-1a0b80518a13@arm.com> In-Reply-To: <682dc0ef-849b-4d94-b86e-1a0b80518a13@arm.com> Message-ID: <2395.1744303612205599529@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yodagump@google.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AcJ4h6LYgnjH5sak7UmesHMDx7686176AA= Content-Type: multipart/alternative; boundary="t3EdzrOIPCP5v2DMMwoe" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=G8xfhctJ; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --t3EdzrOIPCP5v2DMMwoe Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, RegisterAcpiTableGenerator() never get called in Dbg2GeneratorGoogleTest.cp= p In addition, in order to get the generator by calling RegisterAcpiTableGene= rator() -> then call the BuildAcpiTableEx() callback , we need to define Db= g2Generator as non-static, however, in current upstream code, Dbg2Generator= is defined as STATIC, please see the code below. *STATIC* CONST ACPI_TABLE_GENERATOR =C2=A0Dbg2Generator =3D { // Generator ID CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdDbg2), // Generator Description L"ACPI.STD.DBG2.GENERATOR", // ACPI Table Signature EFI_ACPI_6_3_DEBUG_PORT_2_TABLE_SIGNATURE, // ACPI Table Revision supported by this Generator EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT_REVISION, // Minimum supported ACPI Table Revision EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT_REVISION, // Creator ID TABLE_GENERATOR_CREATOR_ID, // Creator Revision DBG2_GENERATOR_REVISION, // Build table function. Use the extended version instead. NULL, // Free table function. Use the extended version instead. NULL, // Extended Build table function. BuildDbg2TableEx, // Extended free function. FreeDbg2TableEx }; I doubt Dbg2GeneratorGoogleTest.cpp really tests the BuildAcpiTableEx() cal= lback, please correct me if I am wrong. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121257): https://edk2.groups.io/g/devel/message/121257 Mute This Topic: https://groups.io/mt/111930977/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --t3EdzrOIPCP5v2DMMwoe Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi Pierre,
 
RegisterAcpiTableGenerator() never get called in Dbg2GeneratorGoogleTe= st.cpp
 
In addition, in order to get the generator by calling RegisterAcpiTabl= eGenerator() -> then call the BuildAcpiTableEx() callback, we need to define Dbg2Generator as non-static, however, in current upst= ream code, Dbg2Generator is defined as STATIC, please see the code below.
 
STATIC
CONST
ACPI_TABLE_GENERATOR  Dbg= 2Generator =3D {
  // Generator ID
  CREATE_STD_ACPI_TA= BLE_GEN_ID (EStdAcpiTableIdDbg2),
  // Generator Description
  L"ACPI.STD.DBG2.GENERATOR",
  // ACPI Table Signature
  EFI_ACPI_6_3_DEBUG_PORT_2_TABLE_SIGNATURE,
  // ACPI Tab= le Revision supported by this Generator
  EFI_ACPI_DBG2_DEBUG_DEV= ICE_INFORMATION_STRUCT_REVISION,
  // Minimum supported ACPI Tabl= e Revision
  EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT_REVISI= ON,
  // Creator ID
  TABLE_GENERATOR_CREATOR_ID,
=   // Creator Revision
  DBG2_GENERATOR_REVISION,
 = // Build table function. Use the extended version instead.
  NUL= L,
  // Free table function. Use the extended version instead.  NULL,
  // Extended Build table function.
  B= uildDbg2TableEx,
  // Extended free function.
  FreeDbg= 2TableEx
};
 
I doubt Dbg2GeneratorGoogleTest.cpp really tests the BuildAc= piTableEx() callback, please correct me if I am wrong.
 
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#121257) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--t3EdzrOIPCP5v2DMMwoe--