From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [edk2-platforms PATCH] Platform/ARM: Update Readme.md To: Rebecca Cran ,devel@edk2.groups.io From: christopher.jones@arm.com X-Originating-Location: Albany, California, US (217.140.99.251) X-Originating-Platform: Linux Firefox 84 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 17 May 2021 03:10:20 -0700 References: <20210513184031.67329-1-rebecca@bsdio.com> In-Reply-To: <20210513184031.67329-1-rebecca@bsdio.com> Message-ID: <23996.1621246220068770523@groups.io> Content-Type: multipart/alternative; boundary="Ql454Sxu8i5TFIwDiEp2" --Ql454Sxu8i5TFIwDiEp2 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Thank you for your patch. It functionally looks good however I noticed one small grammatical error t= o fix, noted below. Reviewed-by: Chris Jones Thanks, Chris >=20 > The repo with the Visual Studio support no longer exists. > fiptool from the prebuilt_tools repo doesn't work due to a missing > dependency on libcrypto.so.1.0.0, so tell users to build it from the > trusted-firmware-a repo instead. > There's a newer version of fvp-uefi.zip that was released in 2020. >=20 > Signed-off-by: Rebecca Cran > --- > Platform/ARM/Readme.md | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/Platform/ARM/Readme.md b/Platform/ARM/Readme.md > index e1a405b700..afc9ad3646 100644 > --- a/Platform/ARM/Readme.md > +++ b/Platform/ARM/Readme.md > @@ -8,10 +8,8 @@ can be found here: > =3D0D > ##Requirements=3D0D > - A 32-bit or 64-bit Linux host machine.=3D0D > -- Visual Studio is not officially supported, experimental support can b= e > f=3D > ound here:=3D0D > -[ https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=3D3Daarch= 64-vs > ]=3D > =3D0D > =3D0D > -# Build EDK2 Tianocore=3D0D > +# Build EDK2 TianoCore=3D0D > =3D0D > `build -a AARCH64 -p Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.ds= c > =3D > -t GCC5`=3D0D > =3D0D > @@ -26,7 +24,7 @@ prebuilt edk2 image. > =3D0D > We will also rely on the "run_model" script that comes with the > prebuilts,=3D > it=3D0D > is entirely possible to run the model without this but would require > quite=3D > a bit=3D0D [CHRIS] This does not make sense, instead I suggest: "of knowledge regarding the arguments *of the* ARM fastmodel (documentatio= n can be f=3D ound here:=3D0D". Note: while this was not introduced by you it would be nice to fix now. >=20 > -of knowledge regarding the areguments ARM fastmodel (documentation can = be > =3D > found here:=3D0D > +of knowledge regarding the arguments ARM fastmodel (documentation can b= e > f=3D > ound here:=3D0D >=20 > [ https://developer.arm.com/docs/100966/1101/programming-reference-for-b= ase=3D >=20 > -fvps/base-platform-revc-features])=3D0D > however the manual set of the FVP is outside the scope of this document. > I=3D > f you are interested=3D0D > please consult the documentation.=3D0D > @@ -40,16 +38,18 @@ the binaries in the same directory. > - Select Armv8-A Base Platform FVP based on Fast Models 11.4=3D0D > - It has a click through license but is free.=3D0D > =3D0D > -2. Download the 18.10 Linaro ARM Landing Team release for FVP booting > UEFI=3D > =3D0D > - https://releases.linaro.org/members/arm/platforms/18.10/fvp-uefi.zip= =3D0D > +2. Download the 20.01 Linaro ARM Landing Team release for FVP booting > UEFI=3D > =3D0D > + https://releases.linaro.org/members/arm/platforms/20.01/fvp-uefi.zip= =3D0D > =3D0D > -3. Download the prebuilt fiptool from https://git.linaro.org/landing-te= ams=3D >=20 > /working/arm/prebuilt_tools.git=3D0D > +3. Clone the trusted firmware repo from https://git.trustedfirmware.org= /TF=3D >=20 > -A/trusted-firmware-a.git=3D0D > =3D0D > -4. Update the fip.bin image from fvp-uefi.zip by running the following > com=3D > mand:=3D0D > +4. Build fiptool: `make -C trusted-firmware-a/tools/fiptool`=3D0D > =3D0D > - `fiptool update --nt-fw=3D3D[path to binary built above] fip.bin`=3D0D > +5. Update the fip.bin image from fvp-uefi.zip by running the following > com=3D > mand:=3D0D > =3D0D > -5. Execute the FVP run_model.sh script from fvp-uefi.zip and provide a > pat=3D > h to the FVP binaries=3D0D > + `./trusted-firmware-a/tools/fiptool/fiptool update --nt-fw=3D3D[path t= o > bin=3D > ary built above] fip.bin`=3D0D > +=3D0D > +6. Execute the FVP run_model.sh script from fvp-uefi.zip and provide a > pat=3D > h to the FVP binaries=3D0D > downloaded in step 1):=3D0D > =3D0D > `MODEL=3D3D[path to FVP binary] ./run_model.sh`=3D0D > --=3D20 > 2.31.1 --Ql454Sxu8i5TFIwDiEp2 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Rebecca,

Thank you for your patch.

It functionally= looks good however I noticed one small grammatical error to fix, noted bel= ow.

Reviewed-by: Chris Jones <christopher.jones@arm.com>

Thanks,
Chris

The repo with the Visual Studio support no longer exists.
fiptool from the prebuilt_tools repo doesn't work due to a missing
de= pendency on libcrypto.so.1.0.0, so tell users to build it from the
tru= sted-firmware-a repo instead.
There's a newer version of fvp-uefi.zip = that was released in 2020.

Signed-off-by: Rebecca Cran <rebec= ca@bsdio.com>
---
Platform/ARM/Readme.md | 20 ++++++++++------= ----
1 file changed, 10 insertions(+), 10 deletions(-)

diff= --git a/Platform/ARM/Readme.md b/Platform/ARM/Readme.md
index e1a405b= 700..afc9ad3646 100644
--- a/Platform/ARM/Readme.md
+++ b/Platfor= m/ARM/Readme.md
@@ -8,10 +8,8 @@ can be found here:
=3D0D
##= Requirements=3D0D
- A 32-bit or 64-bit Linux host machine.=3D0D
-= - Visual Studio is not officially supported, experimental support can be f= =3D
ound here:=3D0D
-[https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=3D3Daarch6= 4-vs]=3D
=3D0D
=3D0D
-# Build EDK2 Tianocore=3D0D
+= # Build EDK2 TianoCore=3D0D
=3D0D
`build -a AARCH64 -p Platform/A= RM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc =3D
-t GCC5`=3D0D
=3D0= D
@@ -26,7 +24,7 @@ prebuilt edk2 image.
=3D0D
We will also = rely on the "run_model" script that comes with the prebuilts,=3D
it=3D= 0D
is entirely possible to run the model without this but would requir= e quite=3D
a bit=3D0D
[CHRIS] This does not make sense, instead I suggest:
"of knowledge re= garding the arguments of the ARM fastmodel (documentation = can be f=3D
ound here:=3D0D".
Note: while this was not introduced= by you it would be nice to fix now.
-of knowledge regarding the areguments ARM fastmodel (document= ation can be =3D
found here:=3D0D
+of knowledge regarding the arg= uments ARM fastmodel (documentation can be f=3D
ound here:=3D0D
[https://deve= loper.arm.com/docs/100966/1101/programming-reference-for-base=3D
-= fvps/base-platform-revc-features])=3D0D
however the manual set of the = FVP is outside the scope of this document. I=3D
f you are interested= =3D0D
please consult the documentation.=3D0D
@@ -40,16 +38,18 @@= the binaries in the same directory.
- Select Armv8-A Base Platform FV= P based on Fast Models 11.4=3D0D
- It has a click through license but = is free.=3D0D
=3D0D
-2. Download the 18.10 Linaro ARM Landing Tea= m release for FVP booting UEFI=3D
=3D0D
-https://releases.linaro.org/members/arm/platforms/18.= 10/fvp-uefi.zip=3D0D
+2. Download the 20.01 Linaro ARM Landing Tea= m release for FVP booting UEFI=3D
=3D0D
+https://releases.linaro.org/members/arm/platforms/20.= 01/fvp-uefi.zip=3D0D
=3D0D
-3. Download the prebuilt fiptool = from https://git.linaro.org/landing-teams=3D
/working/= arm/prebuilt_tools.git=3D0D
+3. Clone the trusted firmware repo from <= a href=3D"https://git.trustedfirmware.org/TF=3D" target=3D"_blank" rel=3D"n= oopener">https://git.trustedfirmware.org/TF=3D
-A/trusted-firmware= -a.git=3D0D
=3D0D
-4. Update the fip.bin image from fvp-uefi.zip = by running the following com=3D
mand:=3D0D
+4. Build fiptool: `ma= ke -C trusted-firmware-a/tools/fiptool`=3D0D
=3D0D
- `fiptool upd= ate --nt-fw=3D3D[path to binary built above] fip.bin`=3D0D
+5. Update = the fip.bin image from fvp-uefi.zip by running the following com=3D
ma= nd:=3D0D
=3D0D
-5. Execute the FVP run_model.sh script from fvp-u= efi.zip and provide a pat=3D
h to the FVP binaries=3D0D
+ `./trus= ted-firmware-a/tools/fiptool/fiptool update --nt-fw=3D3D[path to bin=3D
ary built above] fip.bin`=3D0D
+=3D0D
+6. Execute the FVP run_m= odel.sh script from fvp-uefi.zip and provide a pat=3D
h to the FVP bin= aries=3D0D
downloaded in step 1):=3D0D
=3D0D
`MODEL=3D3D[pat= h to FVP binary] ./run_model.sh`=3D0D
--=3D20
2.31.1
--Ql454Sxu8i5TFIwDiEp2--