From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 10 Jul 2019 10:17:16 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1F403082B63; Wed, 10 Jul 2019 17:17:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-153.ams2.redhat.com [10.36.117.153]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68F2D60141; Wed, 10 Jul 2019 17:17:14 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging To: devel@edk2.groups.io, eric.dong@intel.com, "Ni, Ray" References: <20190703065416.116816-1-ray.ni@intel.com> <20190703065416.116816-3-ray.ni@intel.com> Cc: Leif Lindholm , "Gao, Liming" , Michael Kinney From: "Laszlo Ersek" Message-ID: <23baa040-63a2-3d8f-f75c-91b1d2c0e3ac@redhat.com> Date: Wed, 10 Jul 2019 19:17:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 10 Jul 2019 17:17:15 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Ray, Eric, (+Liming, +Mike, +Leif) On 07/09/19 03:04, Dong, Eric wrote: > Reviewed-by: Eric Dong > >> -----Original Message----- >> From: Ni, Ray >> Sent: Wednesday, July 3, 2019 2:54 PM >> To: devel@edk2.groups.io >> Cc: Dong, Eric ; Laszlo Ersek >> Subject: [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for >> 5-level paging >> >> 5-level paging is documented in white paper: >> https://software.intel.com/sites/default/files/managed/2b/80/5- >> level_paging_white_paper.pdf >> >> Commit f8113e25001e715390127f23e2197252cbd6d1a2 >> changed Cpuid.h already. >> >> This patch updates IA32_CR4 structure to include LA57 field. >> >> Signed-off-by: Ray Ni >> Cc: Eric Dong >> Regression-tested-by: Laszlo Ersek >> --- >> MdePkg/Include/Library/BaseLib.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Include/Library/BaseLib.h >> b/MdePkg/Include/Library/BaseLib.h >> index ebd7dd274c..a22bfc9fad 100644 >> --- a/MdePkg/Include/Library/BaseLib.h >> +++ b/MdePkg/Include/Library/BaseLib.h >> @@ -5324,7 +5324,8 @@ typedef union { >> UINT32 OSXMMEXCPT:1; ///< Operating System Support for >> ///< Unmasked SIMD Floating Point >> ///< Exceptions. >> - UINT32 Reserved_0:2; ///< Reserved. >> + UINT32 Reserved_2:1; ///< Reserved. >> + UINT32 LA57:1; ///< Linear Address 57bit. >> UINT32 VMXE:1; ///< VMX Enable >> UINT32 Reserved_1:18; ///< Reserved. >> } Bits; I'm sorry but you will have to revert this patch series immediately. None of the MdePkg maintainers have approved this patch -- commit 7c5010c7f88b. In the first place, Mike and Liming were never CC'd on the patch, so they may not have noticed it, even. The situation is very similar to the recent SM3 crypto series that I had to revert myself. An MdePkg patch was pushed without package owner review. Can you guys please revert this series immediately, without me having to do it? If we think that MdePkg should have more "M" folks, in order to distribute the review load better, then we should address that problem first. Ignoring rules just because that's more convenient is not acceptable. Thanks, Laszlo