From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.20174.1574164950107487058 for ; Tue, 19 Nov 2019 04:02:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YPFPsQIv; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574164949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h008IAdejsRj85O1ale2oLJG8+2/PhoGmQ8eVllv+RM=; b=YPFPsQIvYv4ocywvehZ9yGGW9tTmmDCK1Ou6mjPYjUconUIMoBjNYkoPB63pUQ6ykT3TcR ZQTjMfskz2OkuwodocA56n05ypzVZjtdUOXdzU8t8wDkv82j4X/f30z44iPZoCBxo1LvJD nJJ4fo46xG4tHEwbPYGsIPMdUekwn2s= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-IT0bg1iMO7W_SHkduboRGg-1; Tue, 19 Nov 2019 07:02:27 -0500 Received: by mail-wr1-f69.google.com with SMTP id 92so18259623wro.14 for ; Tue, 19 Nov 2019 04:02:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6iRZNolWWG7S9S9wn8nbcW79tNsePvY1yGmBTavGUMM=; b=hYmwJvpkVOo+lnBDnWVE/y9V+gbgcNVYDLitMeeI6bbnkaK0mZla/X9OZGmNRl6jzQ Xi/l3y2wTB/aNPYWVpj/LwSQaw0xoUTP3xnoeTb/YwtNIXOwYqPFad7N+aMSeoRM0fjh Ys2ydOr7QmXUqBVCmXHuXvkGXwmwhFDPh7+5a84UHJE3l2v9slg1oicjIjP7uSU0zPc/ J7U+gfHbQedIcSpGBvN3S6qfqkkYVwxveWvImG2odNdDVSA8BfABPvVRVtB70Pvi8nCe w4gWSFQNMKlImGbpeyrges/Bprdwalu8/HL5tnbCXVrYVGm2JZTUoGZULhFK3kmLVls6 tPag== X-Gm-Message-State: APjAAAVZxnHHl/PC+pMRz5bDFbCH4BObl/tYbPgIdv3JSO7m4tynP92A 12PtgYGKWUowZDzchforQeliss3nHdoFexqomd1LOJ/MsgIUKKmir9s73kTYJRmFq2wGaQWrLqr bxKpXf6f/0XGrgw== X-Received: by 2002:a5d:61c6:: with SMTP id q6mr5615873wrv.13.1574164946736; Tue, 19 Nov 2019 04:02:26 -0800 (PST) X-Google-Smtp-Source: APXvYqzFVoMMbEQ2mea0oqSRz0ttn6TM2OjUPQn67d3nYplk/WzhkKXGTQA9dlxRnSGC9WxbwZswdw== X-Received: by 2002:a5d:61c6:: with SMTP id q6mr5615732wrv.13.1574164945588; Tue, 19 Nov 2019 04:02:25 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id t14sm26267118wrw.87.2019.11.19.04.02.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2019 04:02:24 -0800 (PST) Subject: Re: [edk2-platforms][PATCH v2 1/7] Platform/RPi: Add missing model name To: Pete Batard , devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, samer.el-haj-mahmoud@arm.com References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-2-pete@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <23bdf10d-77fd-542e-2e99-65827d09a4ba@redhat.com> Date: Tue, 19 Nov 2019 13:02:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191119113809.2472-2-pete@akeo.ie> X-MC-Unique: IT0bg1iMO7W_SHkduboRGg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/19/19 12:38 PM, Pete Batard wrote: > From: Samer El-Haj-Mahmoud >=20 > Add a missing entry for the "Raspberry Pi Compute Module 3+" in > RpiFirmwareGetModelName (). >=20 > Signed-off-by: Leif Lindholm I feel really lost with how the S-o-b are handled. I'd have expected, Samer as the author, signs it. Pete forwards it, then=20 Leif refactors a bit by extracting a part of the previous bigger patch. So: Signed-off-by: Samer El-Haj-Mahmoud Signed-off-by: Pete Batard Signed-off-by: Leif Lindholm Anyway, back to the technical content: Reviewed-by: Philippe Mathieu-Daude > --- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c= b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > index 9b4aa068857c..dcb434fabefe 100644 > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -1,5 +1,6 @@ > /** @file > * > + * Copyright (c) 2019, ARM Limited. All rights reserved. > * Copyright (c) 2017-2018, Andrei Warkentin > * Copyright (c) 2016, Linaro, Ltd. All rights reserved. > * > @@ -595,6 +596,8 @@ RpiFirmwareGetModelName ( > return "Raspberry Pi 3 Model B+"; > case 0x0E: > return "Raspberry Pi 3 Model A+"; > + case 0x10: > + return "Raspberry Pi Compute Module 3+"; > case 0x11: > return "Raspberry Pi 4 Model B"; > default: >=20