From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 22A1281E84 for ; Thu, 19 Jan 2017 00:33:31 -0800 (PST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 711F93A7695; Thu, 19 Jan 2017 08:33:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-25.phx2.redhat.com [10.3.116.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0J8XSux029001; Thu, 19 Jan 2017 03:33:29 -0500 To: Jiaxin Wu , edk2-devel@ml01.01.org References: <1484803083-147376-1-git-send-email-jiaxin.wu@intel.com> <1484803083-147376-4-git-send-email-jiaxin.wu@intel.com> Cc: Justen Jordan L , Gary Lin , Ye Ting , Fu Siyuan , Ruiyu Ni , Kinney Michael D From: Laszlo Ersek Message-ID: <23d6bd7a-84b5-dc7a-d830-2673d1d5d781@redhat.com> Date: Thu, 19 Jan 2017 09:33:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484803083-147376-4-git-send-email-jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 19 Jan 2017 08:33:31 +0000 (UTC) Subject: Re: [PATCH 3/3] OvmfPkg: Allow HTTP connections if HTTP Boot enabled X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 08:33:31 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Jiaxin, On 01/19/17 06:18, Jiaxin Wu wrote: > Overwrite the value of PcdAllowHttpConnections to allow HTTP > connections if HTTP Boot enabled (-D HTTP_BOOT_ENABLE). > > Cc: Laszlo Ersek > Cc: Justen Jordan L > Cc: Gary Lin > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Ruiyu Ni > Cc: Kinney Michael D > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > --- > OvmfPkg/OvmfPkgIa32.dsc | 6 +++++- > OvmfPkg/OvmfPkgIa32X64.dsc | 6 +++++- > OvmfPkg/OvmfPkgX64.dsc | 6 +++++- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index e060602..2c38578 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -394,10 +394,14 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > > + !if $(HTTP_BOOT_ENABLE) == TRUE > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > + !endif > + > # DEBUG_INIT 0x00000001 // Initialization > # DEBUG_WARN 0x00000002 // Warnings > # DEBUG_LOAD 0x00000004 // Load events > # DEBUG_FS 0x00000008 // EFI File system > # DEBUG_POOL 0x00000010 // Alloc & Free (pool) > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 0e24e7a..2760533 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -440,10 +440,14 @@ > !ifdef $(SOURCE_DEBUG_ENABLE) > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 > !endif > > [PcdsFixedAtBuild.X64] > +!if $(HTTP_BOOT_ENABLE) == TRUE > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > +!endif > + > !ifndef $(USE_OLD_SHELL) > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > !endif > > !if $(SMM_REQUIRE) == TRUE > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 108f7d5..56fddc3 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -399,10 +399,14 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > > + !if $(HTTP_BOOT_ENABLE) == TRUE > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > + !endif > + > # DEBUG_INIT 0x00000001 // Initialization > # DEBUG_WARN 0x00000002 // Warnings > # DEBUG_LOAD 0x00000004 // Load events > # DEBUG_FS 0x00000008 // EFI File system > # DEBUG_POOL 0x00000010 // Alloc & Free (pool) > thank you for the patch; it looks good. However, for aesthetic and consistency reasons, I'd like to request an update. The placement of the new setting is entirely right in the "OvmfPkgIa32X64.dsc" file. However, the Ia32 and X64 DSC files don't follow that placement. Therefore I would like to request the following two changes, for both the Ia32 and X64 DSC files: - please move the new setting just above the "!ifndef $(USE_OLD_SHELL)" part, where "PcdShellFile" is set, - please un-indent the new setting to column zero. (Well, the "!if" goes to column zero, the actual setting goes to column two.) The idea is that all three DSC files should remain pair-wise comparable with the "diff" utility; any differences displayed by "diff" should be related to *genuine* Ia32 <-> Ia32X64 <-> X64 differences. For the next version, I think you can carry forward the following two tags from Gary (see his email elsewhere in this thread): Reviewed-by: Gary Lin Tested-by: Gary Lin (I'm just repeating them here so you can easily cut n' paste them to the commit message.) Thank you! Laszlo