From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.48303.1590491870798265991 for ; Tue, 26 May 2020 04:17:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cc8kfz38; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590491870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/5DvggudCL5yGpgD54enTVSDRmUmwMO2D4XVDlpT1+E=; b=cc8kfz38Bs8aK0p5jyc0OiBrRKl3EMb6vS4gFhXGkyHldGW2Fs9WR0UpPQBvLZz0WOkNYy cxcVBO06INteoIz4FltxwzIyCVlXAUETj6/2H+lLPQo1XkmEVSsDqnYYx5xIGPdFvLV2aG fvKqJwqGmab2IWIlgBKRscOSu4h6E30= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83-Oz8K26_aNNm_lr1CNbOYOQ-1; Tue, 26 May 2020 07:17:46 -0400 X-MC-Unique: Oz8K26_aNNm_lr1CNbOYOQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49996100CCC3; Tue, 26 May 2020 11:17:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-136.ams2.redhat.com [10.36.114.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 792CB5D9E5; Tue, 26 May 2020 11:17:43 +0000 (UTC) Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process To: Andrew Fish Cc: Bret Barkelew , "devel@edk2.groups.io" , "spbrogan@outlook.com" , "rfc@edk2.groups.io" , "Desimone, Nathaniel L" , Mike Kinney , "Leif Lindholm (Nuvia address)" References: <2107AEA7-9145-4FC9-9E1A-C396F23877ED@apple.com> From: "Laszlo Ersek" Message-ID: <23ed8abb-2d08-5b67-4824-e88ba555e6cd@redhat.com> Date: Tue, 26 May 2020 13:17:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/25/20 20:28, Andrew Fish wrote: > > >> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: >> >> Hi Andrew, >> >> On 05/25/20 06:09, Andrew Fish wrote: >> >>> I also found I had to Bing/Google to find the detailed instructions I >>> needed as a developer, as the Wiki seems to assume you just know the >>> Linux kernel patch process. That feels like an area we can improve. >> >> (apologies if I've lost context; please disregard my message below in >> that case). >> >> I wrote the following wiki article originally in 2016: >> >> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers >> >> I wrote it specifically for developers & maintainers with no (or almost >> no) prior git / mailing list experience. Multiple developers confirmed >> later that the article had helped them. >> > > Laszlo, > > Your wiki article was very very helpful. I just could not find it from the Tianocre wiki. It would be good if we could link to it from here [1], maybe as add to this: "Are you new to using git? If so, then the New to git page may be helpful."? The article at [1] is an official document, while the "unkempt guide" is not official. The unkempt guide starts by deferring to [1]. I didn't think the official document should point to my unofficial one, and/or we should create a loop of links. That said, if someone else updates [1] with a pointer, I won't protest. That's just something that I (having authored the unkempt guide) would not propose myself. I do agree that the wiki search facilities on github are basic. What has mostly worked for me is clicking the Pages arrow, and then entering a *very simple* search term in the drop-down search box. For example, if I do that now, and only enter "git", then the "unkempt guide" is listed (with other hits of course). I think this search box is basically for searching article titles. > > There are a lot folks who use git but don't use the email based review so they have never setup git with emali before. Your wiki, plus me figuring out the magic internal SMTP reflector (I reached out on an internal git malling list) is what got me unblocked. It's great that you have access to such infrastructure at Apple! Thanks! Laszlo > > [1] https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > > Thanks, > > Andrew Fish > >> Thanks >> Laszlo >> >