From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.78]) by mx.groups.io with SMTP id smtpd.web12.13680.1633370984941615888 for ; Mon, 04 Oct 2021 11:09:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=E8FRBRn+; spf=pass (domain: arm.com, ip: 40.107.20.78, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QyjR7WPxsmVcmElhOVn5INqF1SL5a9BYxxx10ouwyXM=; b=E8FRBRn+GD9wvLTg1loPdn1e4VvfVhDU4xUpuGb+t86tD5Haw8HTQ2krklJfZPLFfsdhV9QESYrDpfgc/WHQtLOz2Bx92rsMhOnRRglrgcALciACM/hGimXO5jQ6fGnCX94iAjWuoFpnnpOfbyWoTyx+5LirdCJm87EWO0iNLbY= Received: from DB6PR0601CA0031.eurprd06.prod.outlook.com (2603:10a6:4:17::17) by HE1PR0801MB1915.eurprd08.prod.outlook.com (2603:10a6:3:4f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Mon, 4 Oct 2021 18:09:41 +0000 Received: from DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:17:cafe::91) by DB6PR0601CA0031.outlook.office365.com (2603:10a6:4:17::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19 via Frontend Transport; Mon, 4 Oct 2021 18:09:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.33.187.114) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.33.187.114 as permitted sender) receiver=protection.outlook.com; client-ip=63.33.187.114; helo=64aa7808-outbound-2.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-2.mta.getcheckrecipient.com (63.33.187.114) by DB5EUR03FT053.mail.protection.outlook.com (10.152.21.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 18:09:40 +0000 Received: ("Tessian outbound 173d710607ad:v103"); Mon, 04 Oct 2021 18:09:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a10af0bd3ae1d32a X-CR-MTA-TID: 64aa7808 Received: from 35b8c39dbe10.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 71D6272C-88C9-4CF5-BDEC-95E0C3201CD5.1; Mon, 04 Oct 2021 18:09:28 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35b8c39dbe10.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Oct 2021 18:09:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGVCng6RHEJFPr96kN+h0lHOGW9Hi9lxY/Zj+wIX13utLRe0ioYrkKvfknjGyN1KUpGKFGhuKvcU7Li8PY0wVG0BwD/DLuz4mGVVAKMG+IQvTcEHzbu+/XdaUbk9mFGZGpKW10qT28hvG9WK3Sm3rZY78rRGkUr3R/4Qdu4kUHrd/Buj95Mv+FvuQ8gtCNaAcGbMaiAUrhiXWYdonEeemLmrfC5MBTKW1Ys7kw4q3gr61976yG9QEqL8+UBoMGioH0xMu0jxIavz5cZdxTugHmXme9HXvxqHykYH8lAcKZk918GpSOVe6xOMHG8Q33A1nsvyqpPzVOobzEDKe2ewgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QyjR7WPxsmVcmElhOVn5INqF1SL5a9BYxxx10ouwyXM=; b=eHON2C1XKL/mGnnXb7qgvAsXLdqtQcCTvEzevZFXMBGvZeGQHBLH3F66BtuJKOxd3sQJPBeDmQtJ18fFkquMqgdUwp803aDeRe2HmuF0m1DFuvtB2gMTccCwCDWcjIVgHGTQY6l3spz4H86+G6F2q6SiVIHklgUuW6zVR+AXfvqFVtYisBT/z7FC2QOIyLkArnEBMNTUEtb8wcLm9gYaWEFEVnAciHB9MyehKRUCc6+CtlMIOwf1Dh/6rFuS2P1FTCkVl+fqH6icglrfiEnNYXLkHsAvrMUH0KuKAG72VN4oDOQ706kC1o4O1amdGg6BsyRvQkWtW2aTdFZ9ttqkyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QyjR7WPxsmVcmElhOVn5INqF1SL5a9BYxxx10ouwyXM=; b=E8FRBRn+GD9wvLTg1loPdn1e4VvfVhDU4xUpuGb+t86tD5Haw8HTQ2krklJfZPLFfsdhV9QESYrDpfgc/WHQtLOz2Bx92rsMhOnRRglrgcALciACM/hGimXO5jQ6fGnCX94iAjWuoFpnnpOfbyWoTyx+5LirdCJm87EWO0iNLbY= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6261.eurprd08.prod.outlook.com (2603:10a6:20b:295::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 4 Oct 2021 18:09:25 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 18:09:25 +0000 Subject: Re: [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg To: Abner Chang , devel@edk2.groups.io Cc: Ard Biesheuvel , Thomas Abraham , Daniel Schaefer , nd References: <20211004093001.4576-1-abner.chang@hpe.com> <20211004093001.4576-6-abner.chang@hpe.com> From: "Sami Mujawar" Message-ID: <23f41e19-28e1-e5de-b634-8a02e4e83c93@arm.com> Date: Mon, 4 Oct 2021 19:09:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211004093001.4576-6-abner.chang@hpe.com> X-ClientProxiedBy: LO2P265CA0270.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0270.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Mon, 4 Oct 2021 18:09:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 51a7d60e-c224-4964-8ee4-08d9876222ba X-MS-TrafficTypeDiagnostic: AS8PR08MB6261:|HE1PR0801MB1915: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4502;OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ORVZWV8rz4scPauGjooFCk4up7iuAfqNHWQZnkQPGdtlVke68eBeN7pkHPZL1k8Uam9bjhvqca7UGEoINN7CUP/tDGGmeMUVVsanaVCQuvIXieWqBua+rFYdSOrD82DuWYk9rZQ2J7lYrEhsDvJhZ67MEnXJ/RBItgUKwTfnFyHTrHpIvO9vhlkLJXgJghat2/ujCKRdFsQGO1/c23Rsfyw40hYBjvTkMP13gJoZUIFdIWZgC+1ewBPhPEIHn5AL3zTtwn9rtH81Gg/4YDgc5l6F/z4hItQkfJj9B2abVr1iEgkeffIn+cfXooS0aNBuKYB/EfoQAaKg3iQ5XAr6cKnnLMr2v91s45Xb8Qy+LJ9faY5ZA/cAHJNTIf53ZSElxIUBiXaGVm4HB3sAn2ROk6tJfHXoJ/nn9c/4Xa9DCEAuRO9tpT8CWhpPAHgvNJ1/L2Ugiruuc/YYL02Oflf2p7LJdQYXLLufqYxSgfyHcWrE/c2XR8OcE5H6QiRwYVt5sBvOZRxXzH6mGsha6wGUamq8/ovYMzmdvQs6CjvLrrD5/hA6ObZ+biLVBFasSqlaczH3Lgy9TYwgBmrpLqPAuFB1fEHDtGjy1wrVFm5NX+LQ21ACpEUgY0TaWLMnbhmnAezxhMflijLFoWcUf1DP682w44S2wtLSvUfMD7Djfr0Bu0h8VepN3kmU75C/LebEvLyp6F3FbnaFypaUOch/55vaga98LpV/S9IWGyAdt6a0bqaFSrmCwxnjPbYUHR1Dos4EPzChNvEjGxMt0vI3L0RV1NcRdCPl/fGz6gF5vnygpy3upHPrlUnWV7+zYM5UMbA8xRa+EuAnyGgtKeiKVKDrgXn7wCuC8p566Fd3OdU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(966005)(38100700002)(38350700002)(36756003)(508600001)(316002)(83380400001)(5660300002)(54906003)(66556008)(53546011)(8676002)(956004)(2616005)(6486002)(8936002)(31696002)(19627235002)(31686004)(86362001)(66946007)(66476007)(16576012)(296002)(186003)(26005)(4326008)(52116002)(2906002)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6261 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 254ffdc6-f334-44b4-ffb1-08d98762196c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DnGrO74fre5K6Fr+seJCbgRbUviKU1XG/pXlg0xOBGBOFBV/QQ5/fs0p2EGQZMLvMnOOS5Ze19Idx5QemnW1VYBkjG+62VLISFVt+FiiO8rNfhxstHbyb8aNsmW3VRO46mAwF651YTysbJFmZPoAe7LdtWtcdnIb+iRBM0HjUUYJK9wyQtHKzjZsv9OMsy22PNwuw29c8lL1/o4wVrDiitGFPb61JS5ASQcnch+GBhXflH14KzvWC5hB8DTPhtMmuU2PDTdARBDKQ7L0lISb8LZjkA5iaAlgx5hOH6MZ7pcelded7KArmJ6Fn/IvpVf7FVCVy+Vyk80TmJY1oa6fDdl2BrYC9Y6Sj5q8+PYyB9JiNK0l4+2yi+s6CiIVqrKHb8+YXCaoGq13o/OoX9eguRCf90IU29F/upz+qo3kG/2s0I9U3dY/9Avi7qaFpxuLl7jNsTWh8yvFGwu6dGKqnPZOkYMxR/yPuPa8PC4P5FAO/nwsZyXF66QDVMQoKXQcghIxkaQoTqUXTsv2mw5hs6T1qGYld+z+rDHUA4xvKBhzLyt8CbwJtKcG2tZ9ABegSVYZhrycZVer3YwDlnJ0k8AOGsiCTTOXIOYR8HqSpwS6HQMMuoKDuDRDWJKuUa/y5y1kKGB4R4XzJiBym5AP4c81zRdK4w9hlaq42VLWKvuOahhCNj8i/i2mnLVGkI2UZPLx6Vvx/07qj1LU5Kkt2+/XqqJIqojGxgdnmQikExsxMSvrUj1LwRIUmKuDKy21ZfA2IC4+b+7zc+QyXQ3Yy1Zi8BZtgYCt+FIcawUYFiWc+7Fnd32+OaNktt1mpgmz X-Forefront-Antispam-Report: CIP:63.33.187.114;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-2.mta.getcheckrecipient.com;PTR:ec2-63-33-187-114.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(36840700001)(46966006)(31696002)(44832011)(356005)(54906003)(36860700001)(966005)(82310400003)(19627235002)(316002)(16576012)(508600001)(36756003)(31686004)(81166007)(86362001)(4326008)(8676002)(2616005)(956004)(83380400001)(8936002)(336012)(53546011)(5660300002)(2906002)(186003)(70586007)(70206006)(26005)(47076005)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 18:09:40.8752 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51a7d60e-c224-4964-8ee4-08d9876222ba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.33.187.114];Helo=[64aa7808-outbound-2.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1915 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Abner, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 04/10/2021 10:29 AM, Abner Chang wrote: > Complaint with BZ: #3665 > https://bugzilla.tianocore.org/show_bug.cgi?id=3665 > > PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by > both ARM and RISC-V arch. This patch uses the one from MdePkg > instead the one under ArmVirtPkg. > > Signed-off-by: Abner Chang > Cc: Ard Biesheuvel > Cc: Thomas Abraham > Cc: Sami Mujawar > Cc: Daniel Schaefer > --- > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 3 ++- > Platform/ARM/JunoPkg/ArmJuno.dsc | 3 ++- > .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 3 ++- > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > index 7e37732fb9..6679939d3b 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -1,5 +1,6 @@ > # > # Copyright (c) 2018-2021, ARM Limited. All rights reserved. > +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -150,7 +151,7 @@ > gArmTokenSpaceGuid.PcdPciBusMax|255 > gArmTokenSpaceGuid.PcdPciIoBase|0x0 > gArmTokenSpaceGuid.PcdPciIoSize|0x00800000 > - gArmTokenSpaceGuid.PcdPciIoTranslation|0x77800000 > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x77800000 > gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0 > gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24 > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index fdfc8cd9e2..3b7a63b643 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -1,5 +1,6 @@ > # > # Copyright (c) 2013-2018, ARM Limited. All rights reserved. > +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -178,7 +179,7 @@ > gArmTokenSpaceGuid.PcdPciMmio64Size|0x100000000 > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x40000000 > - gArmTokenSpaceGuid.PcdPciIoTranslation|0x5f800000 > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x5f800000 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24 > > # List of Device Paths that support BootMonFs > diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf > index 8b4a6e2fad..fb513d7b3d 100644 > --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf > +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf > @@ -2,6 +2,7 @@ > # PCI Host Bridge Library instance for ARM Juno > # > # Copyright (c) 2017, Linaro Ltd. All rights reserved.
> +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -51,7 +52,7 @@ > gArmTokenSpaceGuid.PcdPciBusMax > gArmTokenSpaceGuid.PcdPciIoBase > gArmTokenSpaceGuid.PcdPciIoSize > - gArmTokenSpaceGuid.PcdPciIoTranslation > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation > gArmTokenSpaceGuid.PcdPciMmio32Base > gArmTokenSpaceGuid.PcdPciMmio32Size > gArmTokenSpaceGuid.PcdPciMmio32Translation