public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [Patch v2 0/6] Fix performance issue caused by Set MSR task.
Date: Wed, 17 Oct 2018 19:33:41 +0200	[thread overview]
Message-ID: <243e175d-989f-ee90-de05-d5511a775e4c@redhat.com> (raw)
In-Reply-To: <20181017021635.14972-1-eric.dong@intel.com>

Hi Eric,

On 10/17/18 04:16, Eric Dong wrote:
> V2 changes include:
> 1. Include the change for CpuCommonFeaturesLib which used to set MSR base on its scope info.
> 2. Include the change for CpuS3DataDxe driver which also handle the AcpiCpuData data.
> 3. Update code base on feedback for V1 changes.

reviewing this version of the series is on my TODO list. I was
out-of-office yesterday (somewhat unexpectedly) and this morning I had
130 emails just in my inbox (not counting other list traffic).

I've more or less managed to get to the bottom of that mail dump by now,
but as a result, it's too late to start reviewing your v2 still today.
Hopefully I can cover it tomorrow.

(I might fetch another email batch this evening, and handle small items.
Thus, you could see further emails from me on the list tonight.)

If Ray reviewed your v2 today (while I was busy unburying myself from my
inbox), and you are ready to post a v3 based on Ray's comments, please
do so. Then I'll skip v2 and catch up with v3.

Thanks!
Laszlo


  parent reply	other threads:[~2018-10-17 17:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  2:16 [Patch v2 0/6] Fix performance issue caused by Set MSR task Eric Dong
2018-10-17  2:16 ` [Patch v2 1/6] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information Eric Dong
2018-10-18  3:04   ` Ni, Ruiyu
2018-10-18  3:10   ` Ni, Ruiyu
2018-10-17  2:16 ` [Patch v2 2/6] UefiCpuPkg/RegisterCpuFeaturesLib.h: Add new dependence types Eric Dong
2018-10-18  3:31   ` Ni, Ruiyu
2018-10-17  2:16 ` [Patch v2 3/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type Eric Dong
2018-10-18  5:46   ` Ni, Ruiyu
2018-10-17  2:16 ` [Patch v2 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: " Eric Dong
2018-10-18  5:54   ` Ni, Ruiyu
2018-10-17  2:16 ` [Patch v2 5/6] UefiCpuPkg/CpuS3DataDxe: Keep old data if value already existed Eric Dong
2018-10-18  5:57   ` Ni, Ruiyu
2018-10-17  2:16 ` [Patch v2 6/6] UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info Eric Dong
2018-10-18  6:01   ` Ni, Ruiyu
2018-10-17 17:33 ` Laszlo Ersek [this message]
2018-10-18  7:36   ` [Patch v2 0/6] Fix performance issue caused by Set MSR task Dong, Eric
2018-10-18  2:12 ` Ni, Ruiyu
2018-10-18  2:35   ` Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=243e175d-989f-ee90-de05-d5511a775e4c@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox