From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 825DD2116DF8F for ; Wed, 17 Oct 2018 10:33:44 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C93F38666E; Wed, 17 Oct 2018 17:33:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-50.rdu2.redhat.com [10.10.120.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC67A85AB0; Wed, 17 Oct 2018 17:33:42 +0000 (UTC) To: Eric Dong Cc: Ruiyu Ni , edk2-devel-01 References: <20181017021635.14972-1-eric.dong@intel.com> From: Laszlo Ersek Message-ID: <243e175d-989f-ee90-de05-d5511a775e4c@redhat.com> Date: Wed, 17 Oct 2018 19:33:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181017021635.14972-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 17 Oct 2018 17:33:43 +0000 (UTC) Subject: Re: [Patch v2 0/6] Fix performance issue caused by Set MSR task. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 17:33:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Eric, On 10/17/18 04:16, Eric Dong wrote: > V2 changes include: > 1. Include the change for CpuCommonFeaturesLib which used to set MSR base on its scope info. > 2. Include the change for CpuS3DataDxe driver which also handle the AcpiCpuData data. > 3. Update code base on feedback for V1 changes. reviewing this version of the series is on my TODO list. I was out-of-office yesterday (somewhat unexpectedly) and this morning I had 130 emails just in my inbox (not counting other list traffic). I've more or less managed to get to the bottom of that mail dump by now, but as a result, it's too late to start reviewing your v2 still today. Hopefully I can cover it tomorrow. (I might fetch another email batch this evening, and handle small items. Thus, you could see further emails from me on the list tonight.) If Ray reviewed your v2 today (while I was busy unburying myself from my inbox), and you are ready to post a v3 based on Ray's comments, please do so. Then I'll skip v2 and catch up with v3. Thanks! Laszlo