public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and N1Sdp to use PrePeiCoreUniCore
@ 2022-10-25 20:56 Rebecca Cran
  2022-10-26  8:58 ` Sami Mujawar
  0 siblings, 1 reply; 3+ messages in thread
From: Rebecca Cran @ 2022-10-25 20:56 UTC (permalink / raw)
  To: devel, Thomas Abraham, Sami Mujawar, Ard Biesheuvel; +Cc: Rebecca Cran

Modern platforms that use TF-A should use PrePeiCoreUniCore, since
any secondary cores will be put in the TF-A holding pen and won't
reach EDK2.

Update the Morello and N1Sdp files to use PrePeiCoreUniCore instead of
PrePeiCoreMPCore.

Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
---
 Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 +-
 Platform/ARM/N1Sdp/N1SdpPlatform.dsc         | 2 +-
 Platform/ARM/Morello/MorelloPlatformFvp.fdf  | 2 +-
 Platform/ARM/N1Sdp/N1SdpPlatform.fdf         | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
index 1c93246a5273..b8210c87ad18 100644
--- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
+++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
@@ -148,7 +148,7 @@ [Components.common]
   # PEI Phase modules
   ArmPkg/Drivers/CpuPei/CpuPei.inf
   ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
-  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
   ArmPlatformPkg/PlatformPei/PlatformPeim.inf
   MdeModulePkg/Core/Pei/PeiMain.inf
   MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
index 865dd04deb09..d04b22d3ef51 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
@@ -176,7 +176,7 @@ [Components.common]
   # PEI Phase modules
   ArmPkg/Drivers/CpuPei/CpuPei.inf
   ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
-  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
   ArmPlatformPkg/PlatformPei/PlatformPeim.inf
   MdeModulePkg/Core/Pei/PeiMain.inf
   MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
diff --git a/Platform/ARM/Morello/MorelloPlatformFvp.fdf b/Platform/ARM/Morello/MorelloPlatformFvp.fdf
index 5f2af05c8bfc..581579270488 100644
--- a/Platform/ARM/Morello/MorelloPlatformFvp.fdf
+++ b/Platform/ARM/Morello/MorelloPlatformFvp.fdf
@@ -187,7 +187,7 @@ [FV.FVMAIN_COMPACT]
   INF ArmPkg/Drivers/CpuPei/CpuPei.inf
   INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
   INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
-  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
   INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
   INF MdeModulePkg/Core/Pei/PeiMain.inf
   INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
index 09f1e0e0073b..e5e24ea50294 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
@@ -190,7 +190,7 @@ [FV.FVMAIN_COMPACT]
   INF ArmPkg/Drivers/CpuPei/CpuPei.inf
   INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
   INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
-  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
   INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
   INF MdeModulePkg/Core/Pei/PeiMain.inf
   INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and N1Sdp to use PrePeiCoreUniCore
  2022-10-25 20:56 [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and N1Sdp to use PrePeiCoreUniCore Rebecca Cran
@ 2022-10-26  8:58 ` Sami Mujawar
  2022-12-13 15:05   ` [edk2-devel] " Sami Mujawar
  0 siblings, 1 reply; 3+ messages in thread
From: Sami Mujawar @ 2022-10-26  8:58 UTC (permalink / raw)
  To: Rebecca Cran, devel@edk2.groups.io, Thomas Abraham,
	Ard Biesheuvel; +Cc: nd

Hi Rebecca,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 25/10/2022, 21:57, "Rebecca Cran" <rebecca@quicinc.com> wrote:

    Modern platforms that use TF-A should use PrePeiCoreUniCore, since
    any secondary cores will be put in the TF-A holding pen and won't
    reach EDK2.

    Update the Morello and N1Sdp files to use PrePeiCoreUniCore instead of
    PrePeiCoreMPCore.

    Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
    ---
     Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 +-
     Platform/ARM/N1Sdp/N1SdpPlatform.dsc         | 2 +-
     Platform/ARM/Morello/MorelloPlatformFvp.fdf  | 2 +-
     Platform/ARM/N1Sdp/N1SdpPlatform.fdf         | 2 +-
     4 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
    index 1c93246a5273..b8210c87ad18 100644
    --- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
    +++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
    @@ -148,7 +148,7 @@ [Components.common]
       # PEI Phase modules
       ArmPkg/Drivers/CpuPei/CpuPei.inf
       ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
    -  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
    +  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
       ArmPlatformPkg/PlatformPei/PlatformPeim.inf
       MdeModulePkg/Core/Pei/PeiMain.inf
       MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
    diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
    index 865dd04deb09..d04b22d3ef51 100644
    --- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
    +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
    @@ -176,7 +176,7 @@ [Components.common]
       # PEI Phase modules
       ArmPkg/Drivers/CpuPei/CpuPei.inf
       ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
    -  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
    +  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
       ArmPlatformPkg/PlatformPei/PlatformPeim.inf
       MdeModulePkg/Core/Pei/PeiMain.inf
       MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
    diff --git a/Platform/ARM/Morello/MorelloPlatformFvp.fdf b/Platform/ARM/Morello/MorelloPlatformFvp.fdf
    index 5f2af05c8bfc..581579270488 100644
    --- a/Platform/ARM/Morello/MorelloPlatformFvp.fdf
    +++ b/Platform/ARM/Morello/MorelloPlatformFvp.fdf
    @@ -187,7 +187,7 @@ [FV.FVMAIN_COMPACT]
       INF ArmPkg/Drivers/CpuPei/CpuPei.inf
       INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
       INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
    -  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
    +  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
       INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
       INF MdeModulePkg/Core/Pei/PeiMain.inf
       INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
    diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
    index 09f1e0e0073b..e5e24ea50294 100644
    --- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
    +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
    @@ -190,7 +190,7 @@ [FV.FVMAIN_COMPACT]
       INF ArmPkg/Drivers/CpuPei/CpuPei.inf
       INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
       INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
    -  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
    +  INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
       INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
       INF MdeModulePkg/Core/Pei/PeiMain.inf
       INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
    -- 
    2.30.2



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and N1Sdp to use PrePeiCoreUniCore
  2022-10-26  8:58 ` Sami Mujawar
@ 2022-12-13 15:05   ` Sami Mujawar
  0 siblings, 0 replies; 3+ messages in thread
From: Sami Mujawar @ 2022-12-13 15:05 UTC (permalink / raw)
  To: Sami Mujawar, devel

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]

Merged as df870c7beaee..425cce541517

Thanks.

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 101 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-13 15:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-25 20:56 [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and N1Sdp to use PrePeiCoreUniCore Rebecca Cran
2022-10-26  8:58 ` Sami Mujawar
2022-12-13 15:05   ` [edk2-devel] " Sami Mujawar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox