FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[prakashk]

Hi Gaoliming

Regarding Bugzilla Bug 3755, I have sent the patch to devel@edk2.groups.io and you have updated that you have received the patch. But the changes are not merged into EDK2 source.
The sent patch is in the below mail thread.
Kindly let us know the status of Bug 3755.

Thanks,
Prakash K

-----Original Message-----
From: Prakash K <prakashk@ami.com>
Sent: Wednesday, December 29, 2021 5:37 PM
To: devel@edk2.groups.io; Prakash K <prakashk@ami.com>
Cc: Vasudevan Sambandan <vasudevans@ami.com>; Sundaresan S <sundaresans@ami.com>; Gayathri Thunuguntla <gayathrit@ami.com>
Subject: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

In smbiosview command, modified the below SMBIOS Type38 fields to display in formatted manner 1. Base Address 2. IPMI Specification Version 3. NV Storage Device Address 4. I2C Slave Address

Signed-off-by: Prakash K<prakashk@ami.com>
---
 .../SmbiosView/PrintInfo.c                    | 20 +++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index b144600a25..0a8dd4afba 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -1158,10 +1158,22 @@ SmbiosPrintStructure (
     //

     case 38:

       DisplayIPMIDIBMCInterfaceType (Struct->Type38->InterfaceType, Option);

-      PRINT_STRUCT_VALUE_H (Struct, Type38, IPMISpecificationRevision);

-      PRINT_STRUCT_VALUE_H (Struct, Type38, I2CSlaveAddress);

-      PRINT_STRUCT_VALUE_H (Struct, Type38, NVStorageDeviceAddress);

-      PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);

+      ShellPrintEx(-1,-1,L"IPMISpecificationRevision: %d.%d\n",
+ Struct->Type38->IPMISpecificationRevision >> 4,

+
+ Struct->Type38->IPMISpecificationRevision & 0x0F);

+

+      ShellPrintEx(-1, -1,L"I2CSlaveAddress: 0x%x\n",Struct->
+ Type38->I2CSlaveAddress >>1);

+

+      if (Struct->Type38->NVStorageDeviceAddress == 0xFF) {

+        ShellPrintEx(-1,-1,L"NVStorageDevice: Not Present\n");

+      } else {

+        PRINT_STRUCT_VALUE_H (Struct, Type38, NVStorageDeviceAddress);

+      }

+

+      if (Struct->Type38->InterfaceType ==
+ IPMIDeviceInfoInterfaceTypeSSIF) {

+        ShellPrintEx(-1, -1,L"BaseAddress: 0x%x\n",Struct-> Type38->
+ BaseAddress >>1);

+      } else {

+        PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);

+      }

       break;



     //

--
2.18.0.windows.1

This e-mail is intended for the use of the addressee only and may contain privileged, confidential, or proprietary information that is exempt from disclosure under law. If you have received this message in error, please inform us promptly by reply e-mail, then delete the e-mail and destroy any printed copy. Thank you.
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[gaoliming]

Prakash:
  Yes. I get this mail. Zhichao is ShellPkg maintainer. I include him to
review this change. 


Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Prakash K via
> groups.io
> 发送时间: 2022年8月26日 12:08
> 收件人: gaoliming@byosoft.com.cn; devel@edk2.groups.io
> 抄送: Vasudevan Sambandan <vasudevans@ami.com>; Sundaresan S
> <sundaresans@ami.com>; Gayathri Thunuguntla <gayathrit@ami.com>
> 主题: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields
in
> formatted manner
> 
> Hi Gaoliming
> 
> Regarding Bugzilla Bug 3755, I have sent the patch to devel@edk2.groups.io
> and you have updated that you have received the patch. But the changes are
> not merged into EDK2 source.
> The sent patch is in the below mail thread.
> Kindly let us know the status of Bug 3755.
> 
> Thanks,
> Prakash K
> 
> -----Original Message-----
> From: Prakash K <prakashk@ami.com>
> Sent: Wednesday, December 29, 2021 5:37 PM
> To: devel@edk2.groups.io; Prakash K <prakashk@ami.com>
> Cc: Vasudevan Sambandan <vasudevans@ami.com>; Sundaresan S
> <sundaresans@ami.com>; Gayathri Thunuguntla <gayathrit@ami.com>
> Subject: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted
> manner
> 
> In smbiosview command, modified the below SMBIOS Type38 fields to display
> in formatted manner 1. Base Address 2. IPMI Specification Version 3. NV
> Storage Device Address 4. I2C Slave Address
> 
> Signed-off-by: Prakash K<prakashk@ami.com>
> ---
>  .../SmbiosView/PrintInfo.c                    | 20
> +++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index b144600a25..0a8dd4afba 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -1158,10 +1158,22 @@ SmbiosPrintStructure (
>      //
> 
>      case 38:
> 
>        DisplayIPMIDIBMCInterfaceType (Struct->Type38->InterfaceType,
> Option);
> 
> -      PRINT_STRUCT_VALUE_H (Struct, Type38, IPMISpecificationRevision);
> 
> -      PRINT_STRUCT_VALUE_H (Struct, Type38, I2CSlaveAddress);
> 
> -      PRINT_STRUCT_VALUE_H (Struct, Type38, NVStorageDeviceAddress);
> 
> -      PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);
> 
> +      ShellPrintEx(-1,-1,L"IPMISpecificationRevision: %d.%d\n",
> + Struct->Type38->IPMISpecificationRevision >> 4,
> 
> +
> + Struct->Type38->IPMISpecificationRevision & 0x0F);
> 
> +
> 
> +      ShellPrintEx(-1, -1,L"I2CSlaveAddress: 0x%x\n",Struct->
> + Type38->I2CSlaveAddress >>1);
> 
> +
> 
> +      if (Struct->Type38->NVStorageDeviceAddress == 0xFF) {
> 
> +        ShellPrintEx(-1,-1,L"NVStorageDevice: Not Present\n");
> 
> +      } else {
> 
> +        PRINT_STRUCT_VALUE_H (Struct, Type38,
> NVStorageDeviceAddress);
> 
> +      }
> 
> +
> 
> +      if (Struct->Type38->InterfaceType ==
> + IPMIDeviceInfoInterfaceTypeSSIF) {
> 
> +        ShellPrintEx(-1, -1,L"BaseAddress: 0x%x\n",Struct-> Type38->
> + BaseAddress >>1);
> 
> +      } else {
> 
> +        PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);
> 
> +      }
> 
>        break;
> 
> 
> 
>      //
> 
> --
> 2.18.0.windows.1
> 
> This e-mail is intended for the use of the addressee only and may contain
> privileged, confidential, or proprietary information that is exempt from
> disclosure under law. If you have received this message in error, please
inform
> us promptly by reply e-mail, then delete the e-mail and destroy any
printed
> copy. Thank you.
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 

Re: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Hi Gaoliming,

Kindly let us know the review status of this issue.

Thanks,
Prakash K

[-- Attachment #2: Type: text/html, Size: 161 bytes --]

回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[gaoliming]

Prakash:
  I don't see the reason for the change of I2CSlaveAddress. Can you help to
add it? 

  And, can you create pull request for this patch and make sure it pass open
CI?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Prakash K via
> groups.io
> 发送时间: 2022年8月26日 12:08
> 收件人: gaoliming@byosoft.com.cn; devel@edk2.groups.io
> 抄送: Vasudevan Sambandan <vasudevans@ami.com>; Sundaresan S
> <sundaresans@ami.com>; Gayathri Thunuguntla <gayathrit@ami.com>
> 主题: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields
in
> formatted manner
> 
> Hi Gaoliming
> 
> Regarding Bugzilla Bug 3755, I have sent the patch to devel@edk2.groups.io
> and you have updated that you have received the patch. But the changes are
> not merged into EDK2 source.
> The sent patch is in the below mail thread.
> Kindly let us know the status of Bug 3755.
> 
> Thanks,
> Prakash K
> 
> -----Original Message-----
> From: Prakash K <prakashk@ami.com>
> Sent: Wednesday, December 29, 2021 5:37 PM
> To: devel@edk2.groups.io; Prakash K <prakashk@ami.com>
> Cc: Vasudevan Sambandan <vasudevans@ami.com>; Sundaresan S
> <sundaresans@ami.com>; Gayathri Thunuguntla <gayathrit@ami.com>
> Subject: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted
> manner
> 
> In smbiosview command, modified the below SMBIOS Type38 fields to display
> in formatted manner 1. Base Address 2. IPMI Specification Version 3. NV
> Storage Device Address 4. I2C Slave Address
> 
> Signed-off-by: Prakash K<prakashk@ami.com>
> ---
>  .../SmbiosView/PrintInfo.c                    | 20
> +++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index b144600a25..0a8dd4afba 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -1158,10 +1158,22 @@ SmbiosPrintStructure (
>      //
> 
>      case 38:
> 
>        DisplayIPMIDIBMCInterfaceType (Struct->Type38->InterfaceType,
> Option);
> 
> -      PRINT_STRUCT_VALUE_H (Struct, Type38, IPMISpecificationRevision);
> 
> -      PRINT_STRUCT_VALUE_H (Struct, Type38, I2CSlaveAddress);
> 
> -      PRINT_STRUCT_VALUE_H (Struct, Type38, NVStorageDeviceAddress);
> 
> -      PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);
> 
> +      ShellPrintEx(-1,-1,L"IPMISpecificationRevision: %d.%d\n",
> + Struct->Type38->IPMISpecificationRevision >> 4,
> 
> +
> + Struct->Type38->IPMISpecificationRevision & 0x0F);
> 
> +
> 
> +      ShellPrintEx(-1, -1,L"I2CSlaveAddress: 0x%x\n",Struct->
> + Type38->I2CSlaveAddress >>1);
> 
> +
> 
> +      if (Struct->Type38->NVStorageDeviceAddress == 0xFF) {
> 
> +        ShellPrintEx(-1,-1,L"NVStorageDevice: Not Present\n");
> 
> +      } else {
> 
> +        PRINT_STRUCT_VALUE_H (Struct, Type38,
> NVStorageDeviceAddress);
> 
> +      }
> 
> +
> 
> +      if (Struct->Type38->InterfaceType ==
> + IPMIDeviceInfoInterfaceTypeSSIF) {
> 
> +        ShellPrintEx(-1, -1,L"BaseAddress: 0x%x\n",Struct-> Type38->
> + BaseAddress >>1);
> 
> +      } else {
> 
> +        PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);
> 
> +      }
> 
>        break;
> 
> 
> 
>      //
> 
> --
> 2.18.0.windows.1
> 
> This e-mail is intended for the use of the addressee only and may contain
> privileged, confidential, or proprietary information that is exempt from
> disclosure under law. If you have received this message in error, please
inform
> us promptly by reply e-mail, then delete the e-mail and destroy any
printed
> copy. Thank you.
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 

Re: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

Hi Gaoliming,

We have created Pull Request for the patch.
Kindly let us know in which tag the changes will be merged.

Thanks,
Prakash K

[-- Attachment #2: Type: text/html, Size: 176 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

Can you give Pull Request link?

 

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Prakash K via groups.io
发送时间: 2022年11月24日 14:08
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

Hi Gaoliming,

We have created Pull Request for the patch.
Kindly let us know in which tag the changes will be merged.

Thanks,
Prakash K




[-- Attachment #2: Type: text/html, Size: 3634 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

Hi Gaoliming,

Link for Pull Request -> https://github.com/tianocore/edk2/pull/3656

Thanks,
Prakash K

[-- Attachment #2: Type: text/html, Size: 226 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

Hi Gaoliming,

Kindly let us the know the review status of the pull request.

Thanks,
Prakash K

[-- Attachment #2: Type: text/html, Size: 122 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Prakash:

 Please update the commit message title that should start with package name. The code logic looks good. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Prakash K via groups.io
发送时间: 2022年12月5日 14:28
收件人: Prakash K <prakashk@ami.com>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

Hi Gaoliming,

Kindly let us the know the review status of the pull request.

Thanks,
Prakash K 




[-- Attachment #2: Type: text/html, Size: 3891 bytes --]

Re: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]

Hi Gaoliming,

I have updated the commit message title with the package name.

Commit Message Title : ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

Kindly let us know if we need to make any changes.

Thanks,
Prakash K


From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Wednesday, December 7, 2022 8:07 AM
To: devel@edk2.groups.io; Prakash Kashivishwanathan <prakashk@ami.com>
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Prakash:
 Please update the commit message title that should start with package name. The code logic looks good.

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Prakash K via groups.io
发送时间: 2022年12月5日 14:28
收件人: Prakash K <prakashk@ami.com<mailto:prakashk@ami.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

Hi Gaoliming,

Kindly let us the know the review status of the pull request.

Thanks,
Prakash K

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[-- Attachment #2: Type: text/html, Size: 7784 bytes --]

回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2505 bytes --]

Prakash: 

  Have you updated PR 3656?

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Prakash K
发送时间: 2022年12月7日 21:04
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

Hi Gaoliming,

 

I have updated the commit message title with the package name.

 

Commit Message Title : ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

Kindly let us know if we need to make any changes.

 

Thanks,

Prakash K

 

 

From: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > 
Sent: Wednesday, December 7, 2022 8:07 AM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Prakash Kashivishwanathan <prakashk@ami.com <mailto:prakashk@ami.com> >
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

 

**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** 

Prakash:

 Please update the commit message title that should start with package name. The code logic looks good. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>  <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 Prakash K via groups.io
发送时间: 2022年12月5日 14:28
收件人: Prakash K <prakashk@ami.com <mailto:prakashk@ami.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

Hi Gaoliming,

Kindly let us the know the review status of the pull request.

Thanks,
Prakash K 

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. 




[-- Attachment #2: Type: text/html, Size: 10191 bytes --]

Re: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

Hi Gaolimihg,

The commit message title is starting with package name in PR3656.
Please check the pull request and let us know

PR3656 -> https://github.com/tianocore/edk2/pull/3656

Thanks,
Prakash K

[-- Attachment #2: Type: text/html, Size: 458 bytes --]

回复: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

Prakash:

 Seemly, PR3656 is not updated recently. Please confirm. 

 

Thanks

Liming

发件人: prakashk via groups.io <prakashk=ami.com@groups.io> 
发送时间: 2022年12月30日 12:20
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

Hi Gaolimihg,

The commit message title is starting with package name in PR3656.
Please check the pull request and let us know

PR3656 ->   <https://github.com/tianocore/edk2/pull/3656> https://github.com/tianocore/edk2/pull/3656

Thanks,
Prakash K  


[-- Attachment #2: Type: text/html, Size: 3934 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

Hi Gaoliming,

I have updated the commit message title with the package name.
After updating the commit message title, CI check failed and it is not related to ShellPkg changes.
Kindly help to check it.

Thanks,
Prakash K

[-- Attachment #2: Type: text/html, Size: 258 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi Gaoliming,

Pull Request #3656 has been closed without merging the changes.
Link -> https://github.com/tianocore/edk2/pull/3656 ( https://github.com/tianocore/edk2/pull/3656 )

May I know the reason for closing the pull request ?
Should I create another pull request ?

Thanks,
Prakash K

[-- Attachment #2: Type: text/html, Size: 386 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

Prakash:

  Your update looks good.   I will help merge it. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Prakash K via groups.io
发送时间: 2023年1月10日 12:35
收件人: Prakash K <prakashk@ami.com>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

 

Hi Gaoliming,

Pull Request #3656 has been closed without merging the changes.
Link -> <https://github.com/tianocore/edk2/pull/3656>  https://github.com/tianocore/edk2/pull/3656

May I know the reason for closing the pull request ?
Should I create another pull request ?

Thanks,
Prakash K 




[-- Attachment #2: Type: text/html, Size: 4421 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

[Prakash K]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Hi Gaoliming,

I have updated the commit message title with the package name.

Commit Message Title - " *ShellPkg: Displaying SMBIOS Type38 fields in formatted manner":*

**

Kindly let us know if we need to make any changes.

**

Thanks,

Prakash K

[-- Attachment #2: Type: text/html, Size: 1783 bytes --]