From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 25407D80888 for ; Tue, 9 Jan 2024 12:14:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/mGETo06wXoxxOgu2j6B0cVz6g4kwOWVCBsZ4w5w9Q8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704802443; v=1; b=a4qlFlPYh9IU2thl5iwU5gfZAvV+wmqq+C+RZGbxuGAaTaKXZd8FuWWBW2rbgpn57zjCFF3e gQ/91BD67pjEKnsEBXPyDVKusCN2VyYkhjfVg7ijP2cpw0yprIBRXmsmt+Km+kksH04n1tPDLT7 cbXsOgu7hP4pBV+ka27MrqkM= X-Received: by 127.0.0.2 with SMTP id 49hHYY7687511xJHeIpVjoxP; Tue, 09 Jan 2024 04:14:03 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.15121.1704802442912350900 for ; Tue, 09 Jan 2024 04:14:03 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-cqC4ZJm9MaWRlEMe5Q6frw-1; Tue, 09 Jan 2024 07:14:00 -0500 X-MC-Unique: cqC4ZJm9MaWRlEMe5Q6frw-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 06E0D811E9C; Tue, 9 Jan 2024 12:14:00 +0000 (UTC) X-Received: from [10.39.193.97] (unknown [10.39.193.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2844C15E6C; Tue, 9 Jan 2024 12:13:58 +0000 (UTC) Message-ID: <24565570-4147-db82-27c1-1281c895254a@redhat.com> Date: Tue, 9 Jan 2024 13:13:57 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth? To: Ard Biesheuvel , devel@edk2.groups.io, Michael Kinney Cc: rebecca@os.amperecomputing.com, Jeff Brasen , jake@nvidia.com, Michael.Roth@amd.com, joeyvagedes@microsoft.com References: <2490526e-539f-9d5c-4572-f09c324a07aa@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bnzvTeillTWXEK07tIhHbRKhx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=a4qlFlPY; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 1/9/24 11:45, Ard Biesheuvel wrote: > On Tue, 9 Jan 2024 at 10:17, Laszlo Ersek wrote: >> >> On 1/5/24 01:05, Rebecca Cran via groups.io wrote: >>> I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and >>> Michael Roth have funky Author lines, which I think means .mailmap need= s >>> updated? >>> >>> Author: Jeff Brasen via groups.io >>> Author: Joey Vagedes via groups.io >>> Author: Jake Garver via groups.io >>> Author: Roth, Michael via groups.io >> >> I'm sure I'm confusing the terms here, but this is a consequence of >> DMARC / DKIM / whatever, for some senders. groups.io cannot resend some >> kind of messages to list subscribers where the original sender domain >> (such as nvidia.com, microsoft.com, amd.com) is cryptographically >> authenticated. If groups.io resent those messages with identical "from", >> then the recipients (list subscribers) would reject those messages, >> because they'd perceive the messages as fakes (the crypto check would >> catch that the messages came from groups.io but claimed to originate >> from nvidia.com, microsoft.com, amd.com -- that's exactly what DKIM / >> DMARC etc etc are supposed to prevent). Therefore groups.io rewrites the >> sender email addresses like seen above, and then "git-am" picks up those >> rewritten addresses verbatim. That's how they end up in the git commit >> history. >> >> This can be manually fixed by whoever applies such patches from the >> list: after the initial "git-am", a git-rebase is needed, and each patch >> needs to have its author meta-datum fixed with "git commit --amend >> --author=3D'corrected email address'". It's a lot of manual and error >> prone work (unless someone scripts it, effectively "decoding" the >> rewriting format that groups.io employs). As much as it pains me to >> admit it, this is definitely an argument in favor of git forge-based >> contributions, and against mailing list-based patches. >> >> ".mailmap" can be used to mitigate this issue, per gitmailmap(5); it'd >> be better just not to permit such mangled "From:" fields to seep into >> the git log, in the future. :/ >> >=20 > Agreed, and I think this came up somewhere last year perhaps? Mike > Kinney (cc'ed) might remember if that went anywhere, but the idea was > for PatchCheck.py (which is also used in CI) to reject patches using > an email address in this format. Oh, great idea. When CI runs PatchCheck.py on the final "push" PR, that would definitely catch this issue just in time! >=20 > Note that git am does support a 'From: ' header as the first line of > the commit log, and will use it correctly to supersede the From: > header in the SMTP envelope. OTOH, that doesn't help in this case, IIUC. When the poster originally formats and sends the patch, their gitconfig says user.email=3Dfoobar@example.com, and the author meta-datum on the patch most likely *also* says foobar@example.com. (I.e., they are formatting a patch they have authored themselves.) Therefore git-format-patch/git-send-email have no reason to include an explicit "From:" line at the top of the commit message body. I agree that "From:", if present, mitigates the issue, but in most cases, I reckon, it's not present. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113445): https://edk2.groups.io/g/devel/message/113445 Mute This Topic: https://groups.io/mt/103534194/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-