public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables
Date: Mon, 23 Jul 2018 14:04:16 +0200 (CEST)	[thread overview]
Message-ID: <245a2cb56bb240ef@bloch.sibelius.xs4all.nl> (raw)

Hi Chris,

I noticed that in the DSDT for this platform, the _DSD for some
devices uses the Device Porperties UUID.  Existing uses of this UUID
on ARM platforms within the edk2 use device properties aligned with
the DeviceTree specification (https://www.devicetree.org/).  The
device properties in this patch clearly are not, even though existing
bindings for the i.MX6 hardware you're targetting exist.

I also noted that the "RegisterBasePA" property duplicates information
provided by _CRS, which is something that the Device Properties UUID
specification explicitly forbids.

Cheers,

Mark



             reply	other threads:[~2018-07-23 12:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 12:04 Mark Kettenis [this message]
2018-07-23 22:09 ` [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables Chris Co
  -- strict thread matches above, loose matches on Subject: below --
2018-07-22  1:30 [PATCH edk2-platforms 0/4] Import Solidrun Hummingboard Edge package Chris Co
2018-07-22  1:30 ` [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables Chris Co

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=245a2cb56bb240ef@bloch.sibelius.xs4all.nl \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox