From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=83.163.83.176; helo=sibelius.xs4all.nl; envelope-from=mark.kettenis@sibelius.xs4all.nl; receiver=edk2-devel@lists.01.org Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E5B5421B02845 for ; Mon, 23 Jul 2018 05:04:18 -0700 (PDT) Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id d5d2bda3; Mon, 23 Jul 2018 14:04:16 +0200 (CEST) Date: Mon, 23 Jul 2018 14:04:16 +0200 (CEST) From: Mark Kettenis To: edk2-devel@lists.01.org Message-Id: <245a2cb56bb240ef@bloch.sibelius.xs4all.nl> Subject: Re: [PATCH edk2-platforms 3/4] Platform/SolidRun: Add Hummingboard ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 12:04:19 -0000 Hi Chris, I noticed that in the DSDT for this platform, the _DSD for some devices uses the Device Porperties UUID. Existing uses of this UUID on ARM platforms within the edk2 use device properties aligned with the DeviceTree specification (https://www.devicetree.org/). The device properties in this patch clearly are not, even though existing bindings for the i.MX6 hardware you're targetting exist. I also noted that the "RegisterBasePA" property duplicates information provided by _CRS, which is something that the Device Properties UUID specification explicitly forbids. Cheers, Mark