From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.170.1591635665286409861 for ; Mon, 08 Jun 2020 10:01:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=1tNavc7k; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.65, mailfrom: pete@akeo.ie) Received: by mail-wr1-f65.google.com with SMTP id p5so18184716wrw.9 for ; Mon, 08 Jun 2020 10:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2wpSsnAEie4wJMNMcMbWcdYSVRxZHMY1ec3gLuQfc7Y=; b=1tNavc7kO8TO+VuqHRHYcbFZbzf67zWpLyZ8ZV548BjWjabzRgg+VUUXEneUiFX9nw dNgbzEFajy3jFPdDcl/cjHmhi7LKoeE7PNAp3SKBSn4zXj8WUtQnnnpqVEXPfn+dr0OH Gry9fPh15E4CMaDyJP56Y82xnVGRqgcb/n0Dq7Vkb5tN8ohQ0CHvOeAnZl504sb/WZdv jM+ASuCQHyEJe6MnAsrlacxOZOOLjeEG+4S3gNqpD/SR6WkefO9OurLQql7sx3zcGNPC RZwuiE8Zn99WZuaEx2zSZRuvSOyXkrhCMffpdGfmTj32PUhqrXWVtxwTmwIU1ogygf7p sNgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2wpSsnAEie4wJMNMcMbWcdYSVRxZHMY1ec3gLuQfc7Y=; b=FmZoOvDJgrKZxXI4HJ8YBsgflls+aCil6yx/Bt5bLSevlGQb/XELUFKAXcri11Xppz bYcqgY9X7kSn62W7dWKygI4xoGAj3fX4hSe1OhQ0lp1y8n22hTRSDcpoJm9tPz03lsBx 0qwpp1wY2UO82oxL1HQsbcHZYinvOYSP0GqXIR0spO2v12uYsvfGMnGitrCynA88cniA ZH0m/LyDnnCrdB0S0m3hWyh6dIjm40TRTTpDHjyO33C6nrLRLoqEcJrLV0B9KJ4HCmLl 97svKtMsXuhWtPmqA95Yz+jw8AUbJG8qHzKDHIWomwvw65Gp38HFDTlohpd6YLOVpaP9 /ylw== X-Gm-Message-State: AOAM531H0LwrmJsmjGYGNfqkr5Uv0Q6Z5yA7X7EZtmm/Lut1edjfM05t 3gWOMdpSJx340VemuLXCM+h3kw== X-Google-Smtp-Source: ABdhPJyejBIITz/0iqH1XF08IsAYq2G0MMfAQ5v6TLfU+0TqHDAEZ22NKrxgvmSNwNYdDAPrAHPV/Q== X-Received: by 2002:a5d:6581:: with SMTP id q1mr23900483wru.43.1591635663800; Mon, 08 Jun 2020 10:01:03 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.48.247]) by smtp.googlemail.com with ESMTPSA id z7sm334872wrt.6.2020.06.08.10.01.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 10:01:02 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot To: Ard Biesheuvel , devel@edk2.groups.io Cc: leif@nuviainc.com References: <20200608155159.8748-1-pete@akeo.ie> <5009d194-b701-b602-ba3a-dd32891173bd@arm.com> From: "Pete Batard" Message-ID: <246570db-3b98-a893-fec0-85d6b13d7641@akeo.ie> Date: Mon, 8 Jun 2020 18:01:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <5009d194-b701-b602-ba3a-dd32891173bd@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 2020.06.08 17:43, Ard Biesheuvel wrote: > On 6/8/20 5:51 PM, Pete Batard wrote: >> This reverts commit c8000ecccc83b728baf04ced2fedb870bc3bc1b3 on account >> of USB keyboard devices not being detected until after the timeout to >> enter the Setup menu or run the UEFI Shell has expired. >> >> The core of the issue is that, when EfiBootManagerConnectAll() is not >> invoked, PCI bus scanning only starts after the BDS wait period has >> elapsed, which effectively takes away the ability to use an USB device >> to enact Boot Device Selection or interact with the Setup menu. >> >> Signed-off-by: Pete Batard > > Could we move the call to > > EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); > > to the start of PlatformBootManagerBeforeConsole() instead? Moving EfiEventGroupSignal(&gEfiEndOfDxeEventGroupGuid) early into PlatformBootManagerBeforeConsole() doesn't seem to have any effect, as far as I could test. We can however move the EfiBootManagerConnectAll() there if that's what you are asking. Regards, /Pete > > > > >> --- >>   Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 5 >> +++++ >>   1 file changed, 5 insertions(+) >> >> diff --git >> a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c >> b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c >> index 253614a646c1..2bd625ad7e7c 100644 >> --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -655,6 +655,11 @@ PlatformBootManagerAfterConsole ( >>       Print (BOOT_PROMPT); >>     } >> +  // >> +  // Connect the rest of the devices. >> +  // >> +  EfiBootManagerConnectAll (); >> + >>     Status = gBS->LocateProtocol (&gEsrtManagementProtocolGuid, NULL, >> (VOID**)&EsrtManagement); >>     if (!EFI_ERROR (Status)) { >>       EsrtManagement->SyncEsrtFmp (); >> >