From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2D900D8065A for ; Tue, 9 Jan 2024 09:17:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GsIYBcsdYGXAsLy5hHmp6OZ5F1sS6HpINWeNkhxu1+g=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704791872; v=1; b=Pn7SXlA1aNWZBq8LblDHTQfaKmKqzd0Y2GrK5S1FRhVS89CqXf/a3C6z6ARYdaafRSMU6+er w9V2cVWBqwTYfyrGcAN8ItrF7HTkWuSS0ERoKGWr2qSTdQXLYXw8Q/K64QNBDZ6K0fvlk456c63 JDTQulstITZ0UBRmyfTA/IJE= X-Received: by 127.0.0.2 with SMTP id BkEkYY7687511xKlmImTAYuj; Tue, 09 Jan 2024 01:17:52 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.13013.1704791871850542063 for ; Tue, 09 Jan 2024 01:17:52 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-pAxm2AgdO_i83Hq2YwWauw-1; Tue, 09 Jan 2024 04:17:47 -0500 X-MC-Unique: pAxm2AgdO_i83Hq2YwWauw-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47F901034AA2; Tue, 9 Jan 2024 09:17:47 +0000 (UTC) X-Received: from [10.39.193.97] (unknown [10.39.193.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 605E81C060AF; Tue, 9 Jan 2024 09:17:46 +0000 (UTC) Message-ID: <2490526e-539f-9d5c-4572-f09c324a07aa@redhat.com> Date: Tue, 9 Jan 2024 10:17:45 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth? To: devel@edk2.groups.io, rebecca@os.amperecomputing.com, Jeff Brasen , jake@nvidia.com, Michael.Roth@amd.com, joeyvagedes@microsoft.com References: From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AeYuvteysZpCVZT4ILMcQ3ZMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Pn7SXlA1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 1/5/24 01:05, Rebecca Cran via groups.io wrote: > I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and > Michael Roth have funky Author lines, which I think means .mailmap needs > updated? >=20 > Author: Jeff Brasen via groups.io > Author: Joey Vagedes via groups.io > Author: Jake Garver via groups.io > Author: Roth, Michael via groups.io I'm sure I'm confusing the terms here, but this is a consequence of DMARC / DKIM / whatever, for some senders. groups.io cannot resend some kind of messages to list subscribers where the original sender domain (such as nvidia.com, microsoft.com, amd.com) is cryptographically authenticated. If groups.io resent those messages with identical "from", then the recipients (list subscribers) would reject those messages, because they'd perceive the messages as fakes (the crypto check would catch that the messages came from groups.io but claimed to originate from nvidia.com, microsoft.com, amd.com -- that's exactly what DKIM / DMARC etc etc are supposed to prevent). Therefore groups.io rewrites the sender email addresses like seen above, and then "git-am" picks up those rewritten addresses verbatim. That's how they end up in the git commit history. This can be manually fixed by whoever applies such patches from the list: after the initial "git-am", a git-rebase is needed, and each patch needs to have its author meta-datum fixed with "git commit --amend --author=3D'corrected email address'". It's a lot of manual and error prone work (unless someone scripts it, effectively "decoding" the rewriting format that groups.io employs). As much as it pains me to admit it, this is definitely an argument in favor of git forge-based contributions, and against mailing list-based patches. ".mailmap" can be used to mitigate this issue, per gitmailmap(5); it'd be better just not to permit such mangled "From:" fields to seep into the git log, in the future. :/ Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113436): https://edk2.groups.io/g/devel/message/113436 Mute This Topic: https://groups.io/mt/103534194/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-