From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "levi.yun" <yeoreum.yun@arm.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platform v1 2/2] ARM/JunoPkg: Use ArmTrngLib in NetworkPkg
Date: Fri, 02 Aug 2024 09:35:31 -0700 [thread overview]
Message-ID: <24946.1722616531487785077@groups.io> (raw)
In-Reply-To: <20240722151312.937594-1-yeoreum.yun@arm.com>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Hi Levi,
Thank you for this patch.
On Mon, Jul 22, 2024 at 08:13 AM, levi.yun wrote:
>
> Change-Id: I1f0c72bdbb46d0226e7e6ddd921d513c8d5943c2
The change-Id must be dropped before the patch is sent to the mailing list.
The edk2\BaseTools\Scripts\PatchCheck.py script catches such issues.
I will fix this locally before merging, but please run the patchcheck script before submitting patches for review.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120214): https://edk2.groups.io/g/devel/message/120214
Mute This Topic: https://groups.io/mt/107486843/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 1522 bytes --]
prev parent reply other threads:[~2024-08-02 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 15:13 [edk2-devel] [PATCH edk2-platform v1 2/2] ARM/JunoPkg: Use ArmTrngLib in NetworkPkg levi.yun
2024-08-02 16:35 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24946.1722616531487785077@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox