From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 66118941B1E for ; Fri, 2 Aug 2024 16:35:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=obNEX+8qvnrUe+CpTOCiHuUm/C1M8IA8oGJZh68ENHE=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1722616533; v=1; b=tVXB4NSpd34i1DD+fsTA9itIdVS8BhgRc2ZP1hS2C10ynuNtwKWPWa3jeoUW7gQJ4zrgcVz+ f6Bz+5fXa0Fr0Hw5pyP0HCYeDeS8LW+ZPjzmcuBSfe+yTwdV52PdKw6QNCoa9KFRk9Dklpa88y2 SbeQyDQJGezBbvITgxxqgXC0Qu5ptW1hdIeamEAPXEFb88En/TA1DebFvnt2iP94mk6dFoyfk5P 15HK6/CaCFjAzWFo5znXjADzj5dIJrm2li+fljI4TC2+JtFzITnutRToPItVS7qevYqwV4YlZjg S2WBwP2pXkPbkbBhk9CUBeP7qSFlZwBNaelJXNT0ntV0Q== X-Received: by 127.0.0.2 with SMTP id 55lhYY7687511xUE1ABEAGY3; Fri, 02 Aug 2024 09:35:31 -0700 Subject: Re: [edk2-devel] [PATCH edk2-platform v1 2/2] ARM/JunoPkg: Use ArmTrngLib in NetworkPkg To: "levi.yun" , devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.49) X-Originating-Platform: Windows Firefox 128 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 02 Aug 2024 09:35:31 -0700 References: <20240722151312.937594-1-yeoreum.yun@arm.com> In-Reply-To: <20240722151312.937594-1-yeoreum.yun@arm.com> Message-ID: <24946.1722616531487785077@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Kg4wqBJgL6jLowpv4ez08LV5x7686176AA= Content-Type: multipart/alternative; boundary="YjsIeTfXSDlRG0wECkuj" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=tVXB4NSp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --YjsIeTfXSDlRG0wECkuj Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Levi, Thank you for this patch. On Mon, Jul 22, 2024 at 08:13 AM, levi.yun wrote: >=20 > Change-Id: I1f0c72bdbb46d0226e7e6ddd921d513c8d5943c2 The change-Id must be dropped before the patch is sent to the mailing list. The edk2\BaseTools\Scripts\PatchCheck.py script catches such issues. I will fix this locally before merging, but please run the patchcheck scrip= t before submitting patches for review. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120214): https://edk2.groups.io/g/devel/message/120214 Mute This Topic: https://groups.io/mt/107486843/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --YjsIeTfXSDlRG0wECkuj Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi Levi,
 
Thank you for this patch.
 
On Mon, Jul 22, 2024 at 08:13 AM, levi.yun wrote:
Change-Id: I1f0c72bdbb46d0226e7e6ddd921d513c8d5943c2 The change-Id must be dropped before the patch is sent to the mailing list.=
The edk2\BaseTools\Scripts\PatchCheck.py script catches such issues.
 
I will fix this locally before merging, but please run the patchcheck = script before submitting patches for review.
 
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
 
Regards,
 
Sami Mujawar
 
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120214) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--YjsIeTfXSDlRG0wECkuj--