Re: [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue

[Laszlo Ersek <lersek@redhat.com>]

On 10/08/18 08:39, Ni, Ruiyu wrote:
> On 9/28/2018 2:18 PM, Ming Huang wrote:
>>
>>
>> On 9/26/2018 1:00 PM, Ni, Ruiyu wrote:
>>>> @@ -507,12 +552,13 @@ BmRepairAllControllers (
>>>>                                      FormBrowser2,
>>>>                                      &HiiHandles[Index],
>>>>                                      1,
>>>> -                                   PcdGetPtr
>>>> (PcdDriverHealthConfigureForm),
>>>> +                                   &gEfiHiiDriverHealthFormsetGuid,
>>>
>>> I still don't quite understand the changes.
>>> But the above specific change removes the
>>> PcdDriverHealthConfigureForm form pop up.
>>> Instead it pops up each driver health form one by one.
>>> Why?
>>
>> This change is refer to the below function:
>> ProcessSingleControllerHealth
>> (IntelFrameworkModulePkg/Universal/Bdsdxe/DeviceMngr/DeviceManager.c).
>> I don't real understand it also, but it works.
>>
> 
> I am sorry. I cannot review the changes if you cannot explain it:)
> Fix should be based on the thoroughly understanding to the issue.

Could it be that the RAID card driver is buggy?

Thanks
Laszlo