From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EAFC12116327F for ; Mon, 8 Oct 2018 05:15:13 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 264BB3DE; Mon, 8 Oct 2018 12:15:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-219.rdu2.redhat.com [10.10.120.219]) by smtp.corp.redhat.com (Postfix) with ESMTP id 42DAE44FB2; Mon, 8 Oct 2018 12:15:09 +0000 (UTC) To: "Ni, Ruiyu" , Ming Huang , "linaro-uefi@lists.linaro.org" , "edk2-devel@lists.01.org" , "Zeng, Star" , "Dong, Eric" Cc: "huangming23@huawei.com" , "zhangjinsong2@huawei.com" , "Gao, Liming" , "Kinney, Michael D" , "waip23@126.com" , "wanghuiqiang@huawei.com" , "huangdaode@hisilicon.com" References: <20180915063656.6250-1-ming.huang@linaro.org> <20180915063656.6250-2-ming.huang@linaro.org> <734D49CCEBEEF84792F5B80ED585239D5BE4E5E4@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <24c5b1e2-dbd5-9dac-1b9e-da2aa8bac850@redhat.com> Date: Mon, 8 Oct 2018 14:15:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 08 Oct 2018 12:15:13 +0000 (UTC) Subject: Re: [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 12:15:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10/08/18 08:39, Ni, Ruiyu wrote: > On 9/28/2018 2:18 PM, Ming Huang wrote: >> >> >> On 9/26/2018 1:00 PM, Ni, Ruiyu wrote: >>>> @@ -507,12 +552,13 @@ BmRepairAllControllers ( >>>>                                      FormBrowser2, >>>>                                      &HiiHandles[Index], >>>>                                      1, >>>> -                                   PcdGetPtr >>>> (PcdDriverHealthConfigureForm), >>>> +                                   &gEfiHiiDriverHealthFormsetGuid, >>> >>> I still don't quite understand the changes. >>> But the above specific change removes the >>> PcdDriverHealthConfigureForm form pop up. >>> Instead it pops up each driver health form one by one. >>> Why? >> >> This change is refer to the below function: >> ProcessSingleControllerHealth >> (IntelFrameworkModulePkg/Universal/Bdsdxe/DeviceMngr/DeviceManager.c). >> I don't real understand it also, but it works. >> > > I am sorry. I cannot review the changes if you cannot explain it:) > Fix should be based on the thoroughly understanding to the issue. Could it be that the RAID card driver is buggy? Thanks Laszlo