From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mx.groups.io with SMTP id smtpd.web12.423.1616117431661705846 for ; Thu, 18 Mar 2021 18:30:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OT7GORwo; spf=pass (domain: gmail.com, ip: 209.85.214.172, mailfrom: kuqin12@gmail.com) Received: by mail-pl1-f172.google.com with SMTP id l1so2186477plg.12 for ; Thu, 18 Mar 2021 18:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i/2F11uZAqke/H0iADuZ2QwfJfpnNRTVLNGYkvdpGU8=; b=OT7GORwotfTlSyT/lBTNl4OQv8kH+Jl7GJIuS8202WmcwGZkDuHLsiugLAnx5Nf+UD E1Dp2GOlcG9dF6i6DytbEWuYnB0IcsciLUhK50FbkkTkzrHRe/owhXZ8pSygZOVJv61m nS8I5m4zeyxhRoqArmsTl32tVNmlT7MRiyP+cSRsAaGSs3oBSGycm8xsxv07K8Laup3w tzE+fhkSEEhuVpvuk42xoU9fTRfoaZtvrbKaTZc/j04M7aXQb07NQBBnR7Pw3LmWONH0 DfvZSkRN8F2RdXkJypf3BQ2VZp3CQMJwlvIiTRA/SVaEuvFGgqe2KhsyRM5WdLsvqBCQ vXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i/2F11uZAqke/H0iADuZ2QwfJfpnNRTVLNGYkvdpGU8=; b=Gx2DWJsVowPzQE7NZF6f3ed6eeXQ7lCCFHqxnNppn4I2AEQXllsT+Kz8Z9YvFxZRtb G83DFA5ON49rlCtdcswV9QOm2lb05SQ8PCt+QW2zb7+yCEiWYgUbek8g86Fz7harzsFG otG83TAh8Tz+cS4PeQ9YSCXC45NqexhL0yr7Z+ksGVrbveM1MHB5QZm8Gt3VEywH14uc tSwQBUFA0xGusPSqPavxv5xdKwHEckpLpJKo4f8zEmRIRKbWKkl+eNSGt529wIA8O0a/ 9OKqntdVRvCCwfSdYXbeyepz9UWfFcw85hclNBWhx5OQBW42WUlp5gnFGPxgCdV7ZGkV BG3w== X-Gm-Message-State: AOAM530Wp7VjC/rii6lGP/jffgzdBaaf27iFGCFUbebY7iuZFVR2dNKX z/ilqd8eHKPrYqOFkCI/jnM= X-Google-Smtp-Source: ABdhPJwdt/n3Ont0DB9yqtn89v+HZ7cgMkXVR0infJHmNWK9hxNZla3L5BlZMT5XtpO3AAVjRwKSUQ== X-Received: by 2002:a17:90b:10a:: with SMTP id p10mr7178972pjz.148.1616117430973; Thu, 18 Mar 2021 18:30:30 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id x7sm3625973pfp.23.2021.03.18.18.30.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 18:30:30 -0700 (PDT) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtlZGsyLXBsYXRmb3Jtc11bUEFUQ0ggdjIgNS81XSBTb2Npb25leHQ6IERldmVsb3BlckJveCBEU0MgRmlsZTogQWRkZWQgbGlicmFyeSBmb3IgVmFyaWFibGVTbW1SdW50aW1lRHhl?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, 'Ard Biesheuvel' Cc: 'Ard Biesheuvel' , 'Leif Lindholm' References: <20210316181038.1413-1-kuqin12@gmail.com> <166CE5173C17A517.7039@groups.io> <95dbf461-6f84-b3f5-3a49-31bf3d0d6dad@gmail.com> <009701d71c5f$4c8d52c0$e5a7f840$@byosoft.com.cn> From: "Kun Qin" Message-ID: <24cb27d7-8f0c-9286-be13-776b06d17af1@gmail.com> Date: Thu, 18 Mar 2021 18:30:29 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <009701d71c5f$4c8d52c0$e5a7f840$@byosoft.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Liming, Thanks for explanation. Regards, Kun On 03/18/2021 18:29, gaoliming wrote: > Kun: > Acked-by: means the maintainer agrees this change, but no time for detail code review. Based on current develop process, with Acked-by, the patch can also be merged. > > Thanks > Liming >> -----邮件原件----- >> 发件人: devel@edk2.groups.io 代表 Kun Qin >> 发送时间: 2021年3月19日 2:26 >> 收件人: Ard Biesheuvel >> 抄送: devel@edk2.groups.io; Ard Biesheuvel ; >> Leif Lindholm >> 主题: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: >> DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe >> >> Hi Ard, >> >> Thanks for providing the tag. For my own learning purpose, could you >> please let me know how I can get a "reviewed-by" tag for this change? >> Should I add more reviewers than package maintainers listed on >> "Maintainers.txt"? >> >> Thanks for the help. >> >> Regards, >> Kun >> >> On 03/18/2021 11:14, Ard Biesheuvel wrote: >>> On Thu, 18 Mar 2021 at 19:07, Kun Qin wrote: >>>> >>>> Hi Ard/Leif, >>>> >>>> Could you please review the change and let me know if you have any >>>> feedback when there is chance? I can drop the patch if this package is >>>> not supported/maintained any more. Please let me know how you would >> like >>>> to proceed. >>>> >>>> Thanks in advance. >>>> >>>> Regards, >>>> Kun >>>> >>>> On 03/16/2021 11:10, Kun Qin via groups.io wrote: >>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 >>>>> >>>>> This change added NULL MmUnblockMemoryLib instance in >> DeveloperBox.dsc to >>>>> resolve new dependency by VariableSmmRuntimeDxe. The library >> interface >>>>> is consumed by variable module to better support variable runtime cache >>>>> feature. >>>>> >>>>> Cc: Ard Biesheuvel >>>>> Cc: Leif Lindholm >>>>> >>>>> Signed-off-by: Kun Qin >>> >>> Acked-by: Ard Biesheuvel >>> >>>>> --- >>>>> >>>>> Notes: >>>>> v2: >>>>> - No review, no change. >>>>> >>>>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >> b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >>>>> index 0a11b796cca5..acaa4cd90fc5 100644 >>>>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >>>>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc >>>>> @@ -49,6 +49,8 @@ [LibraryClasses] >>>>> >> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tpm >> MeasurementLibNull.inf >>>>> !endif >>>>> >>>>> + >> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnbloc >> kMemoryLibNull.inf >>>>> + >>>>> [LibraryClasses.common.SEC] >>>>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >>>>> >> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >>>>> >> >> >> >> > > > > > > > >