From: "Rebecca Cran" <rebecca@bsdio.com>
To: Pedro Falcato <pedro.falcato@gmail.com>, devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Sai Chaganty <rangasai.v.chaganty@intel.com>,
Isaac Oram <isaac.w.oram@intel.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Intel/WhiskeylakeOpenBoardPkg: Fix ALIGN16 macro
Date: Mon, 15 May 2023 08:00:22 -0600 [thread overview]
Message-ID: <24cd8d70-6e8f-b146-5929-7f8a1dd3eb12@bsdio.com> (raw)
In-Reply-To: <CAKbZUD39iaf=4iGgrTEz3yDEQXkd_MHT+uz=t-pYfg_CVeeOvQ@mail.gmail.com>
On 5/15/23 07:22, Pedro Falcato wrote:
> As I mentioned on Discord, ALIGN16 should not need a branch like this.
> I propose switching ALIGN16 to use ALIGN_VALUE, or if you need compat
> with older edk2s, even:
>
> #define ALIGN16(size) (((size) + 15) & -16)
>
> Which is a common enough pattern that it hopefully is self-explanatory.
Thanks. I realized ALIGN16 isn't even used anymore, so I've just sent
out a v2 patch to just delete them.
--
Rebecca Cran
next prev parent reply other threads:[~2023-05-15 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 5:43 [PATCH edk2-platforms 0/2] Platform/Intel/WhiskeylakeOpenBoardPkg: Fix UpXtreme build Rebecca Cran
2023-05-15 5:43 ` [PATCH edk2-platforms 1/2] Platform/Intel/WhiskeylakeOpenBoardPkg: Fix ALIGN16 macro Rebecca Cran
2023-05-15 13:22 ` [edk2-devel] " Pedro Falcato
2023-05-15 14:00 ` Rebecca Cran [this message]
2023-05-15 5:43 ` [PATCH edk2-platforms 2/2] Platform/Intel/WhiskeylakeOpenBoardPkg: Delete unused include files Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24cd8d70-6e8f-b146-5929-7f8a1dd3eb12@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox