From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web10.89395.1684159225192923998 for ; Mon, 15 May 2023 07:00:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=d5OWneYo; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 018F83200908; Mon, 15 May 2023 10:00:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 15 May 2023 10:00:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1684159223; x=1684245623; bh=z2SIFKsavoF18BsuVJDua7s3YbmhPHAtiWD 2sXlb+z4=; b=d5OWneYoQvgG0xyq4qp77tqmQbE0B47xBV5Ypn03KvJbZJAFDds sNNwGqv9TPCneu++viYY0Hr9HIClun6h9GtWnoyLpWMOsW3t2OsOtZ1ZBFK4ebzm wkAwBMG5eAMPsNehrGP9I5oGz2tclVuevTkDBaE0y2eWynmy+uWBPME0Gvd0jkgy YK/l+VXzfk5LcV92L3uQ2XjZMh3RL91lZFymZgU4VBs9P6c2FyatHouizWhFINk3 yfFlPTPCQ2e5CwWWVuKUAj1+Q2qPb6eDWi6xiERMxMzVUcScmXS5HmBnLgdeid7H hm0uMxEyMG+rSV3LGzHOiQ2b9JZTNx/uNDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684159223; x=1684245623; bh=z2SIFKsavoF18BsuVJDua7s3YbmhPHAtiWD 2sXlb+z4=; b=ZxnTpdy2vJzgWvI16SjFUjVhDdktCWMp5blR/75hbDxxVtjU+n6 MGKfIuS2PJp/+pAlXAn2TVrdVpsEJbS/y2gDohpsRkzwotK5uHb/Fr62JBjT8grd RWNbsG0iFu85hH+KPNptQXYe9drgX06dLvUUHWNDTvHqpxikB/91E+OVgE5KnXcw 2uEGSz7LShzSfxdLX30m3XoHIhmtA0tXfTB9rLxjHXt9Jy3acRAIin1Ui9sNf7/s 8hmmvOaoZpKqTWOzXQkgXRB20Jtxj0QL4/X2GmkE7iQT+2fWvtIjmpK4YGXDUmP6 GPruJdUvx0NtwrJbaWqtqTQ+2YmGbSXdX3A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehjedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 May 2023 10:00:22 -0400 (EDT) Message-ID: <24cd8d70-6e8f-b146-5929-7f8a1dd3eb12@bsdio.com> Date: Mon, 15 May 2023 08:00:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Intel/WhiskeylakeOpenBoardPkg: Fix ALIGN16 macro To: Pedro Falcato , devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Sai Chaganty , Isaac Oram References: <20230515054329.3224434-1-rebecca@bsdio.com> <20230515054329.3224434-2-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/15/23 07:22, Pedro Falcato wrote: > As I mentioned on Discord, ALIGN16 should not need a branch like this. > I propose switching ALIGN16 to use ALIGN_VALUE, or if you need compat > with older edk2s, even: > > #define ALIGN16(size) (((size) + 15) & -16) > > Which is a common enough pattern that it hopefully is self-explanatory. Thanks. I realized ALIGN16 isn't even used anymore, so I've just sent out a v2 patch to just delete them. -- Rebecca Cran