From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.40]) by mx.groups.io with SMTP id smtpd.web09.7082.1666787892130588004 for ; Wed, 26 Oct 2022 05:38:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=d8mJFAbX; spf=pass (domain: arm.com, ip: 40.107.22.40, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Kn2itDuUhcShETkDXT7cUZwBr3iHjgmZ67XzAPG6dPXQCn0uXIHEIVmB8I7Rk57HXJgmYu9ros1qLD9dl+3H0D9HIoqB7uBy2lqH9//qnnN25ZUGM6WuitWbOc1+6rmPalPPoKBXwT1+Cbr7O8JZ27Bb+dYn4+2tz8SRVBe7PuYzdRsGyvvJva20i12PNrg88RIic2K9FcPaC6WLDX4kGA9YxYWZs1P8K5Rsejb5hajHyY0VQPhAAQa6FxKESv8jnATwUzw8AgzsKZGeqHT7STz7RYnywTSJQjv/cVHEu0ZtAUd+wLQ3PL0cWkqsYWjrwzc/ud165xwE4gX9CHmbCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hczEj3v8BU6PaEUxiAdedsmkRp/qy/XUBuZ5XeqhHtI=; b=JZmqB4ofxMW47ANYBUnVtMypzA6OcruE+uYERzfc5NJjbNZkyvuNNPWXS6gmybYMDY9nFoG9napFfhM31FsvV3QqWB3csYl6qHMJA0Hp/pMI3yJRy5H+3XZs6F9LnzpaY1dL9ZdAAQ8hmBqJq+XLleAyt5gEuQIXQh/De0GqmQR3IqGQb8jeiQQIEbkh+fWJISuJ9gB64gj1CyL8mElnp4sLM5rLrDrcm5LwnwIRmjvH6GXqrU8gMqHcqFKaTgLyK17aHjjEDNr1XA1qOS6J4WZRynqo8sicwD5YfXjqtHY9fLlPE9SjrjBuY/twcHSyTlDorghUzl1tYP9DBUbUuA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hczEj3v8BU6PaEUxiAdedsmkRp/qy/XUBuZ5XeqhHtI=; b=d8mJFAbXmIIUaU8rOpGlIh5fBvWKSXq9uyktHxMPBcENK6ZmLO14sjvGWGGjYg7Kno+Np8bKTZChReY52Hcq26g7fIzFxwZa/4MEYpewSR3SxVOktFod+0WLWNX+CMfU6KkTMiNhgAZPCkCn47A4+I4KoZ/JJoqimC8WMpC1Sfc= Received: from DU2PR04CA0184.eurprd04.prod.outlook.com (2603:10a6:10:28d::9) by AS8PR08MB9432.eurprd08.prod.outlook.com (2603:10a6:20b:5ec::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 12:38:08 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::8c) by DU2PR04CA0184.outlook.office365.com (2603:10a6:10:28d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend Transport; Wed, 26 Oct 2022 12:38:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.20 via Frontend Transport; Wed, 26 Oct 2022 12:38:08 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Wed, 26 Oct 2022 12:38:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6eedc2b72e2306b3 X-CR-MTA-TID: 64aa7808 Received: from dbb3e110fce9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 39E7DECE-8C31-49FD-842A-45AF17ACCFB4.1; Wed, 26 Oct 2022 12:37:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbb3e110fce9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:37:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nvoh2e0NPf+6J6okJza9v820Eq3+qY7ajHGVX7OwckYl04OFWz08i4arqr8O1liKf0JZC0NTI7jj5E01aFIcgZy+XLHMLZBMlJb3+REcvr9NoNM9mu+we61jILBH+WnpDg5dCW7o1hV19i30iuRr1/ncI6Mj4/LDU0zxcQVDSMhMzGquhN4DE2vKFcaqQjQ2MNm7iHe5s9qiSgv1Mw/9/sd1kU25p1pKecwKfj/5lrJsNI22C9gfALbicbdOHyTk/khBrLhNfTKDeOXdpk3hvY9nTPNR/QRA89JE0e2/PorTkjQ6O5S+vFalQtOwu91cAcvwZ0S+L12ft7H0WU9Q3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hczEj3v8BU6PaEUxiAdedsmkRp/qy/XUBuZ5XeqhHtI=; b=nw1Y7hJAgjTXrEftTr7F62Mp5qCw27B7aS/yjtvsUnpFsG8t1VPpjoekFHFYkGXDuVphBI87+x7wbuRx/xZeesPFiK3AP/EXZi54jN0SMviEGxGeLWwoigE+u7B4hesZARm++aKkDzmkwthnLFRjjnp3jqKbj4ZmiC6NeqN3w3nnWf+aRRrcdtpznFkCGDlPQsRx122AstSHyZXLtxjmXzyYoljOpS6R4ML+qzMmxWPMRUJzC6u1DKk8NdcSAebTzrO3jAQMCe8AJi8zgewUl0sB6yFBdmFPF28NuwufHXSHLixegNyAvGT/IZa+aQhMHKpzbfmdN68m/0CaNaXKog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hczEj3v8BU6PaEUxiAdedsmkRp/qy/XUBuZ5XeqhHtI=; b=d8mJFAbXmIIUaU8rOpGlIh5fBvWKSXq9uyktHxMPBcENK6ZmLO14sjvGWGGjYg7Kno+Np8bKTZChReY52Hcq26g7fIzFxwZa/4MEYpewSR3SxVOktFod+0WLWNX+CMfU6KkTMiNhgAZPCkCn47A4+I4KoZ/JJoqimC8WMpC1Sfc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB9PR08MB6556.eurprd08.prod.outlook.com (2603:10a6:10:261::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 12:37:52 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:37:52 +0000 Message-ID: <24e44ff4-1606-b67c-0a53-a18c19bd1642@arm.com> Date: Wed, 26 Oct 2022 13:37:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 09/14] DynamicTablesPkg: Fix Ssdt PCI generation comments To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-10-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-10-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P265CA0373.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::25) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB9PR08MB6556:EE_|DBAEUR03FT059:EE_|AS8PR08MB9432:EE_ X-MS-Office365-Filtering-Correlation-Id: d458c57d-7ef3-4933-3eb7-08dab74eefda x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +nOqF+UDVRPwKo4byvmmBSZtcMEFH7WGEXXmQ1qGV1nF8eGjs2IZgUmpThzdQaom+nDCRU+B+OaMC5GqYJ3/dDXzS5qM3AARL5vEnKGvUinin3cLgxss/4qIWHx0aqHPJXih7K/n04pFYWIFpt4kRCewp+4lQKZS3SUW7ZPhzW/xxU/4WTWUUrGPyvPnPdA5pihIA9SCb5wCoS3jtf+WQfQBcemd5wiSOZbIVSUH5noxfFBeeJ5SE3myuNQpL8nioEy2Y7HnjaNSB+nQ1uaGzJ8ejzQHLcBxjnNEsMZBlQZGayGr/SAnFQuq+d3Fi9/iOPE4n0BzlL9ct9sORu7/4Hl1KwecNuzFbcIg/39s+DAl2kb5BD60f2IERadAKZsDAWyltAbZj7QE5MGP8/zK2/kvUQie5EpPbNmYIKv/4zxCubOfdw5MGoEaaodSb/6+0vsF3BTLcTTV09PxC6F/KrJnHrFT+DKhAW9MZW9P8gCyx5GK8t48JMgZT8Om9KdMp/jUlk+d0sCAyFnmGt0cN5c9jGk6IU6mM/Z6KxsnYjG9kXfPsYY3l5xzmT03sMGQWzpe34PqM/9vXGs/gsIq5Z/5EVqTflWiPKCuG9vGwYnAaVRkfiFfUlV70Ny9ZTj6O78dn9+Epu3ahFk5D0+U4X3Oxk+M4jjwMdK0DeDXF95xt4iWErMSrEq+WfgyVamA6I0s7x5Nt4G00SP+8eBlk/8WMKTPYKAEAnOAVzI0CsWz4bYgx39ygUd10UJVyqpwJZrDASU7Q3/vSgkFt6JvZnv+On0+C5QbNKEfmcShknM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(366004)(39860400002)(346002)(396003)(451199015)(41300700001)(53546011)(6506007)(38100700002)(36756003)(5660300002)(54906003)(31696002)(66946007)(316002)(8676002)(66476007)(44832011)(6486002)(4326008)(8936002)(478600001)(66556008)(86362001)(31686004)(83380400001)(2616005)(6512007)(2906002)(26005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6556 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a8e3b05c-aba1-4784-12a5-08dab74ee61c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2n9whkIz4tGFVCt8JZRJPaQ1vQrYUUvJWmpXSRrDfdfQe3HTvY+jp3VqAWLMiDNizS2J34oh6qMJ+71os/R/d1rkiXYcngQYJDCDdmlqmoxDqkALvXfhFIt1W1MKHXywYueWiqDJsdKZ8MrNOQA3kvo1QcOaEkA4CZ6EbwzPbU5kjFhGJKGOoLviiNh+6R6FqNLLGWVhKTE1BSTlPIDPJab9Ay2yy4rZNH0TsJnSg42RMjVZM5b2XdWZ7ELxBEDxOApX0jkwO1CA1P7vjm6V/YoJTHKyC2pWrHgaXJPkR3I2fGNC+1A2wH80C7JpSx1utM6xf3FsP08sf6BY1FCKUqs/atQduj1UUc39SEoAxc3s/oZSduJQ9Lhpa7L6CmKshF8nA/M7T1NC65hE7VN102OChuOGof9d1d8ntFfVPPeuXy+ijp6834cnZbiRyJofpt08DRsqGF4MTVyC3qX+bQ8W77Lr4IOjKYgb8px9qyRj2Sd9tQ6ZctwYsRty88pj3LUTR/TKaXxYRMOAVWm3VUAcSFnSO6Ki/5rgGeODGPW1zX5ZtqwgUavRzh0fyvqTbLRLhFGIEeQrdn42HfV8gbOlwaCQ1SZM9EXOzV4ACVpzU1Zw7Qq249ekbKYkJpXpHjIh7vT/iV4I+RA/zHQSrK+AK8jrREtJlV03MfMVVwDaNc5064HEqQtxFcj4M5Cu7mcGYrZ/+PsPjAJ9xhMapUNVyirF2yAUo69xNTLwm8Lf/W/0qOpKZG63dT/oeUkEAGLK30IpY0KwzmzV12JQ4fRt8EiuVXtwg2zrn6qe45aVbbCOf8p0GZLBFw8IReYi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(81166007)(356005)(36860700001)(36756003)(86362001)(31696002)(40480700001)(70206006)(70586007)(82740400003)(4326008)(40460700003)(54906003)(316002)(8676002)(44832011)(8936002)(186003)(336012)(41300700001)(5660300002)(47076005)(2616005)(6506007)(478600001)(6486002)(2906002)(53546011)(26005)(83380400001)(6512007)(31686004)(82310400005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:38:08.5579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d458c57d-7ef3-4933-3eb7-08dab74eefda X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9432 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > The second model of the _PRT object is used. Indeed: > - the interrupts described are not re-configurable > - OSes are aware of the polarity of PCI legacy interrupts, > so there is no need to accurately describe the polarity. > > Also, fix a comment for the CM_ARM_PCI_INTERRUPT_MAP_INFO obj. > > Signed-off-by: Pierre Gondois > --- > DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 2 +- > .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 8 ++------ > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h > index cd39e609d6c4..d711f3ec5938 100644 > --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h > +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h > @@ -1014,7 +1014,7 @@ typedef struct CmArmPciInterruptMapInfo { > /// Value on 8 bits (max 255). > UINT8 PciBus; > > - /// Pci Bus. > + /// Pci Device. > /// Value on 5 bits (max 31). > UINT8 PciDevice; > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > index 85098752c614..c54ae6f551f6 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > @@ -288,12 +288,6 @@ GeneratePciDeviceInfo ( > > Cf. ACPI 6.4 specification, s6.2.13 "_PRT (PCI Routing Table)" > > - The first model (defining a _CRS object) is used. This is necessary because > - PCI legacy interrupts are active low and GICv2 SPI interrupts are active > - high. > - Even though PCI interrupts cannot be re-routed, only the first model allows > - to specify the activation state (low/high). > - > @param [in] Generator The SSDT Pci generator. > @param [in] CfgMgrProtocol Pointer to the Configuration Manager > Protocol interface. > @@ -397,6 +391,8 @@ GeneratePrt ( > High word-Device #, Low word-Function #. (for example, device 3, > function 2 is 0x00030002). To refer to all the functions on a device #, > use a function number of FFFF). > + > + Use the second model for _PRT object and describe a hardwired interrupt. > */ > Status = AmlAddPrtEntry ( > (IrqMapInfo->PciDevice << 16) | 0xFFFF,