From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F1325740032 for ; Tue, 29 Aug 2023 23:13:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6+pVCmtPQSXAEmdjVXg2Xaug5/+Kn6AgqWYDTf6lYW8=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693350827; v=1; b=SKy23e8Al6GbkJqh4Z5RMhY9Ntr4x5uRzHoyXA3JdJtsujCbir1Ke1QZwXg8RzUiTqkzvV2c ZAhPszqR0KYr/juv4H3OuwsPC9WdUKHPnaDnGXJWKDARy1v5Bb2vWJ+opemdIxW8yTs/xYlxMP2 C4sUo0PEMUqwWyh0u+wFIgtY= X-Received: by 127.0.0.2 with SMTP id HbjUYY7687511x5xlBNVc5wf; Tue, 29 Aug 2023 16:13:47 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.2024.1693350826896230784 for ; Tue, 29 Aug 2023 16:13:46 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id D924F2129BE6; Tue, 29 Aug 2023 16:13:45 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D924F2129BE6 Message-ID: <24eb8e60-7ead-ad03-483f-6d9b6a999c5b@linux.microsoft.com> Date: Tue, 29 Aug 2023 19:13:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static From: "Michael Kubacki" To: devel@edk2.groups.io, Jiewen Yao , Jian J Wang Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com References: <177B99510AB70F56.12117@groups.io> In-Reply-To: <177B99510AB70F56.12117@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZNqPYSkBkESV3z4Kr56qBBozx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SKy23e8A; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello, Can you please help review this change when you get a chance? Thanks, Michael On 8/15/2023 11:50 AM, Michael Kubacki wrote: > From: Michael Kubacki >=20 > The global variable has a common name that can conflict with other > TCG modules. For example, Tcg2Dxe has a similarly named global that > is of type EFI_TCG2_PROTOCOL instead of EFI_TCG2_PROTOCOL*. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Signed-off-by: Michael Kubacki > --- > SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c b/= SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > index 3c8cf4fa117a..c792b1d67b06 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include > #include > =20 > -EFI_TCG2_PROTOCOL *mTcg2Protocol =3D NULL; > +STATIC EFI_TCG2_PROTOCOL *mTcg2Protocol =3D NULL; > =20 > /** > This service enables the sending of commands to the TPM2. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108101): https://edk2.groups.io/g/devel/message/108101 Mute This Topic: https://groups.io/mt/100760659/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-