* [PATCH 1/1] BaseTools:Fix build tools print traceback info issue
@ 2020-03-20 3:57 Fan, ZhijuX
2020-03-20 5:12 ` Bob Feng
2020-03-24 1:04 ` Bob Feng
0 siblings, 2 replies; 3+ messages in thread
From: Fan, ZhijuX @ 2020-03-20 3:57 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Zhiju . Fan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610
We meet a case that the DEC file declaring the PCD isn't
included in the INF.it cause build tools report Traceback error.
Remove raise statements that generate Tracebacks that were only
intended for development/debug. With the raise statements removed
proper error messages are shown.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
index 40b448f5b2db..563d91b421ce 100755
--- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
@@ -256,7 +256,6 @@ class AutoGenWorkerInProcess(mp.Process):
CacheResult = Ma.CanSkipbyPreMakeCache()
except:
CacheResult = False
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
if CacheResult:
@@ -273,7 +272,6 @@ class AutoGenWorkerInProcess(mp.Process):
CacheResult = Ma.CanSkipbyMakeCache()
except:
CacheResult = False
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
if CacheResult:
@@ -285,7 +283,6 @@ class AutoGenWorkerInProcess(mp.Process):
except Empty:
pass
except:
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
finally:
self.feedback_q.put("Done")
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue
2020-03-20 3:57 [PATCH 1/1] BaseTools:Fix build tools print traceback info issue Fan, ZhijuX
@ 2020-03-20 5:12 ` Bob Feng
2020-03-24 1:04 ` Bob Feng
1 sibling, 0 replies; 3+ messages in thread
From: Bob Feng @ 2020-03-20 5:12 UTC (permalink / raw)
To: Fan, ZhijuX, devel@edk2.groups.io; +Cc: Gao, Liming
Zhiju, Please update the Bugzilla status.
-----Original Message-----
From: Fan, ZhijuX
Sent: Friday, March 20, 2020 11:58 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Fan, ZhijuX <zhijux.fan@intel.com>
Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610
We meet a case that the DEC file declaring the PCD isn't included in the INF.it cause build tools report Traceback error.
Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper error messages are shown.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
index 40b448f5b2db..563d91b421ce 100755
--- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
@@ -256,7 +256,6 @@ class AutoGenWorkerInProcess(mp.Process):
CacheResult = Ma.CanSkipbyPreMakeCache()
except:
CacheResult = False
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
if CacheResult:
@@ -273,7 +272,6 @@ class AutoGenWorkerInProcess(mp.Process):
CacheResult = Ma.CanSkipbyMakeCache()
except:
CacheResult = False
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
if CacheResult:
@@ -285,7 +283,6 @@ class AutoGenWorkerInProcess(mp.Process):
except Empty:
pass
except:
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
finally:
self.feedback_q.put("Done")
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue
2020-03-20 3:57 [PATCH 1/1] BaseTools:Fix build tools print traceback info issue Fan, ZhijuX
2020-03-20 5:12 ` Bob Feng
@ 2020-03-24 1:04 ` Bob Feng
1 sibling, 0 replies; 3+ messages in thread
From: Bob Feng @ 2020-03-24 1:04 UTC (permalink / raw)
To: Fan, ZhijuX, devel@edk2.groups.io; +Cc: Gao, Liming
Reviewed-by: : Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Fan, ZhijuX
Sent: Friday, March 20, 2020 11:58 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Fan, ZhijuX <zhijux.fan@intel.com>
Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610
We meet a case that the DEC file declaring the PCD isn't included in the INF.it cause build tools report Traceback error.
Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper error messages are shown.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
index 40b448f5b2db..563d91b421ce 100755
--- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
@@ -256,7 +256,6 @@ class AutoGenWorkerInProcess(mp.Process):
CacheResult = Ma.CanSkipbyPreMakeCache()
except:
CacheResult = False
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
if CacheResult:
@@ -273,7 +272,6 @@ class AutoGenWorkerInProcess(mp.Process):
CacheResult = Ma.CanSkipbyMakeCache()
except:
CacheResult = False
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
if CacheResult:
@@ -285,7 +283,6 @@ class AutoGenWorkerInProcess(mp.Process):
except Empty:
pass
except:
- traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
finally:
self.feedback_q.put("Done")
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-24 1:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-20 3:57 [PATCH 1/1] BaseTools:Fix build tools print traceback info issue Fan, ZhijuX
2020-03-20 5:12 ` Bob Feng
2020-03-24 1:04 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox