From: "Jason Lou" <yun.lou@intel.com>
To: Jason Lou <yun.lou@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.
Date: Thu, 01 Apr 2021 01:41:41 -0700 [thread overview]
Message-ID: <25152.1617266501208872998@groups.io> (raw)
In-Reply-To: <20843.1616659080240333148@groups.io>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
1. Since the time it takes to find specified GUID Extension Hob (CpuCrystalFrequencyHob: about 2000ns)
is much longer than it takes to calculate TSC frequency with CPUID (about 450ns), I recommend using
BaseCpuTimerLib instead of PeiCpuTimerLib.
2. The time it takes to get TSC frequency from global variable is shorter than it takes to calculate TSC
frequency with CPUID, but 450ns is really a short time, the impact on the platform is very limited.
In addition, in order to simplify the code, recommend using BaseCpuTimerLib instead of DxeCpuTimerLib.
If anyone has questions or concerns, please feel free to let me know. If not, I will submit code patch later,
thanks.
Jason Lou
[-- Attachment #2: Type: text/html, Size: 773 bytes --]
prev parent reply other threads:[~2021-04-01 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 3:57 [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib yun.lou
2020-09-25 5:25 ` Ni, Ray
2020-09-25 6:46 ` Laszlo Ersek
2020-09-25 14:14 ` [edk2-devel] " Zeng, Star
2021-03-25 7:58 ` Jason Lou
2021-04-01 8:41 ` Jason Lou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25152.1617266501208872998@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox