public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: scott.wiginton@hpe.com
To: Michael D Kinney <michael.d.kinney@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs
Date: Mon, 21 Oct 2019 06:12:11 -0700	[thread overview]
Message-ID: <25159.1571663531909616677@groups.io> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9DEDF9B@ORSMSX113.amr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

Michael,

Wouldn't the current implementation ASSERT if there are different plug-in cards by the same vendor using the same GUID in their FMP?  They are managing different hardware and have no knowledge of the existence of the other FMP instance.  Each FMP is only aware of the specific device on whose handle they are installed.  If they use FW image descriptors below version 2 (or they cannot determine a unique HW instance), this would always be 0.  Why would we want to ASSERT in this case?  What error condition is being caught?

Thanks,
SWig

[-- Attachment #2: Type: text/html, Size: 600 bytes --]

  reply	other threads:[~2019-10-21 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30 20:48 Recent changes to EsrtFmp causing ASSERTs jason.spottswood
2019-09-30 20:52 ` [edk2-devel] " Rothman, Michael A
2019-09-30 21:23   ` jason.spottswood
2019-10-01 16:49     ` Sean
2019-10-01 17:30     ` Michael D Kinney
2019-10-01 21:20       ` Spottswood, Jason
2019-10-02 15:12         ` Michael D Kinney
2019-10-18 21:52           ` scott.wiginton
2019-10-19  1:03             ` Michael D Kinney
2019-10-21 13:12               ` scott.wiginton [this message]
2019-10-21 16:30                 ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25159.1571663531909616677@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox